DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	patrick.fu@intel.com, dev@dpdk.org, chenbo.xia@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] vhost: fix wrong async completion of multi-seg packets
Date: Tue, 21 Jul 2020 15:57:14 +0100	[thread overview]
Message-ID: <2042eb52-7718-d911-c393-dc4d73108c00@intel.com> (raw)
In-Reply-To: <145b4c3e-970f-ae39-2ea4-accc8f95c151@redhat.com>

On 7/21/2020 9:40 AM, Maxime Coquelin wrote:
> On 7/21/20 7:47 AM, patrick.fu@intel.com wrote:
>> From: Patrick Fu <patrick.fu@intel.com>
>> In async enqueue copy, a packet could be split into multiple copy
>> segments. When polling the copy completion status, current async data
>> path assumes the async device callbacks are aware of the packet
>> boundary and return completed segments only if all segments belonging
>> to the same packet are done. Such assumption are not generic to common
>> async devices and may degrees the copy performance if async callbacks
> s/degrees/degrades/
>> have to implement it in software manner.
>> This patch adds tracking of the completed copy segments at vhost side.
>> If async copy device reports partial completion of a packets, only
>> vhost internal record is updated and vring status keeps unchanged
>> until remaining segments of the packet are also finished. The async
>> copy device is no longer necessary to care about the packet boundary.
>> Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring")
>> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> With above typo fixed (can be done when applying, no need to resend):
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-net/master, thanks.

      reply	other threads:[~2020-07-21 14:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15  7:46 [dpdk-dev] [PATCH v1] vhost: support async copy free segmentations patrick.fu
2020-07-15 11:15 ` [dpdk-dev] [PATCH v2] " patrick.fu
2020-07-17  3:21   ` Xia, Chenbo
2020-07-17 11:52     ` Ferruh Yigit
2020-07-20 14:58   ` Maxime Coquelin
2020-07-20 16:49     ` Ferruh Yigit
2020-07-21  5:52     ` Fu, Patrick
2020-07-21  5:47 ` [dpdk-dev] [PATCH v3] vhost: fix wrong async completion of multi-seg packets patrick.fu
2020-07-21  8:40   ` Maxime Coquelin
2020-07-21 14:57     ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2042eb52-7718-d911-c393-dc4d73108c00@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=patrick.fu@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).