From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michal Kobylinski <michalx.kobylinski@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add config structure
Date: Wed, 02 Mar 2016 16:28:57 +0100 [thread overview]
Message-ID: <2044358.OMRF2VQKlE@xps13> (raw)
In-Reply-To: <1454069573-12059-2-git-send-email-michalx.kobylinski@intel.com>
Hi,
As suggested by Bruce, I'm looking to apply this patchset before the ARM one.
Please check the comments below.
Is it possible to split the changes in next_hop and config structure?
> --- a/doc/guides/rel_notes/release_2_3.rst
> +++ b/doc/guides/rel_notes/release_2_3.rst
> @@ -18,7 +18,11 @@ Drivers
>
> Libraries
> ~~~~~~~~~
> +** librte_lpm: Increase number of next hops for IPv4 to 2^24 **
>
> +Extend next_hop field from 8-bits to 24-bits for IPv4. Changed structures:
> +rte_lpm_tbl24_entry and rte_lpm_tbl8_entry to one structure rte_lpm_tbl_entry.
> +Added a new rte_lpm_config structure.
The spacing is wrong here. Please check also the past tense.
There is a template in the release notes.
> +BIND_DEFAULT_SYMBOL(rte_lpm_add, _v23, 2.3);
> +MAP_STATIC_SYMBOL(
> + int rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
> + uint32_t next_hop), rte_lpm_add_v23);
The version will be 16.04 instead of 2.3.
next prev parent reply other threads:[~2016-03-02 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 12:12 [dpdk-dev] [PATCH v2 0/2] Increase number of next hops for LPM IPv4 Michal Kobylinski
2016-01-29 12:12 ` [dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add config structure Michal Kobylinski
2016-02-18 10:02 ` Hunt, David
2016-03-02 15:28 ` Thomas Monjalon [this message]
2016-03-02 16:23 ` Kobylinski, MichalX
2016-03-02 16:35 ` Thomas Monjalon
2016-01-29 12:12 ` [dpdk-dev] [PATCH 2/2] examples: update to use new lpm lib for ip4 Michal Kobylinski
2016-02-18 10:02 ` Hunt, David
2016-02-26 7:35 ` [dpdk-dev] [PATCH v2 0/2] Increase number of next hops for LPM IPv4 Xu, HuilongX
2016-03-08 15:13 ` Thomas Monjalon
2016-03-08 15:53 ` Kobylinski, MichalX
2016-03-08 16:31 ` Thomas Monjalon
2016-03-08 21:00 ` Kobylinski, MichalX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2044358.OMRF2VQKlE@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=michalx.kobylinski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).