From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 6BEF2376D for ; Wed, 2 Mar 2016 16:30:32 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id p65so82986457wmp.0 for ; Wed, 02 Mar 2016 07:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Xh3vTTA0QCQu2ywZWNMJHVzgjDP+DMfblcdBjZGFDs8=; b=IHjORdCtAIHeGU7cAxOv9Xp/zLYP5GISmsOMZSeGLZRMKZDWXCyfC0TpEhyenEoTNA bq9bBsz6te5FarUm0sQZ8YwFP4QmBbcUU3hod4g8VJqDLNjrkTecnl3vYggXOFuBxoYB uJa/Qa1bEu3SI/lyza4Pug516gGYy2AMmq+AbUOdqBs0PRB3xxsom+MSbdzJ2iUWVV+Z nTaHIhBA1tELbb9jVMxNrwPZNyF22JfHAyZCB2DTBPHA9FmBW/Oq2gWg+pARiKHylWb+ muulq9PrQCjun+ivVsu0UKsKcZDlRXjIkNCjvebdInbSUC4tpdTMUp5sKCobbeNrwkUF zcVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=Xh3vTTA0QCQu2ywZWNMJHVzgjDP+DMfblcdBjZGFDs8=; b=bBrS/cIr59gY96liOQZQuVE2LbGKMvPS9x+dR3P4Y2LhmyhxLJOG7uvWGJAdoyb+yE Ze2LWjPRcweGElN+S3adoqq6WW1j7QDndVHZZBHDOfeDnGZ4arHFGkLdrJKPlPVyYdFZ MNlTvpNwJHMQqHljaFKrEOCkA31stpEFbDWk7rECZ4GGaYuS6EKnuKvy8f8lJBF8hLZP HnZqE6ndypwGp97icg9s12EkoQx4sI9VIMbidr2ky4KUQohsZB9h0ryvASeCPf4oCqG4 0HyAYH6BtMbJi2mSEZRfuKcujizeRPHiDCjY4N+HKewD24I9+PL83C+VkE+pX/PB/fI4 OpjA== X-Gm-Message-State: AD7BkJIuS+jXL7mzYoXC4MLNIMLqp+15VuWTXdDzWcOyOvmZRxgP/J39wrN3XH4pBBQYqgpW X-Received: by 10.28.87.139 with SMTP id l133mr521375wmb.38.1456932632224; Wed, 02 Mar 2016 07:30:32 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id av3sm36513377wjc.44.2016.03.02.07.30.31 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Mar 2016 07:30:31 -0800 (PST) From: Thomas Monjalon To: Michal Kobylinski Date: Wed, 02 Mar 2016 16:28:57 +0100 Message-ID: <2044358.OMRF2VQKlE@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1454069573-12059-2-git-send-email-michalx.kobylinski@intel.com> References: <1454069573-12059-1-git-send-email-michalx.kobylinski@intel.com> <1454069573-12059-2-git-send-email-michalx.kobylinski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] lpm: extend ip4 next_hop and add config structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 15:30:32 -0000 Hi, As suggested by Bruce, I'm looking to apply this patchset before the ARM one. Please check the comments below. Is it possible to split the changes in next_hop and config structure? > --- a/doc/guides/rel_notes/release_2_3.rst > +++ b/doc/guides/rel_notes/release_2_3.rst > @@ -18,7 +18,11 @@ Drivers > > Libraries > ~~~~~~~~~ > +** librte_lpm: Increase number of next hops for IPv4 to 2^24 ** > > +Extend next_hop field from 8-bits to 24-bits for IPv4. Changed structures: > +rte_lpm_tbl24_entry and rte_lpm_tbl8_entry to one structure rte_lpm_tbl_entry. > +Added a new rte_lpm_config structure. The spacing is wrong here. Please check also the past tense. There is a template in the release notes. > +BIND_DEFAULT_SYMBOL(rte_lpm_add, _v23, 2.3); > +MAP_STATIC_SYMBOL( > + int rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth, > + uint32_t next_hop), rte_lpm_add_v23); The version will be 16.04 instead of 2.3.