From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id F222725D9 for ; Mon, 17 Sep 2018 15:39:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 0C832315; Mon, 17 Sep 2018 09:39:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 17 Sep 2018 09:39:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=pBqDk02qK1UtYsG0FhJKmT7obl XtdgG+c4ZqSo4Z1cs=; b=Zz+Sb5/uQOeC3t1HlrWrH8/eN23YoeD6+EbbBRTAy1 Cj9aOxQ/yAaTwEgH/Mtgwgwv3uKCUwoDRHRbCd0o+mkxRh4DQ/E0WYbv4xoQHf8r Iv79EpdDOpZSpggwh10ohnk52ccqDJIvhJB4CPAqebN3yAS2vHES6X7KpMFMLns4 c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=pBqDk0 2qK1UtYsG0FhJKmT7oblXtdgG+c4ZqSo4Z1cs=; b=wKewLwdLWUiaF6iuv60vE4 SVccQ63fdpPVMfwIKXmg7X0Gh+BSmd1mtomTJh/5p3RZy7EWHVOCYe4vMTtz8IZt +uoiz/CNAmvAK3eRAWzmcYosPOCKPHwds5OWIpgL9Nyk2M0/7kGrk5ZEi/DMva29 CiBwAeIu3antt42DMazcUSEzxUPD0mwLeMg2U3uKOd1bOCq9kPHThpDV4COSTgYH RSprSSqJ4rvMdHL2rdMMPVHawUkjSj7xt449ehz8X+YfRSPDikXq21nXLSgDh3/0 k7sYjrZ29dFezWdEJZEN1DkhCbPjx29qhKmIbExQgNHddKn76uoPFFID9x3OcOtg == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D6016102D4; Mon, 17 Sep 2018 09:38:59 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Mon, 17 Sep 2018 15:38:58 +0200 Message-ID: <2047675.hNTm73f6kF@xps> In-Reply-To: <20180917125402.GA3464@bricha3-MOBL.ger.corp.intel.com> References: <20180829160252.7890-1-bruce.richardson@intel.com> <4200777.W2uOughg41@xps> <20180917125402.GA3464@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 13:39:02 -0000 17/09/2018 14:54, Bruce Richardson: > On Mon, Sep 17, 2018 at 02:03:50PM +0200, Thomas Monjalon wrote: > > 29/08/2018 18:02, Bruce Richardson: > > > Add in a cross-file to enable 32-bit compile tests as part > > > of the test-meson-builds script. > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > NOTE: For ease of use, it's recommended that meson 0.47 be used for > > > this testing. With earlier versions, it may be necessary to ensure that > > > the same development packages are installed for both 64-bit and 32-bit. > > > --- > > > config/x86/i686_sse4_linuxapp_gcc | 18 ++++++++++++++++++ > > > devtools/test-meson-builds.sh | 4 ++++ > > > 2 files changed, 22 insertions(+) > > > > I'm not sure about adding this test as mandatory, because 32-bit version > > of libraries can be hard to get, especially libbsd and libnuma. > > I hope this test will be run by all developers, so we should not discourage > > them by adding too many requirements. > > Opinion? Idea? > > Libbsd is not required, but yes, libnuma is, so you do need a 32-bit > libnuma (devel) installed to run this test. I would expect that to be > available on most distros though. I'm open to suggestions as to how to make > this optional, but I do think that sanity checking 32-bit is good practice > to avoid errors, e.g. those wonderful printf format strings for uint64_t.* I agree and I am testing i686 with the "make build system". I define DPDK_DEP_NUMA=n which disables any NUMA option. Can we have this kind of tweak with meson? Or perhaps we can just have an option in the script to disable this test?