From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A097A58CE for ; Mon, 10 Jul 2017 15:51:18 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 496F8209C3; Mon, 10 Jul 2017 09:51:18 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 10 Jul 2017 09:51:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=7aaOVnoltro0UFZ h914DH/x86YIDCZPXDbMO9t6TqH0=; b=Lus++pK8Wc9X9URHKBFNT7q/hRILFRS OClU97KmihBINUacgNMDxCNLuS93XOy1rPpFCzlK3vvNS8KBri6mI4fB71+f998Y LhFOFu+YRdti/OJOciQCLp1r8t6pne1SPiMJ/dm9BU6LrfWA1bBnVkkGv4F8yB0z pPlA67nnSSYw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=7aaOVnoltro0UFZh914DH/x86YIDCZPXDbMO9t6TqH0=; b=FeiY4caS DUVTyIgU+aKgBpSdb3x6U+b+ZYsiDkIAT8te/3rIj6aDhpr+wEkkiv9V+4AL42cq U0+AZs4gaR6vqJt4gri+WITL36UeOTqhrIDKx8FgPuuLNPK0XfXCkKroMzfoUPUU OZ3FYb0aDTnROyZ1l0QucvhAOw1CJT5LZWtPFTTNEWgoZVbpQSrMna0pNe5/9yZS gymIBdU2eVXvL3VtJcsA4ixeHTMV0RyXnGYzxfq6JLpb37MwQcNEJ+K/CNheye45 Nw4VWbK4ByNtoHJ7XjsTikX5Ou224uleOpLBn+EYKqbSLKbfb64Q0UYoJ1zqVNO6 pBrFSs0EmSfOAQ== X-ME-Sender: X-Sasl-enc: DD2HDqGvKzsO7BmMJselrDe7QCrtQQlmpFOO3mudUDpd 1499694677 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ED8FD24776; Mon, 10 Jul 2017 09:51:17 -0400 (EDT) From: Thomas Monjalon To: santosh Cc: Olivier Matz , dev@dpdk.org, bruce.richardson@intel.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, shreyansh.jain@nxp.com, gaetan.rivet@6wind.com, sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, stephen@networkplumber.org, maxime.coquelin@redhat.com Date: Mon, 10 Jul 2017 15:51:17 +0200 Message-ID: <2047844.48kPz2y3QI@xps> In-Reply-To: <1f4d2538-a8bb-d729-8924-1a9a4e00a853@caviumnetworks.com> References: <20170608110513.22548-1-santosh.shukla@caviumnetworks.com> <20170710142706.4bee2ef1@platinum> <1f4d2538-a8bb-d729-8924-1a9a4e00a853@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 11/12] mempool: honor iova mode in virt2phy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 13:51:18 -0000 10/07/2017 15:30, santosh: > Hi Olivier, > > On Monday 10 July 2017 05:57 PM, Olivier Matz wrote: > > I didn't check the patchset in detail, but in my understanding, > > what we call physaddr in dpdk is actually a bus address. Shouldn't > > we start to rename some of these fields and functions to avoid > > confusion? > > Agree. > While working on iova mode thing and reading these vir2phy api - > confused me more. Actually it should be iova2va, va2iova or pa2iova,iova2pa.. > where iova address is nothing but bus address Or we should refer to linux > semantics. > > We thought of addressing semantics after this series, Not a priority in IMO. I think it is a priority to start with semantics. The work is too hard with wrong semantic otherwise.