From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9753FA0C47; Wed, 3 Nov 2021 18:52:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88B5640E0F; Wed, 3 Nov 2021 18:52:57 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 5071D40689 for ; Wed, 3 Nov 2021 18:52:56 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id F38073200E5E; Wed, 3 Nov 2021 13:52:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 03 Nov 2021 13:52:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= drNV4T4R/UGbvn/Z0OlyirYfJq9vmEDUeE1R4o5MFjM=; b=dRxZtCSQyZFHAalC 02VpBhuoIjb6H8PMxZT6DWQPI1eszCnj7QeRM+Mk6S7za84hORZY1ogWWpWzcejx Ul4iMbgkYhgdd8eMNhckoRV/t97p69gFEc3x26MZ8JDex7AGqN5bzM4HK3UQxzpZ mgIvzFS+MvNdzv5YGGi1cdG3r52DkNKFbl+PYThETYnseAc0g4MgruTOLHA6i+hi 4qXnWf7aQUYxayhkHGP4ETluKwqio90MdrcXbVYLxlt2ffujQS741826rBNm0Bc4 Y/fPE0ucqXzf2ceV2dUOLnywWZl08lwCeOzDRPdB/Hd4EKdCk+EpwSa+n82MWSop eY3ltA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=drNV4T4R/UGbvn/Z0OlyirYfJq9vmEDUeE1R4o5MF jM=; b=EWPtYwxVhIdc9j3+sM7EJS9hsGC54G0Kzd7vydnGt0hkzJ0iVxLvLs71K rQS59YmBNQl3bEkFi6OY7DYbfOiOqdCAkUcHvzBcjtF9G0qtQBs0zINY19bqPnfv pm+PzGomQsKInWI7Etv+P6sVemt3pUA9rR0nlOra32kjhWfZtsE5fsgolpvUXHeN s1erX9wtRR7odETdHidY3o6411N1B/Vv9CIISWbxzcI1K4aFFlT3ddIHWDlK7EWo uScKiGOKdR2bOh0j5BuM/HJrpfQACwCrUO7FQWnZEA1angnzDqd6ymEcVJc2m0/3 au43AC2XZupgbMkhxxhY5wFXpH9BQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtddvgddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepuedvleelteelgeekkeehgeevheejleegleehvdfgvdejgeejuedu gfevveevfeeknecuffhomhgrihhnpeguphgukhdrohhrghdptghhrghnghgvshdrrghpph enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Nov 2021 13:52:53 -0400 (EDT) From: Thomas Monjalon To: Wojciech Liguzinski Cc: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, megha.ajmera@intel.com, john.mcnamara@intel.com Date: Wed, 03 Nov 2021 18:52:51 +0100 Message-ID: <2054730.RCNjnC0MAg@thomas> In-Reply-To: <20211102235750.422908-1-wojciechx.liguzinski@intel.com> References: <20211028101802.4127295-1-wojciechx.liguzinski@intel.com> <20211102235750.422908-1-wojciechx.liguzinski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v20 0/5] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2021 00:57, Liguzinski, WojciechX: > From: Wojciech Liguzinski > > DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem > which is a situation when excess buffers in the network cause high latency and latency > variation. Currently, it supports RED for active queue management. However, more > advanced queue management is required to address this problem and provide desirable > quality of service to users. > > This solution (RFC) proposes usage of new algorithm called "PIE" (Proportional Integral > controller Enhanced) that can effectively and directly control queuing latency to address > the bufferbloat problem. > > The implementation of mentioned functionality includes modification of existing and > adding a new set of data structures to the library, adding PIE related APIs. > This affects structures in public API/ABI. That is why deprecation notice is going > to be prepared and sent. > > Wojciech Liguzinski (5): > sched: add PIE based congestion management Did you see the checkpatch issues on this patch? http://mails.dpdk.org/archives/test-report/2021-November/238253.html > example/qos_sched: add PIE support The strict minimum is to explain why you add PIE and what the acronym means, inside the commit log. > example/ip_pipeline: add PIE support Title should follow same convention as history. For examples, it start with "examples/" as the directory name. > doc/guides/prog_guide: added PIE doc should be squashed with code patches Is there any doc update related to the examples? If not, it should be fully squashed with lib changes. > app/test: add tests for PIE If there is nothing special, it can be squashed with the lib patch.