From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 813092B96 for ; Wed, 23 Mar 2016 16:18:55 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id l68so238578503wml.0 for ; Wed, 23 Mar 2016 08:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=g7WKFJW03/y4w5FJkyeb8zSBLdVL24VQO2ZhV/hkrOU=; b=GzxRNssL12gQoYv5PKvseBHR6fI3eTKgD/Xyf0PBswjPdX8s+nucYSpqKmAkxnP+ip /JhnR1QD1XWwIhJJDDH1KU8n6vPC2VOahIJk1MY0i8Y+BuHhSue/p4zZzCvRzCvYPQxH 60Xc6p3gjZejF7NR+YbMPfPr+etnuFB8CejYBKFgqR2UmjZnGmA0v6PdTKLsOXB9biUO DevA1xCRXaQ6X87ag2LtFQ3XTfEmA3S+0yUJoM/zBSdwGicAKboJkPsAmFMQMr1alQ8U dPmZvJnnL9gqQdOJmY78avk0fTZPxJU5IkCSnWZZar8q7rwJpsre1tqx+q4lm5G1mAp5 /PIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=g7WKFJW03/y4w5FJkyeb8zSBLdVL24VQO2ZhV/hkrOU=; b=LjzxWmJLPcsaXOdKiy0EUYNj4ihTNeIzJ5q78gZsMUDDAswZmu+ufygRVhKTzAbknJ BaaEg6nohV0PIkzg3GFDwwI2xGO2im4r/DWItPEMrZ+GWEOSj5L1INZCe8Fvs1FNWPNi 30M1IiFg6U6dDcLH6MeprpZ3tYGo1qMcmFtHW6n4TjXhuMW7WyNwqMksmqZjrhOMi3I2 sAyJmiddgATAHhhfB8Z09XYP+Ql9MPRxUo/XGsWCH6/XyaI1eOz+DtFEAxbv0ToR/73y ca511ca3L7eHfKQYqeKGOW0MHjVSoBnIHLT0aM+FpUNPGVp0EptEZNXfOzGU7YXcVxpK zWLg== X-Gm-Message-State: AD7BkJJpiPVbApsrq5V9NtSMwAn+67p8UU7GUAcPgFRT6IHfObbrebk1a+DFqrSLgLkGinQJ X-Received: by 10.28.214.11 with SMTP id n11mr4328407wmg.31.1458746335241; Wed, 23 Mar 2016 08:18:55 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id ls5sm3054309wjb.33.2016.03.23.08.18.53 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Mar 2016 08:18:54 -0700 (PDT) From: Thomas Monjalon To: "Wu, Jingjing" , "Liu, Yong" Cc: dev@dpdk.org Date: Wed, 23 Mar 2016 16:17:12 +0100 Message-ID: <2055843.IvPtHn5Ksq@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8DDB9F2@SHSMSX104.ccr.corp.intel.com> References: <1458524684-13539-1-git-send-email-yong.liu@intel.com> <1458629413-24771-1-git-send-email-yong.liu@intel.com> <9BB6961774997848B5B42BEC655768F8DDB9F2@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] testpmd: fix build on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 15:18:55 -0000 2016-03-23 02:17, Wu, Jingjing: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marvin Liu > > Build log: > > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named > > 's6_addr32' in 'struct in6_addr' > > rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]); > > > > This is caused by macro "s6_addr32" not defined on FreeBSD and testpmd > > swap big endian parameter to host endian. Move the swap action to i40e > > ethdev will fix this issue. > > > > Fixes: 7b1312891b69 ("ethdev: add IP in GRE tunnel") > > > > Signed-off-by: Marvin Liu > Acked-by: Jingjing Wu It looks good but something is missing to decide that it is the right fix: the API do not state wether these fields (and others) are big endian or something else. Please Jingjing, fix the ethdev comments for these fields and others rte_eth_ipv*_flow in a separate patch.