From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Rami Rosen <ramirose@gmail.com>,
Bruce Richardson <bruce.richardson@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config
Date: Wed, 20 Mar 2019 15:05:17 +0100 [thread overview]
Message-ID: <2057184.VXND6Oo4BK@xps> (raw)
In-Reply-To: <9dfea583-50f8-fbbc-c83e-0ae4419dce68@intel.com>
20/03/2019 14:56, Ferruh Yigit:
> On 3/20/2019 1:51 PM, Thomas Monjalon wrote:
> > 20/03/2019 14:46, Ferruh Yigit:
> >> Applied to dpdk-next-net/master, thanks.
> >>
> >> (only this patch merged, not series. Other patch seems waiting for comment.)
> >
> > Applying half of patchset makes tracking of patches less obvious.
> > I prefer we avoid such practice.
>
> Generally I agree, this case the patches in patchset looks can be independent
> and merged one was trivial, I tend to this for similar cases.
Even if it is independent (it is not really in this case),
it looks weird to see half of patchset pending in patchwork.
We may spend some time to understand what happened.
> Do you prefer me drop the applied patch?
You can keep it now it's applied.
next prev parent reply other threads:[~2019-03-20 14:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 10:09 [dpdk-dev] [PATCH 0/2] examples/ethtool: remove useless device info query Thomas Monjalon
2019-03-13 10:09 ` [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config Thomas Monjalon
2019-03-13 10:32 ` Bruce Richardson
2019-03-13 17:41 ` Rami Rosen
2019-03-20 13:46 ` Ferruh Yigit
2019-03-20 13:46 ` Ferruh Yigit
2019-03-20 13:51 ` Thomas Monjalon
2019-03-20 13:51 ` Thomas Monjalon
2019-03-20 13:56 ` Ferruh Yigit
2019-03-20 13:56 ` Ferruh Yigit
2019-03-20 14:05 ` Thomas Monjalon [this message]
2019-03-20 14:05 ` Thomas Monjalon
2019-03-13 10:09 ` [dpdk-dev] [PATCH 2/2] examples/ethtool: allocate only one mempool Thomas Monjalon
2019-03-13 10:34 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2057184.VXND6Oo4BK@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).