From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E36D21B134 for ; Tue, 2 Apr 2019 21:56:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 805E022145; Tue, 2 Apr 2019 15:56:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 15:56:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PF7Z+lllSnqGhys0hGZfzcPE2mb7Z0aAUSiAlrLemfw=; b=nJTHjBBd4Mve xQYsuLEvewaHC7wzaA+eKD59jSdixGGHSDkczdvuXu9RygGbyw+S6nkm9xVrTZ9o pR1uvTK2U9v1RbvpNlMOeS7HphVa+H/8JnvM5VDrCIjFO47nGWg/QWtmxPemkX0h AOWaOknOH9MoEx4hHpZOstrlZehiVXY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=PF7Z+lllSnqGhys0hGZfzcPE2mb7Z0aAUSiAlrLem fw=; b=okk69n9l6yRs68tNuEDN2OrcUnTxbbRzwNqwqWCBpOOM+56UsUn9oEaUS pyqqx0RwRr8Ybep1MVtPKNJQRGDBkO0QI0wNP2FJVLL2qqRRU2NYFSST3N+Yo32e 9LwCZuGlL3x3GbUFjrr+3JbRaHHmPwsSnC7c3go7kavH1Dc8vDYZmOyhxpDSnrv+ DZRfuUIWC99ps73mVPc5l2nrJmbiqz6N+5HczbATipCtY8ZFAv9mmypkj9SHSPPK Gif1H8bJmgVHz3QGN+JkTpNwHG0reo831wQHDciD67wCqHGR5YK9SaaEtqvD989A zXhDr+xinydyZ8A7O82G1aBFxwP7g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgdduvddvucdltddurdeguddtrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3151710396; Tue, 2 Apr 2019 15:56:47 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Tue, 02 Apr 2019 21:56:46 +0200 Message-ID: <2058052.CBssHhMYLK@xps> In-Reply-To: <20190402035458.14664-4-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-4-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 19:56:49 -0000 02/04/2019 05:54, Anand Rawat: > Added rte_os.h files to support OS specific functionality. > Updated build system to contain OS headers in the include > path. > > Signed-off-by: Anand Rawat > Reviewed-by: Pallavi Kadam > --- > --- a/meson.build > +++ b/meson.build > -global_inc = include_directories('.', 'config', 'lib/librte_eal/common/include') > +global_inc = include_directories('.', 'config', > + 'lib/librte_eal/common/include', > + 'lib/librte_eal/@0@/eal/include'.format(host_machine.system())) After having worked on rte_kni_common.h which is only in Linux, I think we should add rte_os.h in meson file of each OS: - lib/librte_eal/linux/eal/meson.build - lib/librte_eal/freebsd/eal/meson.build - lib/librte_eal/windows/eal/meson.build From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 75F79A0679 for ; Tue, 2 Apr 2019 21:56:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 68B2E1B13C; Tue, 2 Apr 2019 21:56:49 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E36D21B134 for ; Tue, 2 Apr 2019 21:56:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 805E022145; Tue, 2 Apr 2019 15:56:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 15:56:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PF7Z+lllSnqGhys0hGZfzcPE2mb7Z0aAUSiAlrLemfw=; b=nJTHjBBd4Mve xQYsuLEvewaHC7wzaA+eKD59jSdixGGHSDkczdvuXu9RygGbyw+S6nkm9xVrTZ9o pR1uvTK2U9v1RbvpNlMOeS7HphVa+H/8JnvM5VDrCIjFO47nGWg/QWtmxPemkX0h AOWaOknOH9MoEx4hHpZOstrlZehiVXY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=PF7Z+lllSnqGhys0hGZfzcPE2mb7Z0aAUSiAlrLem fw=; b=okk69n9l6yRs68tNuEDN2OrcUnTxbbRzwNqwqWCBpOOM+56UsUn9oEaUS pyqqx0RwRr8Ybep1MVtPKNJQRGDBkO0QI0wNP2FJVLL2qqRRU2NYFSST3N+Yo32e 9LwCZuGlL3x3GbUFjrr+3JbRaHHmPwsSnC7c3go7kavH1Dc8vDYZmOyhxpDSnrv+ DZRfuUIWC99ps73mVPc5l2nrJmbiqz6N+5HczbATipCtY8ZFAv9mmypkj9SHSPPK Gif1H8bJmgVHz3QGN+JkTpNwHG0reo831wQHDciD67wCqHGR5YK9SaaEtqvD989A zXhDr+xinydyZ8A7O82G1aBFxwP7g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgdduvddvucdltddurdeguddtrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3151710396; Tue, 2 Apr 2019 15:56:47 -0400 (EDT) From: Thomas Monjalon To: Anand Rawat Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Tue, 02 Apr 2019 21:56:46 +0200 Message-ID: <2058052.CBssHhMYLK@xps> In-Reply-To: <20190402035458.14664-4-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-4-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402195646.bf03pmiYadIn_p4vBOpeYhRFhjMUYngm_KTly3UeIfs@z> 02/04/2019 05:54, Anand Rawat: > Added rte_os.h files to support OS specific functionality. > Updated build system to contain OS headers in the include > path. > > Signed-off-by: Anand Rawat > Reviewed-by: Pallavi Kadam > --- > --- a/meson.build > +++ b/meson.build > -global_inc = include_directories('.', 'config', 'lib/librte_eal/common/include') > +global_inc = include_directories('.', 'config', > + 'lib/librte_eal/common/include', > + 'lib/librte_eal/@0@/eal/include'.format(host_machine.system())) After having worked on rte_kni_common.h which is only in Linux, I think we should add rte_os.h in meson file of each OS: - lib/librte_eal/linux/eal/meson.build - lib/librte_eal/freebsd/eal/meson.build - lib/librte_eal/windows/eal/meson.build