From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 7F8B0C418 for ; Fri, 24 Jul 2015 11:25:43 +0200 (CEST) Received: by wibud3 with SMTP id ud3so19434257wib.0 for ; Fri, 24 Jul 2015 02:25:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=V+nXz7rC4At2OtxF0CDwfVp0qH9pkt3iT9fpfJocLXU=; b=ikxEEibHL/HwFWuGwBRM57BEDBZVxDylckW+XSrfOGO5bfE1Gell+v0Mo6uSKnlqRU ePw29+nkntqSMY+5HV80KloISVhtFXrlKp+8nZzxSszI/lVDHPqj/Q95BQIXcANn+qVT UzClIFFpa8gVYIctCbBz5V9n4ernRIVF6vBDXCSW70zPtXrG4+Ztzjl67lfzbjiIQFuW MJOX0JZpxpPcFWIhcoL8xtc5qLM1aq2RIHygBHxaDpV3SDlmvo8PfenUPZQldIZuz1ea AcwDt/PpxZU6iDOZDLot/wduUu+p9OCWr1iqo+eeUmLa6wj+dzNvvOpTH7IgFA1vtUBQ 0PAQ== X-Gm-Message-State: ALoCoQn7PJXY3dACMRxyJ869GtesK0POV7SH0IjxVfbJaWS1OIH0SEENZTj43/Vu+0M+xw6oBdbJ X-Received: by 10.180.108.239 with SMTP id hn15mr5297432wib.40.1437729943275; Fri, 24 Jul 2015 02:25:43 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ny7sm2544485wic.11.2015.07.24.02.25.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jul 2015 02:25:42 -0700 (PDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Date: Fri, 24 Jul 2015 11:24:28 +0200 Message-ID: <2058063.jaPb6Gx79p@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836A671DF@irsmsx105.ger.corp.intel.com> References: <1437589735-30041-1-git-send-email-konstantin.ananyev@intel.com> <1781257.Eo9CaUGVAh@xps13> <2601191342CEEE43887BDE71AB97725836A671DF@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2015 09:25:43 -0000 2015-07-24 09:15, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-07-22 19:28, Konstantin Ananyev: > > > +struct rte_eth_rxq_info { > > > + struct rte_mempool *mp; /**< mempool used by that queue. */ > > > + struct rte_eth_rxconf conf; /**< queue config parameters. */ > > > + uint8_t scattered_rx; /**< scattered packets RX supported. */ > > > + uint16_t nb_desc; /**< configured number of RXDs. */ > > > > Shouldn't we move nb_desc in rte_eth_rxconf? > > So rte_eth_rx_queue_setup() would have less parameters. > > I thought about that too, but it seems more drawbacks then pluses with that idea: > 1. Right now it is possible to call rte_eth_rx_queue_setup(..., rx_conf=NULL, ...); > In that case rte_eth_rx_queue_setup()will use default for that device rx_conf. > If we'll move mempool into rxconf, will break that ability. > 2. A bit unclear what mempool should be returned as default_rxconf by rte_eth_dev_info_get(). > Should it be just NULL. I was only suggesting to move nb_desc, not mempool. In case rx_conf==NULL, the nb_desc should be the max allowed by the driver. By the way, we should allow nb_desc==0 as it is done in virtio. Users shouldn't have to care about queue parameters (including nb_desc) for a basic usage. > 3. ABI breakage and we (and all customers) will need to modify each and every RX setup/configure code. > > For me it just seems like too much hassle, without any clear advanatage. The advantage is to have a cleaner API. Seems important to me.