From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2518CA0577; Wed, 15 Apr 2020 09:08:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93CED1C11E; Wed, 15 Apr 2020 09:08:19 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id F29541C114 for ; Wed, 15 Apr 2020 09:08:17 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200415070817euoutp01d6de87362879b4f23177486d336c53f2~F7IRoqcWF3252032520euoutp01I for ; Wed, 15 Apr 2020 07:08:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200415070817euoutp01d6de87362879b4f23177486d336c53f2~F7IRoqcWF3252032520euoutp01I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1586934497; bh=+hJn01B8Iw9LxqZ+OKxyLNE0dqgDV+2ZeDkfUTlPe5A=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=UNqVqaQkWxyJ1Ah8bzfc3/pLNK/SB50lgVi6jTabJwPsSDlvV9BUxfVb9SeDS7P9W G/0cr2j8BAMcF43KkUDm9L7tRS2tNGxoi5XfKXD8yxhO3JfgzMYAnbCNWW7FjrvhqP SO+hg7ASKyJ5t5bYLqt0G+LuVmYOC2/wosabem74= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200415070816eucas1p2dbbd3748c863491e40275d1434c28089~F7IRZ4Zz41898918989eucas1p23; Wed, 15 Apr 2020 07:08:16 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 9E.61.60698.0E2B69E5; Wed, 15 Apr 2020 08:08:16 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200415070816eucas1p12db94c9e4b69825c78f373aade8e65d4~F7IRIZx4i0633306333eucas1p1z; Wed, 15 Apr 2020 07:08:16 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200415070816eusmtrp28c87ecc31673b248cd70a7748fc7b28b~F7IRH6uPB2933529335eusmtrp2h; Wed, 15 Apr 2020 07:08:16 +0000 (GMT) X-AuditID: cbfec7f5-a0fff7000001ed1a-63-5e96b2e02237 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 82.54.08375.0E2B69E5; Wed, 15 Apr 2020 08:08:16 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200415070816eusmtip1e3f446205e1347b24514eaccaab3040c~F7IQvRJVI0664706647eusmtip1R; Wed, 15 Apr 2020 07:08:16 +0000 (GMT) To: Sarosh Arif Cc: dev@dpdk.org From: Lukasz Wojciechowski Message-ID: <205ece94-f6be-f4d9-0d6d-4c87e15dbb76@partner.samsung.com> Date: Wed, 15 Apr 2020 09:08:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA1WSe0iTYRTGe/ft8m02/ZwTjxdSR6UJqWEXoQsGXSwiFkRR4GXlxzSdym61 oLAyCbvifXOWlzJLdCI1y8ylhqZzhdhFa2jmigpNKS3mTNv2bWD//d7nPOc9z4GDY7xhRgCe liknpZmiDAGTQ9d3W1+u/dhckhitO78h9sfPFlpsX+MfVhwtfq7yDiPeaLVgQtpRzpYUMiNN SUqjtiVzUut0Bkb29Fd0yvThGZaDevtRPmLjQKyHqoZ7dAfziDoE6sawfMSx8wyCxr9GGlX4 hcA8JnQ3TA7kMCnTXQQVuj7XYxKB7tpNlsPlQ4jhSVmXk/lEONTaCpkOxggCxke+MBzMJLbC c/Wsk7nELpjvNzuZTqwCc+F7ezwc9yUSoPTtQcriDb1qizMpmzgAreVtGPXlITCqy+gU82Ho Uy5y5AHiOgsGpx+wqNQ74KlmgE6xD3zvcetBsPj4Fo1q0CN4Y7O6ug0I3l2tc7k2Q9eCjUnx dhixaGiOdEB4wtCkNzXZEwr0pRglc+FSHo9yR8LnK8XIPWu+weLKEA8vhrsYN1CoZslumiX7 aJbsQ3EwXHhYjmnsEzBiDehaoyj5BBiGJzCKw+GitoL1v93BfmB4nefiUCi6PObyhEFf222s EnncR36kQiYRk7KYTPJkpEwkkSkyxZHHsyTNyH5wxoWe2Ueoff5YJyJwJFjODdEVJ/IYIqVM JelEgGMCPlcnsUvcFJHqNCnNSpIqMkhZJwrE6QI/bkz1twQeIRbJyXSSzCal7ioNZwfkIK/f BapxyVBHZ1FJutDPVJ1Ve04p5EcXBQqqbOy5tMNxo6Z9/fVWc9J+tVyr7dg4ILCGRFwWm6y5 ZaqmOXlN18gyUXC5cs/q7LDgnaPSdoWvvuYIf4LclN98xr+eXu+hNa6I92+qNkxxS4PODtZ5 di/u9QqYWWhpS979Sr5ySkCXpYrWRWBSmegfWKju+mwDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsVy+t/xu7oPNk2LM5h1Qtni3aftTBan1n1n d2Dy+LVgKavH6Z9PmAOYovRsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1s UlJzMstSi/TtEvQy3v44w1LwMrTiw9+7TA2MJ227GDk5JARMJN5ebGDrYuTiEBJYyijx6tBT 9i5GDqCEjMSHSwIQNcISf651QdW8ZpQ49m0FO0hCWCBd4tPrL2wgtoiAhsSy35PBbGYBAYnH 956xgthCAoeZJM6cDQex2QRsJY7M/AoW5xVwk/hz5g6YzSKgKnFn8i1GkL2iArESLRc1IUoE JU7OfMICYnMKBErsmr2HGWJ8mETDzjZWCFtE4sajFsYJjIKzkLTMQlI2C0kZhG0mMW/zQ2YI W16ieetsIJsDyFaTWNaqhCy8gJF9FaNIamlxbnpusaFecWJucWleul5yfu4mRmBEbTv2c/MO xksbgw8xCnAwKvHwnlgzNU6INbGsuDL3EKMEB7OSCO/6XKAQb0piZVVqUX58UWlOavEhRlOg lycyS4km5wOjPa8k3tDU0NzC0tDc2NzYzEJJnLdD4GCMkEB6YklqdmpqQWoRTB8TB6dUA2Pa frPL8U8nsC/rzzWfyztj0sXoTS/D2by+lv5JLf4a9/vrz9p/Roc/bV2YI+e4vNpQV3npjYRd 3gmh61dvZI7Pd+lcr2yRJPWBS6ZZ/SJX6WWZ73vTbim4ctgpHGr490jun/GtZYtXtx7KnOnS 7Sr2YoXt0eu8XSKOluG/0u4o7r7XedBrl6QSS3FGoqEWc1FxIgBuvM0bvgIAAA== X-CMS-MailID: 20200415070816eucas1p12db94c9e4b69825c78f373aade8e65d4 X-Msg-Generator: CA X-RootMTR: 20200415064629eucas1p1044d7741876d821ccb71d5dc4f472241 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200415064629eucas1p1044d7741876d821ccb71d5dc4f472241 References: <20200413091906.782-1-sarosh.arif@emumba.com> <20200415064238.24012-1-sarosh.arif@emumba.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] app/test/test_distributor.c: prevent memory leakages from the pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 15.04.2020 o 09:06, Sarosh Arif pisze: > Yes, I plan to work on them when I get time. Great, please add me to CC. I would be glad to review it. > > On Wed, Apr 15, 2020 at 11:52 AM Lukasz Wojciechowski > > wrote: > > > W dniu 15.04.2020 o 08:42, Sarosh Arif pisze: > > v2: > > remove double freeing of mbufs > > > > Signed-off-by: Sarosh Arif > > > --- > >   app/test/test_distributor.c | 9 +++++++ > >   1 file changed, 7 insertions(+) > > > > diff --git a/app/test/test_distributor.c > b/app/test/test_distributor.c > > index ba1f81cf8..5e972bb2e 100644 > > --- a/app/test/test_distributor.c > > +++ b/app/test/test_distributor.c > > @@ -128,6 +128,7 @@ sanity_test(struct worker_params *wp, struct > rte_mempool *p) > >               printf("Line %d: Error, not all packets flushed. " > >                               "Expected %u, got %u\n", > >                               __LINE__, BURST, > total_packet_count()); > > +             rte_mempool_put_bulk(p, (void *)bufs, BURST); > >               return -1; > >       } > > > > @@ -153,6 +154,7 @@ sanity_test(struct worker_params *wp, struct > rte_mempool *p) > >                       printf("Line %d: Error, not all packets > flushed. " > >                                       "Expected %u, got %u\n", > >                                       __LINE__, BURST, > total_packet_count()); > > +                     rte_mempool_put_bulk(p, (void *)bufs, BURST); > >                       return -1; > >               } > > > > @@ -179,6 +181,7 @@ sanity_test(struct worker_params *wp, struct > rte_mempool *p) > >               printf("Line %d: Error, not all packets flushed. " > >                               "Expected %u, got %u\n", > >                               __LINE__, BURST, > total_packet_count()); > > +             rte_mempool_put_bulk(p, (void *)bufs, BURST); > >               return -1; > >       } > > > > @@ -233,6 +236,7 @@ sanity_test(struct worker_params *wp, struct > rte_mempool *p) > >       if (num_returned != BIG_BATCH) { > >               printf("line %d: Missing packets, expected %d\n", > >                               __LINE__, num_returned); > > +             rte_mempool_put_bulk(p, (void *)many_bufs, BIG_BATCH); > >               return -1; > >       } > > > > @@ -247,6 +251,7 @@ sanity_test(struct worker_params *wp, struct > rte_mempool *p) > > > >               if (j == BIG_BATCH) { > >                       printf("Error: could not find source > packet #%u\n", i); > > +                     rte_mempool_put_bulk(p, (void *)many_bufs, > BIG_BATCH); > >                       return -1; > >               } > >       } > > > > 2.17.1 > > > The sanity_test is ok now and does not have any mempool leaks. > > What about other tests in this file: Do you plan to work on them also? > > -- > > Lukasz Wojciechowski > Principal Software Engineer > > Samsung R&D Institute Poland > Samsung Electronics > Office +48 22 377 88 25 > l.wojciechow@partner.samsung.com > > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com