From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7C08F2B82 for ; Sun, 31 Mar 2019 17:52:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E899C20E69; Sun, 31 Mar 2019 11:52:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 31 Mar 2019 11:52:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1t1/C3wdD+QByI7xGg6BVZq99jeQ2D7DCr01/FxZT0Y=; b=jRvNO4qWvwjl asI4iQ6cAjS07D8s39wfA6TLTNLEvBpDhPbrelzUJ7sqVjINximI+yGS4QGBorW1 qSV2XbTiSLw3nQN8fKB37H5ncQomy2KixWSgKxH+ILHvPFH86R+gsZ214nitYoNB Y+pPKhZPWnrG2bUq1CM5h1eQms0v1xg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1t1/C3wdD+QByI7xGg6BVZq99jeQ2D7DCr01/FxZT 0Y=; b=jHmsDUiXuVt/vwu3uxuz823gNm+flcHMuM0QO57Aguh7LgMKDkqxi9mIY hjtaltpXlTw5jZI3rvBHQ0USD1nGEONntlH2/PWp5rM2JAEVWtK+FDwl7XjdYSlf Vz83hbUdNEkZkiN8I8TIWPUhiQrSytvEknV/ClIpggA+CPvkOppGTaj5n6/8fqc8 ykot3egCQnY2sJz9CIoePESlag8VZSL6/NKQ0XoywAKOUzegqUwH12iH9gBwZaCz dlH9uXftzn1lf/gM4jqaR9YCrhHmbgI2FlNV2aM97oWmZwMh4Yww+YNS0EkPmEA0 GZ369ohb8lBAr4O/CgTTDHEOshsjA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrledvgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 917CDE46B8; Sun, 31 Mar 2019 11:52:17 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Wenzhuo Lu , Qi Zhang Cc: dev@dpdk.org, cathal.ohare@intel.com, john.mcnamara@intel.com Date: Sun, 31 Mar 2019 17:52:15 +0200 Message-ID: <2061322.Qldrv329ue@xps> In-Reply-To: <079356fb-7de6-b091-3266-56e04b05b2e8@intel.com> References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com> <1553581011-94181-1-git-send-email-wenzhuo.lu@intel.com> <079356fb-7de6-b091-3266-56e04b05b2e8@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Mar 2019 15:52:19 -0000 26/03/2019 10:50, Ferruh Yigit: > > Wenzhuo Lu (8): > > net/ice: fix Tx function setting > > net/ice: add pointer for queue buffer release > > net/ice: support vector SSE in RX > > net/ice: support Rx scatter SSE vector > > net/ice: support Tx SSE vector > > net/ice: support Rx AVX2 vector > > net/ice: support Rx scatter AVX2 vector > > net/ice: support vector AVX2 in TX > > This version (v7) pulled from next-net-intel to next-net. I assume these patches have been tested, or at least compiled. However, when running devtools/test-meson-builds.sh, there is a compilation error for build-x86-default: In file included from ../drivers/net/ice/ice_ethdev.h:10: rte_ethdev_pci.h:38:10: fatal error: 'rte_pci.h' file not found It can be fixed in net/ice: support Rx AVX2 vector by adding static_rte_pci and static_rte_bus_pci to the dependencies. I fixed it even better in net/ice: support vector SSE in Rx by replacing the useless include of rte_ethdev_pci.h in ice_ethdev.h with rte_ethdev_driver.h. I could just reject the next-net tree, but I don't really have such option if we want to close 19.05-rc1 quickly. In summary, I am spending my Sunday hours to fix the mess in your driver which was supposed to be tested before submitting, plus before merge in next-net-intel, plus compilation-tested before pull in next-net. I don't know what failed in the process, but I really don't like it. I don't want to see any new patch for ice PMD in 19.05 cycle. If you really need some fixes in 19.05 (very likely given the mass code drop you are doing few days before the -rc1 deadline), then I advise you to double check everything and make commits fully justified and explained. Sorry for the bad mood, and I hope it won't happen again soon. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8A009A00B9 for ; Sun, 31 Mar 2019 17:52:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80B092B9A; Sun, 31 Mar 2019 17:52:20 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7C08F2B82 for ; Sun, 31 Mar 2019 17:52:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E899C20E69; Sun, 31 Mar 2019 11:52:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 31 Mar 2019 11:52:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1t1/C3wdD+QByI7xGg6BVZq99jeQ2D7DCr01/FxZT0Y=; b=jRvNO4qWvwjl asI4iQ6cAjS07D8s39wfA6TLTNLEvBpDhPbrelzUJ7sqVjINximI+yGS4QGBorW1 qSV2XbTiSLw3nQN8fKB37H5ncQomy2KixWSgKxH+ILHvPFH86R+gsZ214nitYoNB Y+pPKhZPWnrG2bUq1CM5h1eQms0v1xg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1t1/C3wdD+QByI7xGg6BVZq99jeQ2D7DCr01/FxZT 0Y=; b=jHmsDUiXuVt/vwu3uxuz823gNm+flcHMuM0QO57Aguh7LgMKDkqxi9mIY hjtaltpXlTw5jZI3rvBHQ0USD1nGEONntlH2/PWp5rM2JAEVWtK+FDwl7XjdYSlf Vz83hbUdNEkZkiN8I8TIWPUhiQrSytvEknV/ClIpggA+CPvkOppGTaj5n6/8fqc8 ykot3egCQnY2sJz9CIoePESlag8VZSL6/NKQ0XoywAKOUzegqUwH12iH9gBwZaCz dlH9uXftzn1lf/gM4jqaR9YCrhHmbgI2FlNV2aM97oWmZwMh4Yww+YNS0EkPmEA0 GZ369ohb8lBAr4O/CgTTDHEOshsjA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrledvgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 917CDE46B8; Sun, 31 Mar 2019 11:52:17 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Wenzhuo Lu , Qi Zhang Cc: dev@dpdk.org, cathal.ohare@intel.com, john.mcnamara@intel.com Date: Sun, 31 Mar 2019 17:52:15 +0200 Message-ID: <2061322.Qldrv329ue@xps> In-Reply-To: <079356fb-7de6-b091-3266-56e04b05b2e8@intel.com> References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com> <1553581011-94181-1-git-send-email-wenzhuo.lu@intel.com> <079356fb-7de6-b091-3266-56e04b05b2e8@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190331155215.Xk2hK7UaYHcOc8MXEwv79aeX8PRN_-HBtCOwNBpoIhw@z> 26/03/2019 10:50, Ferruh Yigit: > > Wenzhuo Lu (8): > > net/ice: fix Tx function setting > > net/ice: add pointer for queue buffer release > > net/ice: support vector SSE in RX > > net/ice: support Rx scatter SSE vector > > net/ice: support Tx SSE vector > > net/ice: support Rx AVX2 vector > > net/ice: support Rx scatter AVX2 vector > > net/ice: support vector AVX2 in TX > > This version (v7) pulled from next-net-intel to next-net. I assume these patches have been tested, or at least compiled. However, when running devtools/test-meson-builds.sh, there is a compilation error for build-x86-default: In file included from ../drivers/net/ice/ice_ethdev.h:10: rte_ethdev_pci.h:38:10: fatal error: 'rte_pci.h' file not found It can be fixed in net/ice: support Rx AVX2 vector by adding static_rte_pci and static_rte_bus_pci to the dependencies. I fixed it even better in net/ice: support vector SSE in Rx by replacing the useless include of rte_ethdev_pci.h in ice_ethdev.h with rte_ethdev_driver.h. I could just reject the next-net tree, but I don't really have such option if we want to close 19.05-rc1 quickly. In summary, I am spending my Sunday hours to fix the mess in your driver which was supposed to be tested before submitting, plus before merge in next-net-intel, plus compilation-tested before pull in next-net. I don't know what failed in the process, but I really don't like it. I don't want to see any new patch for ice PMD in 19.05 cycle. If you really need some fixes in 19.05 (very likely given the mass code drop you are doing few days before the -rc1 deadline), then I advise you to double check everything and make commits fully justified and explained. Sorry for the bad mood, and I hope it won't happen again soon.