From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id E679CAE9A
 for <dev@dpdk.org>; Wed,  2 Jul 2014 12:04:54 +0200 (CEST)
Received: by mail-wg0-f43.google.com with SMTP id b13so488151wgh.2
 for <dev@dpdk.org>; Wed, 02 Jul 2014 03:05:15 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=ipHykiEgr98ERF8kHrZ9hRGsVRcPf87hdBFFJPZyexQ=;
 b=gveLzXe2eD/gORAREyNmce6UKgU5qGnx+ooTgfCLdiuFuAlLeVcZ/B0kN5oZ/5WNNZ
 OziYpzM36yiNmfM9nOIpmEMQU1FmYC6goiZiUS8rG5nldMMop6XNDdSyMyCY6fO+T4rd
 ue82Jjf/kXlPka8XmitkzodqWl5cENyHwQ26PfZvahkrC9yZZgCQ0uSdjL3GUyInypKU
 EJTnKQycouqmcRkNOoaaLmwLekP9lKqsB6OrHFvwAZiw/pBC4g3zXV0AvuTXEBbPtPVM
 DHlQvyMPejIbRFHIc6JqsRSFFNQnJj+oijIZxqGoXVeVQTZ6vy2zGmhu2e56E1oPZERQ
 MkGw==
X-Gm-Message-State: ALoCoQnKwAv28Qp0uzZst3Y/WaBuHrQlhOOBTQp+C8cRiSaVE9aAFWaeVLNyYF6EfVYllJU/uXwL
X-Received: by 10.194.87.134 with SMTP id ay6mr22316135wjb.84.1404295514900;
 Wed, 02 Jul 2014 03:05:14 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id lk7sm54063602wjb.24.2014.07.02.03.05.13
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 02 Jul 2014 03:05:14 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhan, Zhaochen" <zhaochen.zhan@intel.com>
Date: Wed, 02 Jul 2014 12:05:08 +0200
Message-ID: <2062090.RJjRv0m9u1@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <6D0EE020084B194084D70B0A8D2207B8E8EA6B@SHSMSX104.ccr.corp.intel.com>
References: <AA3F441F262C58498CD6D0C1801DE7EB0AABC6D0@SHSMSX103.ccr.corp.intel.com>
 <1404292944-5964-1-git-send-email-thomas.monjalon@6wind.com>
 <6D0EE020084B194084D70B0A8D2207B8E8EA6B@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fix build for bsd
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jul 2014 10:04:55 -0000

Hi Zhaochen,

Please read answer below:

2014-07-02 09:58, Zhan, Zhaochen:
> I have tested the patch, it still has a build error although it is different
> from the previous one.
> 
> OS: FreeBSD10
> 
> == Build lib/librte_pmd_bond
>   CC rte_eth_bond_api.o
> /root/zzc/dpdk-1.7.0-rc3/lib/librte_pmd_bond/rte_eth_bond_api.c:35:27: fatal
> error: linux/binfmts.h: No such file or directory #include
> <linux/binfmts.h>

Please check with the latest version in master branch (after rc3).
It should be fixed by Helin's patch of today.

Thanks
-- 
Thomas


> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Wednesday, July 02, 2014 5:22 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] eal: fix build for bsd
> > 
> > When adding link bonding to EAL initialization (a155d430119),
> > an include was missing for BSD.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> > 
> >  lib/librte_eal/bsdapp/eal/eal.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > Please, a quick test and acknowledgement of this fix would be helpful.
> > 
> > 
> > diff --git a/lib/librte_eal/bsdapp/eal/eal.c
> > b/lib/librte_eal/bsdapp/eal/eal.c index ec57b26..69ead31 100644
> > --- a/lib/librte_eal/bsdapp/eal/eal.c
> > +++ b/lib/librte_eal/bsdapp/eal/eal.c
> > @@ -66,6 +66,7 @@
> > 
> >  #include <rte_cpuflags.h>
> >  #include <rte_interrupts.h>
> >  #include <rte_pci.h>
> > 
> > +#include <rte_dev.h>
> > 
> >  #include <rte_devargs.h>
> >  #include <rte_common.h>
> >  #include <rte_version.h>
> > 
> > --
> > 2.0.0