From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 2FDAD292D; Mon, 25 Feb 2019 16:00:04 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 99EFA24383; Mon, 25 Feb 2019 10:00:03 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 25 Feb 2019 10:00:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=zaSa9xfQ9mZmDXm5q8gzgdOOusglHN2t5ZXUS7Uxk1E=; b=kL5WH3Wc72Wd aDYLl7qJo5+vgrd4E6xciYdEJSnK/1a0z6kamNAH5cMV7miOsuIULhER0GJHRHI9 tA87kNfFayvt2kgMNiW5L/mi8tom53V/iVBdLtexjdFeYf4H9sSrNhB5KEINT/Cz b0TcWCGz277LdrbaN2A3TEBlLkVZXFY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=zaSa9xfQ9mZmDXm5q8gzgdOOusglHN2t5ZXUS7Uxk 1E=; b=j3bwbqxmZuHzer6mTF0239HbzLIqtNTwUXIQrAHcCwS78/S65zQv3tTAR MryL8uZv+w8qZiNGrfpute7SkbUXt2eERxYUxABPI1Qtkm21/yIlG+ysfyRsvqlP TE30mNgHRr5qcG6PEg8IHBgYKdJiTF6jFaJ2w4XyX/wTEA1G3Wz1OqKOe/9KoP9b eucsh+Evh9nexdoHZ2ihzI3mWA0PHzZZrwgQaHrCqgJah41NO3pdGLO3rM3YMISh tmqmuHgaxYfbEyuUM0JdSZrVnqlRkWHDrY/H9mDeUttaHAc4iFpaa+WYxd4m3yk7 K/M177qJkrrZDnNoOkcSOxGPJlUOw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrudejgdejgeculddtuddrgedtledrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8FD9610343; Mon, 25 Feb 2019 10:00:00 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Neil Horman , David Marchand , Anatoly Burakov Date: Mon, 25 Feb 2019 15:59:57 +0100 Message-ID: <2063813.xZsQsPevWC@xps> In-Reply-To: <20190206110130.55135-1-bruce.richardson@intel.com> References: <20190110111104.56464-1-bruce.richardson@intel.com> <20190206110130.55135-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] compat: merge compat library into EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 15:00:04 -0000 06/02/2019 12:01, Bruce Richardson: > Since compat library is only a single header, we can easily move it into > the EAL common headers instead of tracking it separately. The downside of > this is that it becomes a little more difficult to have any libs that are > built before EAL depend on it. Thankfully, this is not a major problem as > the only library which uses rte_compat.h and is built before EAL (kvargs) > already has the path to the compat.h header file explicitly called out as > an include path. > > However, to ensure that we don't hit problems later with this, we can add > EAL common headers folder to the global include list in the meson build > which means that all common headers can be safely used by all libraries, no > matter what their build order. > > As a side-effect, this patch also fixes an issue with building on BSD using > meson, due to compat lib no longer needing to be listed as a dependency. > > Fixes: a8499f65a1d1 ("log: add missing experimental tag") > > CC: stable@dpdk.org > CC: Neil Horman > Signed-off-by: Bruce Richardson > Reviewed-by: David Marchand > Tested-by: David Marchand > Tested-by: Anatoly Burakov Applied, thanks