From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D890BA0542; Wed, 5 Oct 2022 14:34:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8209040694; Wed, 5 Oct 2022 14:34:45 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 3F55840143 for ; Wed, 5 Oct 2022 14:34:44 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B95DB320094D; Wed, 5 Oct 2022 08:34:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 05 Oct 2022 08:34:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1664973282; x= 1665059682; bh=cwYl1rKhtiI4/Xma7t1QArz5ut08KHcY0xwbxggm0/8=; b=Y hpl8c43SNaWHBK3M/dA89MpUNc4L8umino3z54N4kqMZKkAzI8dX0GVPmcj4dVsd KgDDgCo6HJg7NbN8v2AI5b+tpWIfECtEX5D8m4/9W9yMgqQ0U7na02R0t4vcGZeh 12R7dAu+YYpufNIvR6Peth6IsQbogE8wg9Kmp7E86v0U1gTr7WsKFKjoLVq2fG5A xq0L1kcF1NB8EEsQWOYP6fYMBs7M1t+Xs9zg4mN4mHtSbfq8M9QtM7DVP+xeaN8F 1X4cWSULzpPneHCr9rpARfColYkx87o4Wmoxwrm+ggE/CH6/+/9QaCwykEyH09cG j+ggQt6xvxyFGC6pD5EYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664973282; x= 1665059682; bh=cwYl1rKhtiI4/Xma7t1QArz5ut08KHcY0xwbxggm0/8=; b=K /tiB/7AWu9zySpni3ShalfPtp9FFwISGQ2IA8T60oIZWwfm0wGIqDMQ6Pu1VczBt 7L2o2seqg6DvI0A936iXkV2euFtGj96HIJyRC1rYK5AvXugiuhTnkY5LczKSsrgV nkP32DZvJ5VS4TvSZoH5+no2Ve82505xk6lJGvYcjSESZzYc5AK/avzY2qHZO7n0 UvLP+C32GVJB3KV8ofIaIZfJ3MeC6ppwaFOchogZU1hfTNNc2TPovV4jL3iACMLs 2QNlPZkpJMhqBylM92mzS6TC1grpZ+Jou9Iu/LB+YahIVl0zyAU8ypi6IDDc65ld T9esusO+SSmG8Jsz87DUg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeifedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Oct 2022 08:34:41 -0400 (EDT) From: Thomas Monjalon To: Harshad Narayane Cc: dev@dpdk.org, Kamalakannan R , Cristian Dumitrescu Subject: Re: [PATCH] examples/pipeline: fix file close Date: Wed, 05 Oct 2022 14:34:40 +0200 Message-ID: <2064490.htQpZWrp2x@thomas> In-Reply-To: <20220927043516.366922-1-harshad.suresh.narayane@intel.com> References: <20220927043516.366922-1-harshad.suresh.narayane@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/09/2022 06:35, Harshad Narayane: > Coverity issue: 380860 > Fixes: 9043f66a ("examples/pipeline: add command for code generation") > > Fix file close at pipeline code generation. > > Signed-off-by: Harshad Narayane > Signed-off-by: Kamalakannan R > Acked-by: Cristian Dumitrescu > --- > --- a/examples/pipeline/cli.c > +++ b/examples/pipeline/cli.c > @@ -545,6 +545,7 @@ cmd_pipeline_codegen(char **tokens, > code_file = fopen(tokens[3], "w"); > if (!code_file) { > snprintf(out, out_size, "Cannot open file %s.\n", tokens[3]); > + fclose(spec_file); > return; > } Reordered lines in the commit log and applied, thanks. Note: this is not fixing "close", it was missing, but it is fixing a leak.