From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id A2AF4B0A7 for ; Wed, 11 Jun 2014 00:44:37 +0200 (CEST) Received: by mail-wi0-f178.google.com with SMTP id n15so92800wiw.11 for ; Tue, 10 Jun 2014 15:44:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=g9kagoBXbIoT1pxicLUl508P/8CqKKQzJSfkRhRwY+k=; b=eh0jK1WgGoGLmFB/X137Rx8bvIWevY/pUAXybFHkEye0y9SzJEaMbwU3dqijRj6w2e /boHaNXuCQZEYEm0l3gb3xxrLNaUsVGpGzJQsiAV0dk20UuUmpEfA6TNtOEe4hDYOWpo sqWt0WiOxQns4+G/d4rUciq6nFTGqUYvd7z02bHBj+xipF0eInItd/E6kWzQ8GRNVy9y Kbd3gNPDfc+nFURgMishpEWRckEe0dbUsow+NzehYdl17wYdKVjIImQhg+pZuJbQa9Ka u7T2GaBCw41pWPbUCKN7ROwhh7KH1Kuzc5SRinKFMVBk5Kb17Jvyl1S8WAxa0EU/reWY MWIw== X-Gm-Message-State: ALoCoQkwGt92gQSFC7/Z5iUMMklnsLmR0bvhozga32xH1Ctb6jMGaP3dMkpIl2HDawmKynr6fLD7 X-Received: by 10.180.108.51 with SMTP id hh19mr33286801wib.25.1402440291952; Tue, 10 Jun 2014 15:44:51 -0700 (PDT) Received: from xps13.localnet (ip-96.net-80-236-123.rev.numericable.fr. [80.236.123.96]) by mx.google.com with ESMTPSA id je7sm23423576wic.14.2014.06.10.15.44.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jun 2014 15:44:51 -0700 (PDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Date: Wed, 11 Jun 2014 00:44:51 +0200 Message-ID: <2066022.Iqp5aeoHOS@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.4-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB9772580EFB3529@IRSMSX105.ger.corp.intel.com> References: <2601191342CEEE43887BDE71AB9772580EFB3529@IRSMSX105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/2] L3FWD sample optimisation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2014 22:44:37 -0000 Hi Konstantin, 2014-05-28 09:17, Ananyev, Konstantin: > Hi Thomas, > > >As you are doing optimizations, it's important to know the performance gain. > >It could help to mitigate future reworks. > >So please, could you provide some benchmarking numbers in the commit log? > > Some performance data below. > Also, forgot to mention that new code path can be switched on/off by setting > ENABLE_MULTI_BUFFER_OPTIMIZE macro to 1/0. > Do I need to resubmit the whole patch series, or just a cover letter, or ...? I think you should resubmit the whole serie after having checked it with checkpatch.pl. Please keep Acked-by and Tested-by lines from previous mails. Thanks -- Thomas