From: Thomas Monjalon <thomas@monjalon.net>
To: Dan Gora <dg@adax.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] kni: fix build on Centos 7.4 when Ethtool enabled
Date: Tue, 22 May 2018 22:13:29 +0200 [thread overview]
Message-ID: <2066106.EVIWKkP5ao@xps> (raw)
In-Reply-To: <ec9f0e98-cb78-3e28-75d9-d15edc9c4e4f@intel.com>
22/05/2018 20:50, Ferruh Yigit:
> On 5/22/2018 7:10 PM, Dan Gora wrote:
> > Fix compilation errors on Centos 7.4 when CONFIG_RTE_KNI_KMOD_ETHTOOL
> > is set to 'y'.
> >
> > Centos 7.4 needs HAVE_NDO_BRIDGE_GETLINK_FILTER_MASK_VLAN_FILL:
> >
> > igb_main.c: In function ‘igb_ndo_bridge_getlink’:
> > igb_main.c:2289:2: error: too few arguments to function
> > ‘ndo_dflt_bridge_getlink’
> > return ndo_dflt_bridge_getlink(skb, pid, seq, dev, mode, 0, 0, nlflags);
> > ^
> >
> > Centos 7.4 needs HAVE_VF_VLAN_PROTO and needs to redefine
> > ndo_set_vf_vlan to .extended.ndo_set_vf_vlan:
> >
> > igb_main.c:2318:2: error: unknown field ‘ndo_set_vf_vlan’ specified
> > in initializer
> > .ndo_set_vf_vlan = igb_ndo_set_vf_vlan,
> > ^
> >
> > Signed-off-by: Dan Gora <dg@adax.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-05-22 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 18:10 Dan Gora
2018-05-22 18:50 ` Ferruh Yigit
2018-05-22 20:13 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2066106.EVIWKkP5ao@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dg@adax.com \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).