From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 295F92629 for ; Tue, 22 May 2018 22:13:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8765F21893; Tue, 22 May 2018 16:13:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 22 May 2018 16:13:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=5HT3UEI8gi17QbpP73pchXzdOE 2eLbCHKmR647izulc=; b=Vhi/tBD+9Um/C57axp/UErVD2XBLgbZV8NC5YKTD7x UflK4QFP5craimQ03hLXIxxjgaD9YDtphiiZaprVWarc3jWUQ/eV5teZ9pxxeh3x E9/uizbrZml2CZkkLcery5OK3JNRNgxWa9iGzrap4Z8yrYblv+sooUCGWkpMb1FM k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5HT3UE I8gi17QbpP73pchXzdOE2eLbCHKmR647izulc=; b=TZClkpLFBZkIGqGNX2f/w7 QFxgrPCSx1CWQIEpiEVGClhSwtFy16ht7uCSCZpDhlFroUr6pRefG3JPU8msGda0 TyLEfjEnIEpuwd3C1LD0XtCR+tbu6TiDrmAAwCOhDoFybOLIVYWB/iHOlb4KflwR EsluW+eJ1SdspMzK4b9XqPceuhdgoh9jcbjw9byOXrBBVKjbpn0o/Fl5YwhGjbz3 AbABiRXCJo+4jr+9EctlaE6ohMmMWJzFYwWtsCKpPZnAs4iN1WkgaVORZzlVcedh BuukwXPcFlkClsgy71EaPqaBPC8m8ZGgVhurPDmJ5oiHkZtcQynBwuAZJzJiXBZw == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D661EE465C; Tue, 22 May 2018 16:13:29 -0400 (EDT) From: Thomas Monjalon To: Dan Gora Cc: dev@dpdk.org, Ferruh Yigit Date: Tue, 22 May 2018 22:13:29 +0200 Message-ID: <2066106.EVIWKkP5ao@xps> In-Reply-To: References: <20180522181008.6327-1-dg@adax.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] kni: fix build on Centos 7.4 when Ethtool enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 20:13:31 -0000 22/05/2018 20:50, Ferruh Yigit: > On 5/22/2018 7:10 PM, Dan Gora wrote: > > Fix compilation errors on Centos 7.4 when CONFIG_RTE_KNI_KMOD_ETHTOOL > > is set to 'y'. > >=20 > > Centos 7.4 needs HAVE_NDO_BRIDGE_GETLINK_FILTER_MASK_VLAN_FILL: > >=20 > > igb_main.c: In function =E2=80=98igb_ndo_bridge_getlink=E2=80=99: > > igb_main.c:2289:2: error: too few arguments to function > > =E2=80=98ndo_dflt_bridge_getlink=E2=80=99 > > return ndo_dflt_bridge_getlink(skb, pid, seq, dev, mode, 0, 0, nlflag= s); > > ^ > >=20 > > Centos 7.4 needs HAVE_VF_VLAN_PROTO and needs to redefine > > ndo_set_vf_vlan to .extended.ndo_set_vf_vlan: > >=20 > > igb_main.c:2318:2: error: unknown field =E2=80=98ndo_set_vf_vlan=E2=80= =99 specified > > in initializer > > .ndo_set_vf_vlan =3D igb_ndo_set_vf_vlan, > > ^ > >=20 > > Signed-off-by: Dan Gora >=20 > Acked-by: Ferruh Yigit Applied, thanks