From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id C900E37B3 for ; Mon, 14 Dec 2015 13:46:10 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id p66so42216839wmp.0 for ; Mon, 14 Dec 2015 04:46:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Ai/DQf5ELuiiDSpoCqnakeUFv5ao4pWvyf33LboOIdE=; b=iCgAMhrWYkTryZgOYeNvKVA3BEsY1kMd/LnDKfqG0NjOAmJsAdcZyIHZ/fvGEOf7EK 2+innZgK4R/R25bdTb98Wx8HKq1Du4HWN0qF1EEDfnL9s178PbKFznaVKKlhzT1F+yHl QnfAi+BpxHHg6IOPLFChdWHJza1FRSG9RSGup0tJMHCUYHncu6xFWBFMwVwiQQk1EusI 5CykcrDyYTtgMOXQpmAf69cNGetSCe6Ld7sQG7nPw1FKqrbj5d6i/7cCqHyyDScwnB4z Ljj81anka7OQgXwnaRtyZJzoZfMrZIVb/rVFTya29XzjwIq7XJdDqFtwcLr8VQrCMm4F 4phQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Ai/DQf5ELuiiDSpoCqnakeUFv5ao4pWvyf33LboOIdE=; b=HqkikXA3fF/dQtuQinuy3gbnKTpjHTJcbwYWljgOfIBOYuA5LBh0yX2XhouPquRk9I dwNMkvlBIdpu6kfmWUXapa+FD2JhWxBzY6dzE8MkeApaJszjBjODBJhhyVStjo2BSHP3 iU5tZ+VcWngNvQJqvaQdWdr07f0vWdwQunzKO10995o8q9Rh0nEUZV0SdmLuAu9StR4V VYREL7zKbpOKzD/RvBpmmhuvwjmtfUd7qSowkTFkG+eXbJREqVQY4VtaW0idaU3Jmd7e 2D1qf+x0Xn4rAGcEMFQHgMSYZoA59E7WacZGeenVrgTqXR6qlhZRFi5FjnRBNoCZSPfr oYvQ== X-Gm-Message-State: ALoCoQmRo/UYMqCdtSMzHtDZ8QHEDCJXa8gvX/EB+FLiaeMmxfgdH1DD1WR99ESQ5sVqcyfXYOz+T71ndGoRg40fr/BVwEOOsA== X-Received: by 10.28.140.202 with SMTP id o193mr915177wmd.38.1450097170636; Mon, 14 Dec 2015 04:46:10 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id k125sm16007376wmf.2.2015.12.14.04.46.09 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Dec 2015 04:46:09 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu , "Xie, Huawei" Date: Mon, 14 Dec 2015 13:44:54 +0100 Message-ID: <2070148.TLndilS6eD@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151214114732.GB29571@yliu-dev.sh.intel.com> References: <1449763652-86292-1-git-send-email-huawei.xie@intel.com> <1485514.3e9eA57k0j@xps13> <20151214114732.GB29571@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] virtio: fix virtio_net_hdr desc pointing to the same buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2015 12:46:11 -0000 2015-12-14 19:47, Yuanhan Liu: > On Mon, Dec 14, 2015 at 10:32:24AM +0100, Thomas Monjalon wrote: > > 2015-12-14 11:01, Yuanhan Liu: > > > On Fri, Dec 11, 2015 at 12:07:32AM +0800, Huawei@dpdk.org wrote: > > > > The virtio_net_hdr desc all pointed to the same buffer. It doesn't cause > > > > issue because in the simple TX mode we don't use the header. This patch > > > > makes the header desc point to different buffer. > > > > > > > > Signed-off-by: Huawei Xie > > > > > > Acked-by: Yuanhan Liu > > > > Does it fix something in the current behaviour? > > It's more like a logic fixing to me. > > > I have the feeling it may wait for 2.3. > > It's been introduced in v2.2, with Huawei's simple tx patchset. > Therefore, I guess 2.2 is good to go? The vhost driver has been validated without with patch. Merging it would be taking the risk of breaking something (or just reduce performance) for no clear benefit. Am I missing something?