From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 56A2D8DB1 for <dev@dpdk.org>; Wed, 9 Dec 2015 23:51:16 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id u63so1402728wmu.0 for <dev@dpdk.org>; Wed, 09 Dec 2015 14:51:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=SketV9ug0RmH8THs9/iu7Pdd9dQmNHvW9u+RP+JxIE0=; b=154mfEtSJ+yanV/ffs8GezW92hnrMHMfdlXCUvSdrunlBZfpPmB0QI7idxFkDzWXXO aLUJYcDTdgT3hiicrXgsN0b5wiGoDkxTkH24/nS23QZPH+ajuMUElz3bBiymdKa0SsUr 76GzL893Y59iylWBlVNETD5FhV23cSyWPVNKWeV1RaU3fktkol+GIaT1VFtyKzd1/+z/ IyhHx0tqaGzowPhdc+hn8GoOOWQp+XiPa6KHW0voY4kDXa40TJt704ffnZinBqPT1X6n Bn+ItgEmiyWZEhXmb1GCvPOC04UK7Bxyfl27f/tGbFUEeGDonmhlDklXhWsr/53E/XsY jFcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=SketV9ug0RmH8THs9/iu7Pdd9dQmNHvW9u+RP+JxIE0=; b=TEkmQRLJy3Xm05isgBjRKH+6NNcI987QTKrP7Skyf6Ljb3g57m4ssJl8oeFcTKM2lm gqlVN/HtO5jf14ZlepVkCwuRKLW6Bkn/kqYKZ5WepEh9DrT6oG3bTz8Cy48UUWUwNik+ Dpw4uA5GK8prm6ZRAVersKVSfDLgAWvuLOBzv5nHTFq3FccCxVXfq5dptcaffzxGaspi dauuov8upTduRPjJfU4dEpRflNOOZinNsQAy4Tz6+o9atxefL+C2F2Fa8TGk1naGNBrd 364jtoAK/SnMItkn2G8ggqx68qqoG/ysCZoL9lyACqjD+TGEx/LEgvEt6jxAitjKy66x TnSg== X-Gm-Message-State: ALoCoQmb8p6IWS4Z7F/JMeUazI6UpLhlpgvo5O1dp2JpUQH1e0JjENYT/UE8fHY/kvuQ6i1P8w9SNQCYpxr2mhrC0Vh/wmdExg== X-Received: by 10.28.65.69 with SMTP id o66mr13352771wma.18.1449701476200; Wed, 09 Dec 2015 14:51:16 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id l128sm27857583wmf.10.2015.12.09.14.51.15 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Dec 2015 14:51:15 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Stephen Hemminger <stephen@networkplumber.org> Date: Wed, 09 Dec 2015 23:49:59 +0100 Message-ID: <2072515.rqoGFgxSIN@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151209135801.17965487@xeon-e3> References: <1449683756-13381-1-git-send-email-stephen@networkplumber.org> <2562631.e9AmeysRzG@xps13> <20151209135801.17965487@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Avi Kivity <avi@scylladb.com>, Alex Williamson <alex.williamson@redhat.com> Subject: Re: [dpdk-dev] [PATCH] vfio: support iommu group zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 09 Dec 2015 22:51:16 -0000 2015-12-09 13:58, Stephen Hemminger: > On Wed, 09 Dec 2015 22:12:33 +0100 > Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > > > 2015-12-09 09:55, Stephen Hemminger: > > > The current implementation of VFIO will not with the new no-IOMMU mode > > > in 4.4 kernel. The original code assumed that IOMMU group zero would > > > never be used. Group numbers are assigned starting at zero, and up > > > until now the group numbers came from the hardware which is likely > > > to use group 0 for system devices that are not used with DPDK. > > > > > > The fix is to allow 0 as a valid group and rearrange code > > > to split the return value from the group value. > > > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > > --- > > > Why was this ignored? It was originally sent on 26 Oct 15 back > > > when IOMMU discussion was lively. > > > > There was no review of this patch. > > The patch has been marked as deferred recently when it was too late > > to do such feature changes in DPDK code: > > http://dpdk.org/dev/patchwork/patch/8035/ > > This is why as a fallback the MAINTAINER has to review the patch > or direct a sub-maintainer to do it. I think almost 2 months is > plenty of time for review. 27 October was 3 days before the feature deadline. And you have not pinged about it since then. But that's true I have missed the importance of this patch. Would it help to have it integrated today? Are you sure it won't break something else?