From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id DCEC9A0C45;
Sun, 4 Jul 2021 21:45:22 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 670F240686;
Sun, 4 Jul 2021 21:45:22 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 0941240141
for <dev@dpdk.org>; Sun, 4 Jul 2021 21:45:21 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.nyi.internal (Postfix) with ESMTP id 9335F5C0045;
Sun, 4 Jul 2021 15:45:19 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute4.internal (MEProxy); Sun, 04 Jul 2021 15:45:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
fgYtUSXgCxpIKXzDEuZzhhfziQ12RK/zVVdJbW+QtC8=; b=LnwnS7iaYFmvFhu8
E2nv7Q2u5ZrbMQJw1fzgmKNSqfQA6dCO2KIp1CnTzgoclZIXuLjCiDYT6PtpWXHr
zsJzybOFt/Z0q377PtwkUkpjRXitYHAuvN+E06vYjRRXL3fUhmlxK/QChwtvPhKn
Mag6OCCUlPuUPDf1skz2l8PV5GbfjV9B2jylbmwTYyqanGmajqhgRwcS29hXdp1B
9xEP9++W+7JCKd8xpuUMldWcfBRhJtr6Ih0PQcPRLRcCks59wBKeJ08kh9figdjT
t8tjEENzfO1FBSm5U8hqAxPaiXI3U9JI9mvJpxUiTt6+/hy5Ksdr0bwtTaEJvR9D
bgo/Pg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=fgYtUSXgCxpIKXzDEuZzhhfziQ12RK/zVVdJbW+Qt
C8=; b=nou0aGju9SywVeNUW/opMJQszFpgvOIcrdWUdc9KREPCcjrT3Yyyd7BLC
lapoSq7Cdm4AB3ce9p0Dmisj5sXTU5XjhvfG4PMtFlTb8QQ3UGRGD+7Il3/r9Cpp
lsw4PEk2D/ijTQ/7/y+2LJ7YuFht/PbJkHqRHst3pKJc3/2N1ytGHm8wxGh++Rki
FvqBc3nKOzlupCLqfbbxHHsQqJE3h26yTxq/TQuPzZlpROR0W+xuWLcIgtyjaB9o
IHwRZiPjdkdnU6bbBaEoavFm9IxalWsG03ylwWJcOJi30P4iUEXBuLldazGIqld/
hwhBFsEuCz4xVNvdM/ZN9WN0EoM9A==
X-ME-Sender: <xms:zg_iYHEitoI86sA4fBWw0WZhSgkpcAg1GuaegBR_m0W5T5i_W3Hw5Q>
<xme:zg_iYEVMoFDNtK7cpsZmDaSbogEhym0lPjPdGTLvudBlJFaSDlvsh1wCIKujl3gnP
cE9tG3TAvQh-GtodA>
X-ME-Received: <xmr:zg_iYJLPwnVhKkfufFIay91L51sXGjTSuvY0eEVFXe-R4Sla2suwAQxa1ZmP1IsMOdGJzJ-2ODF-cBew_fE0o_eFkg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeejvddgudefkecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeeh
teffvdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih
iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
nhdrnhgvth
X-ME-Proxy: <xmx:zg_iYFH56mUM-EuKYO60zEwUlsXfm1X4dMdRO1gnqX8vYbnAHZoJgg>
<xmx:zg_iYNWx-tFt4WTwBasp9qBykm93NTWpFTCJkg-iRL75qI73y9-5_w>
<xmx:zg_iYAOyxcpqFPhi2g9kMD-rXBi8-qHqOprT-QtRhprsiDtIdOA6ZQ>
<xmx:zw_iYLf52qc6UiSUKsjqVW3KpCGnTXBHXdRENyfPitOqMSctUKopPg>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
4 Jul 2021 15:45:17 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: David Marchand <david.marchand@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org>,
Igor Romanov <igor.romanov@oktetlabs.ru>, Andy Moreton <amoreton@xilinx.com>,
Ivan Malov <ivan.malov@oktetlabs.ru>
Date: Sun, 04 Jul 2021 21:45:16 +0200
Message-ID: <2072850.3CVXAm7o0J@thomas>
In-Reply-To: <296e71af-1b8d-b306-dc2f-c476c7a44cce@oktetlabs.ru>
References: <20210527152510.1551026-1-andrew.rybchenko@oktetlabs.ru>
<10487590.FxHezTWy5a@thomas>
<296e71af-1b8d-b306-dc2f-c476c7a44cce@oktetlabs.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT
in transfer rules
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
02/07/2021 14:53, Andrew Rybchenko:
> On 7/2/21 3:30 PM, Thomas Monjalon wrote:
> > 02/07/2021 10:43, Andrew Rybchenko:
> >> On 7/1/21 4:05 PM, Andrew Rybchenko wrote:
> >>> On 7/1/21 3:34 PM, David Marchand wrote:
> >>>> On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko
> >>>> <andrew.rybchenko@oktetlabs.ru> wrote:
> >>>>> The build works fine for me on FC34, but it has
> >>>>> libatomic-11.1.1-3.fc34.x86_64 installed.
> >>>>
> >>>> I first produced the issue on my "old" FC32.
> >>>> Afaics, for FC33 and later, gcc now depends on libatomic and the
> >>>> problem won't be noticed.
> >>>> FC32 and before are EOL, but I then reproduced the issue on RHEL 8
> >>>> (and Intel CI reported it on Centos 8 too).
> >>>
> >>> I see. Thanks for the clarification.
> >>>
> >>>>>
> >>>>> I'd like to understand what we're trying to solve here.
> >>>>> Are we trying to make meson to report the missing library
> >>>>> correctly?
> >>>>>
> >>>>> If so, I think I can do simple check using cc.links()
> >>>>> which will fail if the library is not found. I'll
> >>>>> test that it works as expected if the library is not
> >>>>> completely installed.
> >>>>>
> >>>>
> >>>> I tried below diff, and it works for me.
> >>>> "works" as in net/sfc gets disabled without libatomic installed:
> > [...]
> >>>> # for gcc compiles we need -latomic for 128-bit atomic ops
> >>>> if cc.get_id() == 'gcc'
> >>>> + code = '''#include <stdio.h>
> >>>> + void main() { printf("Atomilink me.\n"); }
> >>>> + '''
> >>>> + if not cc.links(code, args: '-latomic', name: 'libatomic link check')
> >>>> + build = false
> >>>> + reason = 'missing dependency, "libatomic"'
> >>>> + subdir_done()
> >>>> + endif
> >>>> ext_deps += cc.find_library('atomic')
> >>>> endif
> >>>
> >>> Many thanks, LGTM. I'll pick it up and add comments why
> >>> it is checked this way.
> >>>
> >>
> >> I've send v4 with the problem fixed. However, I'm afraid
> >> build test systems should be updated to have libatomic
> >> correctly installed. Otherwise, they do not really check
> >> net/sfc build.
> >
> > When testing on old systems, sfc won't be tested anymore after this patchset.
> > On recent systems, sfc should be enabled I guess.
> > I don't see how to manage better, sorry.
> >
>
> I see. I thought that it is possible to install missing
> package on corresponding systems to make build coverage
> better.
>
> Now I automatically test build on problematic distros
> with previously missing packages installed. So I have
> internal build coverage anyway.
David asked for installing libatomic:
https://inbox.dpdk.org/ci/CAJFAV8xCNBL4yEZU0c=dJGYS+13QM7Uz7e2qnUkMuM7eaKKw+Q@mail.gmail.com/
We should wait for it to be installed otherwise ABI check will fail.