From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 104B0A0547; Wed, 21 Apr 2021 20:34:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82DE640687; Wed, 21 Apr 2021 20:34:17 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 11A0240150 for ; Wed, 21 Apr 2021 20:34:16 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id B7D9C17A3; Wed, 21 Apr 2021 14:34:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 21 Apr 2021 14:34:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= wZblWPOirNXwewykLPTITf1LLSk1J1LPv07jDO++3rI=; b=YVTzWO/cKxh328Jl RlK2jJaMs2YDh1XY77lDcQqJghb4VOkkbQ+kq9reumIRF++fEpJBe9ZsTag4xNtX ais+u5S3qKkcLDQiqpkNzbDGesrjTjp+iMLQvehVEqPs33sL8TB7ow/OSeEU4OL6 YfRI48WilhyZbEsMXwh5px2de+G4VHvjESA3jFs2gQmasDkMg25fSeNyECRBK4V4 wvvL2vOBPsYG5FsyCn2M+uMlKdL1F2Sza9TaaKVx5BF+LMPn40dSMWpA5SjRBSIy kIS2Z6uIayAJ6/SlelcLKpDqDHtfvK8XFemKqYm5Iivx69SbOdiqY7HinnUYKslB 2Xaj6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=wZblWPOirNXwewykLPTITf1LLSk1J1LPv07jDO++3 rI=; b=QpJCt24SW2xO6DsSDTe0kDHvklCaL+I0sqnByFWsQqGCZZpqZ2MVtbkF6 Vy0HfbmUFchYBejuYwX2vRnMAaJ68lSqf9i/LRBXYAQi0hGEzbvc3oOR+5ZeIzzu 078IwYFzXDiSgQx8jID54LV9jLFO2VGLZxrBX3bnBebTip+IEFpHana9HL1kvegN /1lbTTzDM4lXpS37AJmB60jaMK6991/soqSz4wYRCWBwZWY/tkla/D3LrannSJS/ 3omdM6PxM7IKih9r0PqysXBH/PRbXB1U4YOZqVYTE3KqjiDfmvRjn0XN6qwAepGg HYZLJaw/s8+vcJFyQfUCjZOMzBsQw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtkedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AE7BB108005F; Wed, 21 Apr 2021 14:34:12 -0400 (EDT) From: Thomas Monjalon To: "Min Hu (Connor)" Cc: dev@dpdk.org, ferruh.yigit@intel.com, rsanford@akamai.com, erik.g.carrillo@intel.com, bruce.richardson@intel.com Date: Wed, 21 Apr 2021 20:34:11 +0200 Message-ID: <2073087.ahSVXVslbx@thomas> In-Reply-To: <1618470748-12369-1-git-send-email-humin29@huawei.com> References: <1618470748-12369-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/04/2021 09:12, Min Hu (Connor): > From: Chengchang Tang > > Timer sample example assumes that the frequency of the timer is about > 2Ghz to control the period of calling rte_timer_manage(). But this > assumption is easy to fail. For example. the frequency of tsc on ARM64 > is much less than 2Ghz. So rte_timer_manage() will be called less often, yes. > This patch uses the frequency of the current timer to calculate the > correct time interval to ensure consistent result on all platforms. I am not sure about making the example more complex. What is the issue with the previous value?