From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id E0ABA58D3 for ; Thu, 19 Jun 2014 10:37:46 +0200 (CEST) Received: by mail-wg0-f45.google.com with SMTP id l18so1907870wgh.4 for ; Thu, 19 Jun 2014 01:38:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=reFUXawGPg31+MKL/r4qnXHClDB7u2h4MksXd47oG6s=; b=RpDM+c2Pb5iHNShSTUM2vo0Mx3g8sZcNm6ENFyjcQTh3zrRo/QLRSKtTcLk6fZGdSc FIuCO1kf8R2OEFmQXQ2PVr2aByXh9VAC136ghNG3g+FeB/PHaM/HZg6yWfftf6F5ds28 F9GFbCEoMWjAsVKgSFeSQWWfnjWvkULRJdJv0npq+cgv8EhTNJktpX5LwhocBUVSRbIa r9TAicn3rdv1yb/dMeCKN5KIJj4hsPKxfOUKDRhIqsKcr+8C19BQt9sl+H+1wUSQ4cj0 tjW1zz4rK74+bl+qJaR15nhAeKVsPDKr6lDzgenPzvhZh7UB9PhzJrDItUU065i+vyT0 FL8w== X-Gm-Message-State: ALoCoQnXfLbUHSM2T6anQkBcfduiV+2iWSEUtdszavQm9L94sCTtKOa4t+6tOSBrCyDluuDRupFj X-Received: by 10.180.99.166 with SMTP id er6mr4486534wib.48.1403167083314; Thu, 19 Jun 2014 01:38:03 -0700 (PDT) Received: from xps13.localnet (110.26.90.92.rev.sfr.net. [92.90.26.110]) by mx.google.com with ESMTPSA id f6sm7239394wja.25.2014.06.19.01.38.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jun 2014 01:38:02 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Thu, 19 Jun 2014 10:37:59 +0200 Message-ID: <2073250.y3o0MLvXtd@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1403030562-25820-1-git-send-email-bruce.richardson@intel.com> References: <1403030562-25820-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] EAL: add format(printf) attrib. to appropriate fns X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jun 2014 08:37:47 -0000 2014-06-17 19:42, Bruce Richardson: > Mark the rte_log, cmdline_printf and rte_snprintf functions as > being printf-style functions. This causes compilation errors > due to mis-matched parameter types, so the parameter types are > fixed where appropriate. > > Signed-off-by: Bruce Richardson Nice cleanup. 2 comments: - I think title should be "fix usage of printf-like functions" - there are some errors in ivshmem code -- Thomas