From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 88ABE1B437
 for <dev@dpdk.org>; Thu,  2 Aug 2018 10:01:17 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 19FB02134B;
 Thu,  2 Aug 2018 04:01:17 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 02 Aug 2018 04:01:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=wmsEL/WfvrsZvMInZRG4TO37Qh
 qlxKbNpQnogkFgyN0=; b=g7WZH2cB9Vixz4YQOIa7ur8eN9ntYh+NOiGDcfjs4p
 Qqw4nnbj8Szb7TQr6WTt4BaravH9bL/Gb/5bKPUkNl17uID47ESpWIy1fXNcwwO6
 pyoCcQXkNfZTLEsqvC65P9CIbYpIjzB0A3RzzTQx8/n2D18t7NHkqE7oQmiwoSdz
 M=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=wmsEL/
 WfvrsZvMInZRG4TO37QhqlxKbNpQnogkFgyN0=; b=mjEVReaGdgfze++hc/Nmip
 aaUlBjq7Skc1A/tJciDvCrtteXJ/rC5gX85uMlPg6p1ga8RzhMyY7NWOaXf96vWX
 KoWuILm7pqYBS29mhUVgY6xjOzP9oIfbJjHWxtmernNz34310vVrHybqHqmhxJqh
 a9O86ufr/nTOYpAL+3vGb4t9smHEuB0XoFkjeYJgJqYtKiZBJnojIM7AkkDD76hg
 F9Tww61QHvDHN5rfPEqOxNAiBD40uzSisLEKjXXFRzgPyKhp3rT3yrOG47PiJjUD
 bjTpx9TUgr4abNDki2owSLt/ybOZ/RQ5+FrgUwzr19isoCz1dbq36ImLdQSfGbTQ
 ==
X-ME-Proxy: <xmx:TLpiWxHOz3Fi0GncON62xoza-wa56F1JkGddxf-ZNlyUArLBBoeIwA>
 <xmx:TLpiWyE52Np51CipWQcd_PjgEaVnEyJfektTzx8U5ZIDegmusbB3xg>
 <xmx:TLpiW17KPVkxb-blZidxQJGQSx1qrYyQTv-iWuWIEUykp-OhuYbMWg>
 <xmx:TLpiW9GcrYUp3zejehuY4xd_S6vl50ZNCQ2yUAqLRruGbLvIRoFqHA>
 <xmx:TLpiWxGpXT3OK4-_D1cufDJQy1EQnf97BV2H9GdNcrSTlnykrVmPRQ>
 <xmx:TbpiW7HEWPpcAwZ40IUHAw0nrVNnucKEgkSZlT7aZK3WVr21UbdZaw>
X-ME-Sender: <xms:TLpiW7gfu2ynpj0ioQoyaRUebRJC94YGzfHkLmZUmnMged_RsMn01Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 06BDF1027B;
 Thu,  2 Aug 2018 04:01:15 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 santosh.shukla@caviumnetworks.com, ferruh.yigit@intel.com
Date: Thu, 02 Aug 2018 10:01:10 +0200
Message-ID: <20741461.PnBBQR08Kh@xps>
In-Reply-To: <20180724153903.GC11073@jerin>
References: <20180724104350.20652-1-pbhagavatula@caviumnetworks.com>
 <20180724153903.GC11073@jerin>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] net/octeontx: fix stop clearing fastpath
	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2018 08:01:17 -0000

> > On dev_stop the Rx/Tx_burst functions are being set to NULL, this causes
> > a SEGFAULT in cases where control path calls stop and a paket is still
> > being processed by a worker.
> > Instead clear the fastpath functions in dev_close.
> > 
> > Fixes: da6c687471a3 ("net/octeontx: add start and stop support")
> 
> Cc: stable@dpdk.org
> 
> > 
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied, thanks

Renamed "fastpath" to "Rx/Tx" to be more explicit.