From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2F95A04DC; Mon, 19 Oct 2020 16:02:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76DD6AD0C; Mon, 19 Oct 2020 16:02:18 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 605CCAD05; Mon, 19 Oct 2020 16:02:15 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DC7525C009C; Mon, 19 Oct 2020 10:02:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 19 Oct 2020 10:02:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Ga0WIhqKmSPubxCzFFBg7hb8uvf7xTdpdzHdyWjz1R0=; b=QYIbKsandPRW/i7B uP+lXE9cvz38fixs45tO6MDeahh45wKUWH0ioeOQlm9lITYk0DDT51Z7pQ+sMqKT Zp7wno24gxbFbjxZfj3lRhjwC0thDisWTqRKGBDqMBJAMKxe4jDujSN+6AiRnPCH 0izZGpIxzz40zPOtbiQbfxMw7lZIoX3p009va83Y5tyE2hG53FKjINVfQ8hgZI87 wmf9EGIDhwz6WMCn0t1/8pbDuQmATGHt7d9vHqsI0t/SpRLyA6GC4VSzdqeAgtbN F641ci+BG7TILPEa+oxO0OfAD/tsIA3H5AexxMnrgGkYSFFKPfkje69KzY52h0sY tMVN5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Ga0WIhqKmSPubxCzFFBg7hb8uvf7xTdpdzHdyWjz1 R0=; b=diDIbxuUCj45Bba9Gm2XlI9CYVNmS4dszp1K3Mh07th0G0nKxCw5tXMi6 QDYLwuBnN4U1CwxfLapAageGWOWkj5pENQ4/WzNd5iZIBHPdFPDSwVZAnLhZxFMu R8dsYVvWGzvVS+kJz/W/R0TQfvG7Ef+hxkObKdgzaIyjmlP5rvkJ5hf8fnrUW217 kNPsv+0WWf0/tWQorUHD5v05fdRbbHgql5oRRnpnT9Of2dw/FHbGOkGyC/5HglAZ /hZgPJ8Z2WUX2PUTRZbTA27tDrHvKp5Sjz3aGcqmuBTttoElgF7tohyS+RQnpMYA h7/mqhPD5OE6bfwSauoAnsCWLPVbA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjedugdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 79A763280067; Mon, 19 Oct 2020 10:02:08 -0400 (EDT) From: Thomas Monjalon To: Gagandeep Singh , Akhil Goyal Cc: "dev@dpdk.org" , "stable@dpdk.org" Date: Mon, 19 Oct 2020 16:02:06 +0200 Message-ID: <2080454.WeOjOQUikl@thomas> In-Reply-To: References: <1603100881-11504-1-git-send-email-g.singh@nxp.com> <3239794.rKUyCbyTsL@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] crypto/caam_jr: fix caam sec era invalid issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/10/2020 14:49, Akhil Goyal: > > > > 19/10/2020 12:33, Akhil Goyal: > > > > Subject: [PATCH] crypto/caam_jr: fix caam sec era invalid issue > > > > > > > > of_init() should be called before using any of_* APIs to retrieve > > > > information from the device tree and if reading integer value > > > > that must be converted to cpu endianness before using. > > > > > > > > Fixes: 1d678de329ab ("crypto/caam_jr: add basic job ring routines") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Gagandeep Singh > > > > --- > > > Acked-by: Akhil Goyal > > > > > > Thomas, > > > Can you pick this in RC1 directly as this is fixing a critical issue in one platform > > of NXP? > > > > It does not say what it fixes (or I am not able to understand). > > What is "era"? > > ERA is the hardware block version for crypto. It may be different on each platform. > On one of the platform this value is not getting read properly. > > Title and Description could be altered as below > > crypto/caam_jr: fix device tree parsing for SEC_ERA > > Previously, SEC_ERA was hardcoded and it was removed in [1]. > Now when that hardcoded was removed, it is supposed to be > read from the device tree but it is not done correctly. > This patch calls a necessary API of_init() before using any > of_* APIs to retrieve information from the device tree and > if reading integer value that must be converted to cpu endianness > before using it. > > [1] eef9e0412a84 ("drivers/crypto: fix build with -fno-common") > Fixes: 1d678de329ab ("crypto/caam_jr: add basic job ring routines") > Cc: stable@dpdk.org > > Signed-off-by: Gagandeep Singh > Acked-by: Akhil Goyal Applied, thanks