From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 527EAA04E6; Mon, 7 Dec 2020 19:30:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EABEBE07; Mon, 7 Dec 2020 19:30:38 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id AECF4CF3; Mon, 7 Dec 2020 19:30:35 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 135BB580414; Mon, 7 Dec 2020 13:30:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 07 Dec 2020 13:30:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= P1T/QOwbMbP0iP6cbMLv448Pxrj31XRIvvgVEKP0vkw=; b=UE7XQJEjj+wv9eK0 hYVPm3H3Ixtpfj+7mbTB0ZBAUUeVWA5XHfzydmfJaWgLSJS+GhWq6Bmu/Y6BgevA grNJZZesTdKpxGyaxd/Sinj+gD2C+WhuXugHeh8qJ3YxuSfA7Y0RRtd6ebDpgKYG rSlOb6B6oCHhccfwtBy8Bt2IEQ9ZeQXfm/NedvN5D2dfyx/A88yEb3m4QeT8SVl/ hWBj4OjvtQ4Ut6yOWIN7V0FJyOh0GReMQhIjkILQEIPLeM+ofUYTNZ94pqFygNyj UYeU7RsBJ2aj7gKcAHuTPXe3Y3kLgi1bYhyisukOvtliocdb61Ps9b0eVc81K5Xk 3NJPIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=P1T/QOwbMbP0iP6cbMLv448Pxrj31XRIvvgVEKP0v kw=; b=e1UECTCK8ALmoOHamgXdau9t4fu/8ESqEDYoe2/TUi05Vh9yJXTTV4QgO OqzF1/nU5/A8CNUc8FQoRQ+cIJs9MNYYvps4sntLnIU28WBM5Q7NL4IGawh8j8GJ 83D5GNDOACDbLTUvti/GrcHfF0Mts2LdIDa1Epimj2GfQGP5vsx7Fn9GumdCV2bj E8faCvNydqnW75tocnnpqtA+7IUwUX1PH3tVFRQdAPBT+iQsHQbjD3GM7rsL6QiE xm/YOG3NCfh98XjyD+rah/xekHo1IHaOEOsTynB5phZXtqSUnmIIj4Q8dpgK9KSy qEd51IR2h2n4/QjSXZT1TUOOYfokA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejgedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 29B43108005F; Mon, 7 Dec 2020 13:30:32 -0500 (EST) From: Thomas Monjalon To: Nick Connolly Cc: Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Keith Wiles , Bruce Richardson , Ranjit Menon , stable@dpdk.org, dev@dpdk.org, David Marchand Date: Mon, 07 Dec 2020 19:30:30 +0100 Message-ID: <2080573.HJaM55CJaF@thomas> In-Reply-To: <20201127110726.5328-1-nick.connolly@mayadata.io> References: <20201127110726.5328-1-nick.connolly@mayadata.io> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] windows: build error with mingw debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/11/2020 12:07, Nick Connolly: > Compiling with MinGW in --buildtype=debug produces a redefinition > error for strncasecmp. > > The root cause is that rte_os.h shouldn't be injecting POSIX definitions > into the environment. It is the applications responsibility to decide > how to handle missing functionality. > > Resolving this properly will require further work, but in the meantime > wrap all such definitions with #ifndef/#endif. This resolves the specific > issue with strncasecmp and handles similar issues that applications may > encounter. > > Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros") > Cc: stable@dpdk.org > > Signed-off-by: Nick Connolly Reported-by: David Marchand It looks as a good fix to me. I'm surprised there was no review. Applied, thanks