Re: [dpdk-dev] [PATCH] config: remove duplicate configuration information

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-03-04 14:44, Wiles, Keith:
> >>>
> >>>--- a/config/defconfig_x86_64-native-bsdapp-clang
> >>>+++ b/config/defconfig_x86_64-native-bsdapp-clang
> >>>@@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
> >>>  CONFIG_RTE_ARCH="x86_64"
> >>>  CONFIG_RTE_ARCH_X86_64=y
> >>>  CONFIG_RTE_ARCH_X86=y
> >>>+CONFIG_RTE_ARCH_64=y
> >>>  
> >>>  CONFIG_RTE_TOOLCHAIN="clang"
> >>>  CONFIG_RTE_TOOLCHAIN_CLANG=y
> >>>diff --git a/config/defconfig_x86_64-native-bsdapp-gcc b/config/defconfig_x86_64-native-bsdapp-gcc
> >>>index 5a6a4e8..4ea4433 100644
> >>>--- a/config/defconfig_x86_64-native-bsdapp-gcc
> >>>+++ b/config/defconfig_x86_64-native-bsdapp-gcc
> >>>@@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
> >>>  CONFIG_RTE_ARCH="x86_64"
> >>>  CONFIG_RTE_ARCH_X86_64=y
> >>>  CONFIG_RTE_ARCH_X86=y
> >>>+CONFIG_RTE_ARCH_64=y
> >>
> >>It should be a totally separate patch.
> >>And there are other places where it is missing.
> 
> I looked in the other defconfig_XXX files and did not see any other places that were missing the CONFIG_RTE_ARCH_64, can you point out those places.

% ls -1 config/defconfig_*64*
config/defconfig_arm64-armv8a-linuxapp-gcc
config/defconfig_arm64-thunderx-linuxapp-gcc
config/defconfig_arm64-xgene1-linuxapp-gcc
config/defconfig_ppc_64-power8-linuxapp-gcc
config/defconfig_x86_64-ivshmem-linuxapp-gcc
config/defconfig_x86_64-ivshmem-linuxapp-icc
config/defconfig_x86_64-native-bsdapp-clang
config/defconfig_x86_64-native-bsdapp-gcc
config/defconfig_x86_64-native-linuxapp-clang
config/defconfig_x86_64-native-linuxapp-gcc
config/defconfig_x86_64-native-linuxapp-icc

% git grep -l RTE_ARCH_64 config
config/defconfig_arm64-armv8a-linuxapp-gcc
config/defconfig_ppc_64-power8-linuxapp-gcc
config/defconfig_tile-tilegx-linuxapp-gcc
config/defconfig_x86_64-native-linuxapp-clang
config/defconfig_x86_64-native-linuxapp-gcc
config/defconfig_x86_64-native-linuxapp-icc

And you've patched:
config/defconfig_x86_64-native-bsdapp-clang
config/defconfig_x86_64-native-bsdapp-gcc

So the missing files seems to be
config/defconfig_arm64-thunderx-linuxapp-gcc
config/defconfig_arm64-xgene1-linuxapp-gcc
config/defconfig_x86_64-ivshmem-linuxapp-gcc
config/defconfig_x86_64-ivshmem-linuxapp-icc

But they include other defconfigs which have ARCH_64.
So you're right, there is no missing file.
Sorry for the confusion