From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 7EB192956 for ; Fri, 4 Mar 2016 16:27:47 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id p65so24945542wmp.1 for ; Fri, 04 Mar 2016 07:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=GICkZZHl80J+YxlZGEdj5yUXupJrW2iH/fZz8VaaQuw=; b=LLfBk0h8+eA54Bld+x+ar1SNmT3LQ6bDKC71kw4dfgCH6+MFCFt/csbkNWECziJKtg 0bo4Nuth+L/961MUqjBPcyzTrVoXxwU/YkWF9/mpfH01btgj54mMvUUvxts/lUVprORx as7ATsJ5sVai3tJ13I1FWpz+VCSjg9GRK2C7TR3AK6FcpPDkl3sPW9eMH1ZcAL/g2J2Q IGlsG//6erz3ZeAqnG+xsJ/J78f3DsAAb0yJcPkGMAA0isyrq+qjNJ3LloP36EYk9ny4 eV43JlO1eNJ99IfXLz7WTT+65F7X2P86Rb1UcDKJswkHw2ECj1TlynVEEpRBf0FMtV0Q WOdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=GICkZZHl80J+YxlZGEdj5yUXupJrW2iH/fZz8VaaQuw=; b=HAqnYz/iqHnQ67VuRfxNU0Sp4Q9yIz+lrd27/u7id5wvWN9zi/boGGQsqfLliVkIn9 KST8xwoSniM3U9T8X7/1oKUdLqtKCuMBRb0JTd8o7vpxyd0IFq8NxCN8lQg4MeJtNJbS /UfUbsjPLg0oPOncdvoToSlX0KsBhP1YP4lHIqlGuxDpEFxpNS8AxXszmO8LJXrDGydP xg5cQtN6egtOJzrsj2BYhZZ2sjIbzvOumtGeG6P2aZJd3bdHyRCdTWdY3CQITPSmw/27 4MYV/y6IWNNnzn3pBMDMgEydiiZf1+/YqiDkF/YEtFQWJjwUq+vOyuJnKP35t21v9uiU /19g== X-Gm-Message-State: AD7BkJIrNC/BQbDV5CVAhCNtTChKn5Zx3Wdb1QCkltjRcjooYG5wRf0jz2+lG7RJXp3tMFLi X-Received: by 10.28.18.194 with SMTP id 185mr6227503wms.14.1457105267341; Fri, 04 Mar 2016 07:27:47 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id lz5sm3874503wjb.5.2016.03.04.07.27.46 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Mar 2016 07:27:46 -0800 (PST) From: Thomas Monjalon To: "Wiles, Keith" Date: Fri, 04 Mar 2016 16:26:10 +0100 Message-ID: <208181529.lrFE2OKGXu@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <320C8D24-5875-4474-8FF9-CFC5980C9C20@intel.com> References: <1456149217-24833-1-git-send-email-keith.wiles@intel.com> <71CD93A7-D0E2-48DC-8368-53C49504CB25@intel.com> <320C8D24-5875-4474-8FF9-CFC5980C9C20@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 15:27:47 -0000 2016-03-04 14:44, Wiles, Keith: > >>> > >>>--- a/config/defconfig_x86_64-native-bsdapp-clang > >>>+++ b/config/defconfig_x86_64-native-bsdapp-clang > >>>@@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native" > >>> CONFIG_RTE_ARCH="x86_64" > >>> CONFIG_RTE_ARCH_X86_64=y > >>> CONFIG_RTE_ARCH_X86=y > >>>+CONFIG_RTE_ARCH_64=y > >>> > >>> CONFIG_RTE_TOOLCHAIN="clang" > >>> CONFIG_RTE_TOOLCHAIN_CLANG=y > >>>diff --git a/config/defconfig_x86_64-native-bsdapp-gcc b/config/defconfig_x86_64-native-bsdapp-gcc > >>>index 5a6a4e8..4ea4433 100644 > >>>--- a/config/defconfig_x86_64-native-bsdapp-gcc > >>>+++ b/config/defconfig_x86_64-native-bsdapp-gcc > >>>@@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native" > >>> CONFIG_RTE_ARCH="x86_64" > >>> CONFIG_RTE_ARCH_X86_64=y > >>> CONFIG_RTE_ARCH_X86=y > >>>+CONFIG_RTE_ARCH_64=y > >> > >>It should be a totally separate patch. > >>And there are other places where it is missing. > > I looked in the other defconfig_XXX files and did not see any other places that were missing the CONFIG_RTE_ARCH_64, can you point out those places. % ls -1 config/defconfig_*64* config/defconfig_arm64-armv8a-linuxapp-gcc config/defconfig_arm64-thunderx-linuxapp-gcc config/defconfig_arm64-xgene1-linuxapp-gcc config/defconfig_ppc_64-power8-linuxapp-gcc config/defconfig_x86_64-ivshmem-linuxapp-gcc config/defconfig_x86_64-ivshmem-linuxapp-icc config/defconfig_x86_64-native-bsdapp-clang config/defconfig_x86_64-native-bsdapp-gcc config/defconfig_x86_64-native-linuxapp-clang config/defconfig_x86_64-native-linuxapp-gcc config/defconfig_x86_64-native-linuxapp-icc % git grep -l RTE_ARCH_64 config config/defconfig_arm64-armv8a-linuxapp-gcc config/defconfig_ppc_64-power8-linuxapp-gcc config/defconfig_tile-tilegx-linuxapp-gcc config/defconfig_x86_64-native-linuxapp-clang config/defconfig_x86_64-native-linuxapp-gcc config/defconfig_x86_64-native-linuxapp-icc And you've patched: config/defconfig_x86_64-native-bsdapp-clang config/defconfig_x86_64-native-bsdapp-gcc So the missing files seems to be config/defconfig_arm64-thunderx-linuxapp-gcc config/defconfig_arm64-xgene1-linuxapp-gcc config/defconfig_x86_64-ivshmem-linuxapp-gcc config/defconfig_x86_64-ivshmem-linuxapp-icc But they include other defconfigs which have ARCH_64. So you're right, there is no missing file. Sorry for the confusion