From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ouyang Changchun <changchun.ouyang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 0/5] Support virtio multicast feature
Date: Wed, 12 Nov 2014 00:16:41 +0100 [thread overview]
Message-ID: <20823298.IzMeYNyBN7@xps13> (raw)
In-Reply-To: <1415420776-4821-1-git-send-email-changchun.ouyang@intel.com>
> -V1 change:
> This patch series support multicast feature in virtio and vhost.
> The vhost backend enables the promiscuous mode and config ETH_VMDQ_ACCEPT_BROADCAST
> and ETH_VMDQ_ACCEPT_MULTICAST in VMDQ offload register to receive the multicast and broadcast packets.
> The virtio frontend provides the functionality of enabling and disabling the multicast and
> promiscuous mode.
>
> -V2 change:
> Rework the patch basing on new vhost library and new vhost application.
>
> -V3 change:
> Rework the patch for comments, split commits.
>
> -V4 change:
> Rework for refining code comment and patch titles, fatorizing codes, and resolving conflicts.
>
> Changchun Ouyang (5):
> ethdev: Add vmdq rx mode
> igb: Config VM offload register
> ixgbe: Configure Rx mode for VMDQ
> virtio: Support promiscuous and allmulticast
> vhost: Enable promisc mode and multicast
I reviewed only the first 3 commits.
The virtio and vhost commits seem to have been reviewed by Huawei.
Next times, a clear acked-by would be preferable.
Please note that this is the role of developpers to request reviews when
needed. Reviews are not always spontaneous :)
Applied
Thanks
--
Thomas
next prev parent reply other threads:[~2014-11-11 23:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 2:09 [dpdk-dev] [PATCH " Ouyang Changchun
2014-08-25 2:09 ` [dpdk-dev] [PATCH 1/5] ethdev: Add new config field to config VMDQ offload register Ouyang Changchun
2014-08-25 2:09 ` [dpdk-dev] [PATCH 2/5] e1000: config VMDQ offload register to receive multicast packet Ouyang Changchun
2014-08-25 2:09 ` [dpdk-dev] [PATCH 3/5] examples/vhost: enable promisc mode and config VMDQ offload register for multicast feature Ouyang Changchun
2014-08-25 2:09 ` [dpdk-dev] [PATCH 4/5] virtio: New API to enable/disable multicast and promisc mode Ouyang Changchun
2014-08-26 0:13 ` Stephen Hemminger
2014-08-26 1:05 ` Ouyang, Changchun
2014-08-26 1:26 ` Stephen Hemminger
2014-08-25 2:09 ` [dpdk-dev] [PATCH 5/5] examples/vmdq: set default value to rx mode Ouyang Changchun
2014-09-24 9:07 ` [dpdk-dev] [PATCH 0/5] Support virtio multicast feature Zhang, XiaonanX
2014-10-27 3:45 ` [dpdk-dev] [PATCH v2 " Ouyang Changchun
2014-10-27 3:45 ` [dpdk-dev] [PATCH v2 1/5] ethdev: Add new config field to config VMDQ offload register Ouyang Changchun
2014-10-27 3:45 ` [dpdk-dev] [PATCH v2 2/5] e1000: config VMDQ offload register to receive multicast packet Ouyang Changchun
2014-10-27 3:45 ` [dpdk-dev] [PATCH v2 3/5] vhost: enable promisc mode and config VMDQ offload register for multicast feature Ouyang Changchun
2014-10-29 23:26 ` Xie, Huawei
2014-10-30 0:49 ` Ouyang, Changchun
2014-10-30 10:10 ` Bruce Richardson
2014-10-30 15:18 ` Ouyang, Changchun
2015-01-08 10:07 ` Xie, Huawei
2015-01-09 5:21 ` Ouyang, Changchun
2015-01-14 16:37 ` Thomas Monjalon
2015-01-23 3:20 ` Xie, Huawei
2014-10-27 3:45 ` [dpdk-dev] [PATCH v2 4/5] virtio: New API to enable/disable multicast and promisc mode Ouyang Changchun
2014-10-27 3:45 ` [dpdk-dev] [PATCH v2 5/5] examples/vmdq: set default value to rx mode Ouyang Changchun
2014-10-31 5:19 ` [dpdk-dev] [PATCH v3 0/5] Support virtio multicast feature Ouyang Changchun
2014-10-31 5:19 ` [dpdk-dev] [PATCH v3 1/5] ethdev: add vmdq rx mode Ouyang Changchun
2014-11-06 13:55 ` Thomas Monjalon
2014-11-08 2:13 ` Ouyang, Changchun
2014-10-31 5:19 ` [dpdk-dev] [PATCH v3 2/5] igb: Config VM offload register Ouyang Changchun
2014-10-31 5:19 ` [dpdk-dev] [PATCH v3 3/5] ixgbe: Config PFVML2FLT register Ouyang Changchun
2014-11-06 13:57 ` Thomas Monjalon
2014-10-31 5:19 ` [dpdk-dev] [PATCH v3 4/5] virtio: New API for promisc and allmulticast Ouyang Changchun
2014-11-06 13:59 ` Thomas Monjalon
2014-10-31 5:19 ` [dpdk-dev] [PATCH v3 5/5] vhost: enable promisc mode and multicast Ouyang Changchun
2014-11-08 4:26 ` [dpdk-dev] [PATCH v4 0/5] Support virtio multicast feature Ouyang Changchun
2014-11-08 4:26 ` [dpdk-dev] [PATCH v4 1/5] ethdev: Add vmdq rx mode Ouyang Changchun
2014-11-08 4:26 ` [dpdk-dev] [PATCH v4 2/5] igb: Config VM offload register Ouyang Changchun
2014-11-08 4:26 ` [dpdk-dev] [PATCH v4 3/5] ixgbe: Configure Rx mode for VMDQ Ouyang Changchun
2014-11-08 4:26 ` [dpdk-dev] [PATCH v4 4/5] virtio: Support promiscuous and allmulticast Ouyang Changchun
2014-11-08 4:26 ` [dpdk-dev] [PATCH v4 5/5] vhost: Enable promisc mode and multicast Ouyang Changchun
2014-11-11 23:16 ` Thomas Monjalon [this message]
2014-11-12 0:29 ` [dpdk-dev] [PATCH v4 0/5] Support virtio multicast feature Ouyang, Changchun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20823298.IzMeYNyBN7@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).