From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0D072EE2D for ; Tue, 17 Apr 2018 01:19:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9B72B21B05; Mon, 16 Apr 2018 19:19:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 16 Apr 2018 19:19:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Phl8tyBbRAOzIMNxW+eJ8isNgj 9L32w6typH+xjOceo=; b=qBcKG14iU9PXupW0l1c3X/b+p+E92JVRlRZV4nqgdZ pgPHNgI3gk5PUDlzRNp41lG5lekf2m7RISrExVjzvuqdkgpZVa1F8yop7iSNL4OO rGXg1Y3aZkU9NlotEOi3JlfOaaNqPT39ELsvZAoutzIEBn07tTQR1m1vI6jY7p30 M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Phl8ty BbRAOzIMNxW+eJ8isNgj9L32w6typH+xjOceo=; b=cE/TgMCP4TG1RHe5BSnaYy vKg8Plw939VEGWiEZNkx7/fK4nqMWWvNpw6843Jj+PYk3lX2g0aXLfu9rG5Ge8NL 1Ki/JlzRxx9eaRiXzeqVfRC3p64vEx4M1L2mIHe5GuVg/Mv+UU4qKfr8tDiPY8hP bIpG36px2v7tqmGTxJqmY6KXnWdiWJx91unttmDwWIHitHPIpLEjDnuLnxO5J//B t9TeJIa5Le6G6DNaLftSL2l22SGRqqL3QBZg1UG8D42zY0kHtaUX1KG5E0H3in8A dTdYcDRYuG0K6Kx6N8slC5K3pxUeBqv2SI3IkKe/8isrg2oBm4bmsirwRfRC66kA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0C782E43E8; Mon, 16 Apr 2018 19:19:36 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, "Tan, Jianfeng" Date: Tue, 17 Apr 2018 01:19:35 +0200 Message-ID: <2082606.hxpljrm1bS@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] eal/ipc: fix use-after-free in synchronous requests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 23:19:38 -0000 13/04/2018 17:33, Tan, Jianfeng: > > On 4/13/2018 7:54 PM, Anatoly Burakov wrote: > > Previously, we were adding synchronous requests to request list, we > > were doing it after checking if request existed. However, we only > > removed the request from the request list if we have succeeded in > > sending the request. In case of failed request send, we left an > > invalid pointer in the request list. > > > > Fix this by only adding request to the list once we succeed in > > sending it. > > > > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > > Cc: jianfeng.tan@intel.com > > > > Signed-off-by: Anatoly Burakov > > Nice catch. > > Acked-by: Jianfeng Tan Series applied, thanks