From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E8F371B1F2 for ; Thu, 12 Oct 2017 00:32:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7A2852193A; Wed, 11 Oct 2017 18:32:27 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 11 Oct 2017 18:32:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ThCVOsIUualmhbVhE8Ruz1VijU Nvwnix/EG7DWsOhwc=; b=TjWIPN69FTq2HP9oGUIyGmGxXEMQuVtj5FqWI7peGF NAyYO7biET2A8wUVANSreqXAN6z8n4ySkQKxUTUoOCHwpFB9Y3oK4yQ6U0CZod87 jlu73sTIrmJee8T8ElWU1wOGsqb+0A3ke2Jfovxub06OUcQdIQfD24UbGQ+AJGLO s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ThCVOs IUualmhbVhE8Ruz1VijUNvwnix/EG7DWsOhwc=; b=pUdupcUyRWYGrOkeqKdav9 qs6H8orCSReqXFryPwo17YQfBKFv4bnrR39ANnMwiK70DDwGP8YBsUDL7pZ7Ozfm AbNS/s45pekzq3ixYgJJG/Mv0e+KV8GJfww5+kAgPvsqk/racWiYrPwjzadIyr6B JdkbzCJ3qrSLi3Y67n2tbshbXKM107pliOZ3mrIRMiVGe+EcpVkqSS5GMobgkDSq qSdyLN09ZLiId4dBAzymx4wgQlvQhawjRcnbVrvF8KHHLbnD8d11YZcNdQklBE4R vUTVzEgtsXrQOrsl+OsTRoTTI9NJiztyaZuFam4NBsJ2nTW3JF1gokdqtaELwuPQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0C7347E3E2; Wed, 11 Oct 2017 18:32:27 -0400 (EDT) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, Don Provan , Jan Blunck , Hemant Agrawal Date: Thu, 12 Oct 2017 00:32:25 +0200 Message-ID: <2083909.jE3c2aJxlO@xps> In-Reply-To: References: <20170812102220.27773-1-shreyansh.jain@nxp.com> <83a3c6c6-8d50-8106-7c7f-9b5c8263ce96@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 22:32:28 -0000 11/10/2017 02:03, Don Provan: > From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com] > > > > ... > > > > > From the application's point of view, the potential error here > > > is that the device it wants to use isn't available. I don't see that > > > either the init function or the probe function will have enough > > > information to understand that application-level problem, so > > > they should leave it to the application to detect it. > > > > I think I understand you comment but just want to cross check again: > > Scan or probe error should simply be ignored by EAL layer and let the > > application take stance when it detects that the device it was looking > > for is missing. Is my understanding correct? > > > > I am trying to come a conclusion so that this patch can either be > > modified or pushed as it is. If the above understanding is correct, I > > don't see any changes required in the patch. > > Yes, I agree my comments support the patch as is. > -don Applied, thanks for the discussion