From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89D79A00E6 for ; Mon, 8 Jul 2019 19:45:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45DD23237; Mon, 8 Jul 2019 19:45:09 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 9CBFC322C for ; Mon, 8 Jul 2019 19:45:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8CFA16F3; Mon, 8 Jul 2019 13:45:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 08 Jul 2019 13:45:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=YOHmf1AAW5NqVP3pQpwBP9peZzjkQQjCWE7DClHLDs0=; b=bSK8Lz8835iW BepNEp+wrgk4paYdllVwAVElb5whTO+A0pEGA2XaYPpudWFI6i9dMGjUOJUKOCLZ rufSjzOeArDWS16OL2NuaXUFfVOi21z4Cu7TfWPc3sMa0TGpQdp0vwmPnu/MSL6s HPV7SZXlbtmlr09Rss06A6viGUtTRx4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=YOHmf1AAW5NqVP3pQpwBP9peZzjkQQjCWE7DClHLD s0=; b=rUwdRMk7oPZLaeDDelRQRk96LyuYgQhi3MPBf+Ddp9XGDdSdQzADA9jBz DV8PpIM3grj1+w/jBO/itn9pJ6BfI3dWTwUzKj8w9VC7ez/ydY5QGA7wamGyRYns iU+bG2RPo4X/nRr4VwkpKvmepyf6J3O6+OB4rk7zfDu+gE/hD3cXkooUbQS1JJBi Ny65hc3IXHgIAtf7G3+jks4WLQfuXHf3IiHYjoB0oJF8Z19W6s8YZbo+LJ25C/rS 74faeyF3lqiNIoqgdHwYvY6SWiYUasj8aXVw/k3cV2xogyDKTWnQM+RN9qUC28ep jxW6ivID5mqszhmOT6FrOQV23Rkbg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgedtgdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E0758380074; Mon, 8 Jul 2019 13:45:04 -0400 (EDT) From: Thomas Monjalon To: David Christensen Cc: dev@dpdk.org, Takeshi Yoshimura , dwilder@us.ibm.com Date: Mon, 08 Jul 2019 19:45:01 +0200 Message-ID: <2084101.Qpx90Az0he@xps> In-Reply-To: <66dc5ae0-22f2-86e2-e98a-7629d335c9f4@linux.vnet.ibm.com> References: <20190607022830.2044-1-tyos@jp.ibm.com> <4027907.MzmCEAoYMI@xps> <66dc5ae0-22f2-86e2-e98a-7629d335c9f4@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/07/2019 18:47, David Christensen: > > Please, any review or ack for this patch? > > > > 07/06/2019 04:28, Takeshi Yoshimura: > >> sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. > >> However, Linux 4.17 or before returns incorrect page_shift for Power9. > >> I added the code for retrying creation of sPAPR DMA window. > >> > >> Signed-off-by: Takeshi Yoshimura > > I've shared my comments with Takeshi and I don't think the patch is > ready in it's current state. It appears to modify x86 functionality and > I'm not comfortable with signing off on that since it's in an anrea I'm > not familiar with. It is a function specific to sPAPR. So there is no risk for x86 or Arm. As you didn't share your comments publicly, this patch has been merged in 19.08-rc1.