From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 87CB27E89 for ; Mon, 20 Oct 2014 23:56:43 +0200 (CEST) Received: by mail-wi0-f179.google.com with SMTP id d1so228964wiv.6 for ; Mon, 20 Oct 2014 15:04:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=LF17oJ8xnaC8roBizXp1fOWikiRxI7DDGWnm/LJcGHc=; b=UC7RVcjY/sOW2ho96QY84fnRUbldsXn9Y8Gmz8KpMaHzN2IMDCiWb+06i7j8BbpSEi Ki9oP5LbS4OJzAQ5u55yRNZzst+vPZTDs+3KxvjmZVDczGJQT9a7feVhN/fn94fcRxyf /x0v0EfsZcItwF/1mIz+HHOg2FhHW5ODQK16qYC6Pktbs+2K/ASqaQh1hJDwCVQ896Rf gFGrRxI2pM6LoCGsEC8uXNKuarbfKKIw3togHUxRV8dk2b9MDWRi7eNnhfvB/+vra/7d Y8nP4zZzaPYcW6Kf4Mm0eKVFWHd8/JjOEt0qVqIixG33hrI/SFmL4XWisXMF3jC5K2ir nv4w== X-Gm-Message-State: ALoCoQm8TFn3pSXTDmJ1R2Lh/AqalkZmSzRHE/3SSyU2Mhg6deZkG/0N1MiYjjp77au2QZYDkT+9 X-Received: by 10.180.188.41 with SMTP id fx9mr23325493wic.59.1413842696676; Mon, 20 Oct 2014 15:04:56 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id cu9sm13271005wjc.3.2014.10.20.15.04.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Oct 2014 15:04:56 -0700 (PDT) From: Thomas Monjalon To: Jingjing Wu Date: Tue, 21 Oct 2014 00:04:40 +0200 Message-ID: <2085898.nAXrvty0kN@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1413783633-16222-1-git-send-email-jingjing.wu@intel.com> References: <1413502161-31403-1-git-send-email-jingjing.wu@intel.com> <1413783633-16222-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/2] new filter APIs definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Oct 2014 21:56:43 -0000 2014-10-20 13:40, Jingjing Wu: > new filter APIs definition in ethdev > define filter_ctrl ops in i40e driver > > v2 changes: > remove OP from the name of filter opeartions > add API implementation in i40e. > correct comments > > Jingjing Wu (2): > librte_ether: new filter APIs definition > i40e: define filter_ctrl ops in i40e driver As Bruce suggested, RTE_ETH_FILTER_NOP is simpler than RTE_ETH_FILTER_OP_NONE. And I think RTE_ETH_FILTER_GET_INFO could be RTE_ETH_FILTER_INFO. Last comment: filtering features (fdir, hash) should not be defined at this stage. I know that we want this patch integrated with high priority, so I made the above changes by myself. Hope you'll agree. Acked-by: Thomas Monjalon Applied Thank you for your patience -- Thomas