From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Ciara Power <ciara.power@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
John Griffin <john.griffin@intel.com>,
Deepak Kumar Jain <deepak.k.jain@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options
Date: Fri, 23 Oct 2020 19:24:07 +0200 [thread overview]
Message-ID: <2086275.x25LNfssgf@thomas> (raw)
In-Reply-To: <CAJFAV8yYD9Vz_AT078FSQzWosrjxAG6FV3uVUB4cUZcfHV2Uqg@mail.gmail.com>
23/10/2020 09:37, David Marchand:
> On Fri, Oct 23, 2020 at 12:05 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > Below patches are cleaning traces of CONFIG_RTE_ after make removal,
> > except one occurence in app/test/test_cryptodev.c (left as exercise).
> > PS: In reality I don't know what must be done for this case about QAT.
>
> It seems a reintroduction with raw datapath API merge.
>
> I would apply the same as Ciara previous:
> https://git.dpdk.org/dpdk/diff/app/test/test_cryptodev.c?id=c2c92c5d88522bb7f149de8ea6305691d1c65505
>
> I.e.
> @@ -14022,9 +14022,7 @@ test_cryptodev_qat_raw_api(void /*argv
> __rte_unused, int argc __rte_unused*/)
> RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
>
> if (gbl_driver_id == -1) {
> - RTE_LOG(ERR, USER1, "QAT PMD must be loaded. Check that both "
> - "CONFIG_RTE_LIBRTE_PMD_QAT and CONFIG_RTE_LIBRTE_PMD_QAT_SYM "
> - "are enabled in config file to run this testsuite.\n");
> + RTE_LOG(ERR, USER1, "QAT PMD must be loaded.\n");
> return TEST_SKIPPED;
> }
Yes it seems the right thing to do.
> The rest of the series looks good to me.
> Acked-by: David Marchand <david.marchand@redhat.com>
Applied with above change
prev parent reply other threads:[~2020-10-23 17:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 22:05 Thomas Monjalon
2020-10-22 22:05 ` [dpdk-dev] [PATCH 1/5] eal: remove comment about old partition option Thomas Monjalon
2020-10-28 12:08 ` Burakov, Anatoly
2020-10-22 22:05 ` [dpdk-dev] [PATCH 2/5] mem: fix config name in error logs Thomas Monjalon
2020-10-28 12:08 ` Burakov, Anatoly
2020-10-22 22:05 ` [dpdk-dev] [PATCH 3/5] lib: remove config prefix used with make Thomas Monjalon
2020-10-23 6:28 ` Ruifeng Wang
2020-10-22 22:05 ` [dpdk-dev] [PATCH 4/5] drivers: " Thomas Monjalon
2020-10-22 22:10 ` Ajit Khaparde
2020-10-23 1:55 ` Wang, Haiyue
2020-10-23 6:47 ` Andrew Rybchenko
2020-10-22 22:05 ` [dpdk-dev] [PATCH 5/5] doc: remove references to make from known issues Thomas Monjalon
2020-10-23 7:37 ` [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options David Marchand
2020-10-23 17:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2086275.x25LNfssgf@thomas \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).