From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id E49A27F2D
 for <dev@dpdk.org>; Wed,  5 Nov 2014 22:16:12 +0100 (CET)
Received: by mail-wg0-f49.google.com with SMTP id x13so1914281wgg.8
 for <dev@dpdk.org>; Wed, 05 Nov 2014 13:25:37 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=NEOMZyQY1ZToGat+cowYN16kprhZXIRi0eJzqrSPxBU=;
 b=EKS0vEUxJ5Qm/Cij0qhvIm0bP2lz4C7Ab19Ir+mpmcAIc1S2Rqy6k685AQKB+8cefn
 xb/42vrFwVepuhnFFrvsOUiSfnVDCcybvP5X9F9EugsHL0abKhjwXw8X5jL7LvSKiY/w
 2DBO1Hucng3Ld495IoXmP+eqItNnnpgpuK/wOgPTgY/Jwc5AKC+ebXe057qM0W6chDC4
 A9FdGV7E9oQUS5IH5ESLuxO9tQ8ATDcOuSXja1klYIoAuYy8We/oaf2MJJNxlibRNjS1
 z2uw9HP9YC+AiDyx+6QmzUFjYkDNAvsWpCMxRaE6z1YJNiu2WRBuuwaCwRkAAYcUreej
 CUwg==
X-Gm-Message-State: ALoCoQm1ByUvEodvR9pkaDC0lMmjB+PhHVY/n2iX1ND23jqLwhAf8dP+1SyDHtZtiRwFHB3xzN2p
X-Received: by 10.194.191.136 with SMTP id gy8mr5049wjc.72.1415222737407;
 Wed, 05 Nov 2014 13:25:37 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id bl9sm17134395wib.24.2014.11.05.13.25.36
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 05 Nov 2014 13:25:36 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Date: Wed, 05 Nov 2014 22:25:17 +0100
Message-ID: <2088055.shkfIhmk6J@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; )
In-Reply-To: <C37D651A908B024F974696C65296B57B0F2E23EB@SHSMSX101.ccr.corp.intel.com>
References: <1415206995-1086-1-git-send-email-huawei.xie@intel.com>
 <6180706.cUEATDuu1O@xps13>
 <C37D651A908B024F974696C65296B57B0F2E23EB@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Nov 2014 21:16:13 -0000

2014-11-05 21:21, Xie, Huawei:
> Thomas:
> I checked before. checkpatch reports  9 warnings, "over 80 characters" and "prefer pr_deubg".
> This code style fixes code style issue only, not the pr_debug/printk issue. Thoughts?

Using pr_debug is a code style fix.

> Besides, I don't understand the MISORDERED_TYPE.

You should replace (long long unsigned) by (unsigned long long).

> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Wednesday, November 05, 2014 1:42 PM
> > To: Xie, Huawei
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: code style fixes
> > 
> > Hi Huawei,
> > 
> > checkpatch.pl reports some errors of types PREFER_PR_LEVEL
> > and MISORDERED_TYPE.
> > 
> > --
> > Thomas