DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergey Mironov <grrwlf@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] igb_ethdev.c: complete switches for i211 NC
Date: Wed, 24 Sep 2014 19:38:29 +0200	[thread overview]
Message-ID: <2088737.Lh69b6AKpB@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A78D4F8@SHSMSX104.ccr.corp.intel.com>

2014-09-10 01:28, Zhang, Helin:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergey Mironov
> > Hi! I have got an update for my "i212 problem". First of all, I found that I have
> > made a mistake. My controller is named i211, not i212 :) Next, i211 controller is
> > controlled by the lib_pmd_e1000 driver.
> > Unfortunately, looks like it's support is pure. For example, igb_ethdev.c
> > contains function eth_igb_infos_get() which should set number of tx/rx queues
> > supported by the hardware. It contains huge [switch] but there is no i211 case!
> > That is why I see zeros every time I try to start this NC. Also, there are few
> > other places which mention i210, but not mention i211. I've attached a patch
> > which adds necessary
> > i211 support, but I didn't check it enough to say it is totally correct. For now I
> > see that it just able to send and receive some packets.
> > 
> > Could you please review/correct it?

The funny thing is that the file igb_rxtx.c seems to already support i211,
but not igb_ethdev.c. Thanks for fixing that.

> >  	if ((hw->mac.type == e1000_82576) || (hw->mac.type == e1000_82580) ||
> > -		(hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210)) {
> > +		(hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210) ||
> > +    (hw->mac.type == e1000_i211)) {

Wrong indent here.

> Reviewed-by: Helin Zhang <helin.zhang@intel.com>
> 
> Really good to have this patch of supporting i211! Thank you very much!

Acked and applied with indent fix.

Thanks
-- 
Thomas

      reply	other threads:[~2014-09-24 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04  8:35 Sergey Mironov
2014-09-10  1:28 ` Zhang, Helin
2014-09-24 17:38   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2088737.Lh69b6AKpB@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=grrwlf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).