From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 8D73E1F5 for ; Wed, 24 Sep 2014 19:32:23 +0200 (CEST) Received: by mail-we0-f174.google.com with SMTP id w62so6183614wes.33 for ; Wed, 24 Sep 2014 10:38:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=w8089YGmjIeINS5Hd7SPngXvUDXx0mNwCmqEOyNZo0Y=; b=A6yUcUn9s5naxAppFSvVJlCkNxDwjf3BV94Zn+2S+hHNXpr+7llrVGq5t03OIRndya D2OENI3m6VJW+rHlx+TKea3hwy30y+CeVrtp2XbUNGMf0z3Dg9lRT62Dlt99+evVDxE+ 8NhRTXOSOLzTfP/5BVLZFd1oQu66SRoNj5p9nsTyKoRh3GiGEf/HNUNQ238vGa9sqj0B Snnkhxq3tkkloWMUr4VVFgs4xydUqzMrstO3gN1XvsMSJ6t7MOuh+EmCuwilMVMtPx6d qpZNEOoDA0HRHQ7WQ5xrxIPNv2X07RrpZqvxgwzW8K8jDiTN1HnXJD9BWVZnr48uPMS3 sIBQ== X-Gm-Message-State: ALoCoQkouX0rNGQm/sWwEIeBErEJ/UCqh19p9Vka+FQQi00OVOUDRpjU79XuVyDAcoGuv9/wtea4 X-Received: by 10.180.206.230 with SMTP id lr6mr13434665wic.82.1411580317482; Wed, 24 Sep 2014 10:38:37 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id et1sm20142869wjd.11.2014.09.24.10.38.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Sep 2014 10:38:36 -0700 (PDT) From: Thomas Monjalon To: Sergey Mironov Date: Wed, 24 Sep 2014 19:38:29 +0200 Message-ID: <2088737.Lh69b6AKpB@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: <1409819711-18718-1-git-send-email-grrwlf@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] igb_ethdev.c: complete switches for i211 NC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2014 17:32:23 -0000 2014-09-10 01:28, Zhang, Helin: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergey Mironov > > Hi! I have got an update for my "i212 problem". First of all, I found that I have > > made a mistake. My controller is named i211, not i212 :) Next, i211 controller is > > controlled by the lib_pmd_e1000 driver. > > Unfortunately, looks like it's support is pure. For example, igb_ethdev.c > > contains function eth_igb_infos_get() which should set number of tx/rx queues > > supported by the hardware. It contains huge [switch] but there is no i211 case! > > That is why I see zeros every time I try to start this NC. Also, there are few > > other places which mention i210, but not mention i211. I've attached a patch > > which adds necessary > > i211 support, but I didn't check it enough to say it is totally correct. For now I > > see that it just able to send and receive some packets. > > > > Could you please review/correct it? The funny thing is that the file igb_rxtx.c seems to already support i211, but not igb_ethdev.c. Thanks for fixing that. > > if ((hw->mac.type == e1000_82576) || (hw->mac.type == e1000_82580) || > > - (hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210)) { > > + (hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210) || > > + (hw->mac.type == e1000_i211)) { Wrong indent here. > Reviewed-by: Helin Zhang > > Really good to have this patch of supporting i211! Thank you very much! Acked and applied with indent fix. Thanks -- Thomas