From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BB65A04B5; Tue, 12 Jan 2021 00:28:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7695140D12; Tue, 12 Jan 2021 00:28:28 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 2AE71140D0A; Tue, 12 Jan 2021 00:28:27 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id BD4DE5C0191; Mon, 11 Jan 2021 18:28:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 11 Jan 2021 18:28:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= C/8ktLpCfLpH5vKKSqRENDiwXMiHByUU61BffFXZgLw=; b=qWjvVftPEO0m7GP7 XvcX0HkXbT7tuWp5qtZHVww+T8lM+E8UEgNt3wTWMn4OXQQ+LbgvDeajrcWRA/yh lU8UAi3s2wNJ1I8TDe3voXfWVixTChez/6sddynffiimJWmh3w+GiF6nh380GSmN JKleP5s3VtxuLfmMunrr5qsRyALUNwYJbkGSr8WWzZkEXo8M4CQV6gxpXtUi2rln r8XL+N8l1+lEwvGDaikJ2hAIriWq3/Q0cZ9OE96Klxa4387qXXGLIqqAR6i+Qn3I 3HB6ZsS+AhVY6ULAofQ6Nf76dHxSW6C9zpiOU5xGfh8Xtra1YJOnPr6OXvOlkxmy AVQrCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=C/8ktLpCfLpH5vKKSqRENDiwXMiHByUU61BffFXZg Lw=; b=rn4j36yumQGN8Y5fwL2uXG2b9LKV78B86rWkcX0Yh4astm3y9LNROAoB+ VDLrhza7g3SLqkMnob2m+pCXArAvh3QbpaXoPV2LqLBbCQchAF9kItfQWu2Eq7G0 ikrCUmBuvKqFXAaUUJdDw+T1JeC7O1Zyk60WOXKobd65w+VieB8E1GZ/70zV+d0f LH88V8gSncjdA524WASOarm34udb7ol1ohEHUsJL0Y1/NXhlKeKXiIEzot6/sz27 NAxXLgmAlLBYaxKWrTk1ytQW26tVB39Ob3PbMByOx5AckxrYD7z8LpWwJyrUDleW 3VCxpcznYZr5k8WnOuNUaCWTZMYog== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdehvddgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9EEC4240064; Mon, 11 Jan 2021 18:28:25 -0500 (EST) From: Thomas Monjalon To: Dekel Peled Cc: matan@nvidia.com, shahafs@nvidia.com, viacheslavo@nvidia.com, dev@dpdk.org, stable@dpdk.org Date: Tue, 12 Jan 2021 00:28:23 +0100 Message-ID: <2089738.cP4b0ayXZ8@thomas> In-Reply-To: References: <670e2f1c1644f8722b707d5f4d69eb460868317e.1609682638.git.dekelp@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix flow check hairpin split X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/01/2021 18:37, Dekel Peled: > Previously, the identification of hairpin queue was done using > mlx5_rxq_get_type() function. > Recent patch replaced it with use of mlx5_rxq_get_hairpin_conf(), > and check of the return value conf != NULL. > The case of return value is NULL (queue is not hairpin) was not handled. > As result, non-hairpin flows were wrongly handled. > This patch adds the required check for return value is NULL. > > Fixes: 509f8470de55 ("net/mlx5: do not split hairpin flow in explicit mode") > Cc: stable@dpdk.org > > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad Applied in next-net-mlx, thanks.