* [dpdk-dev] [PATCH] doc: added inline crypto feature
@ 2017-11-08 13:26 Radu Nicolau
2017-11-08 14:22 ` Thomas Monjalon
2017-11-09 12:23 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
0 siblings, 2 replies; 8+ messages in thread
From: Radu Nicolau @ 2017-11-08 13:26 UTC (permalink / raw)
To: dev
Cc: thomas, ferruh.yigit, wenzhuo.lu, konstantin.ananyev,
pablo.de.lara.guarch, Radu Nicolau
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
doc/guides/nics/features.rst | 17 +++++++++++++++++
doc/guides/nics/features/default.ini | 1 +
doc/guides/nics/features/ixgbe.ini | 2 ++
doc/guides/nics/features/ixgbe_vec.ini | 2 ++
doc/guides/nics/features/ixgbe_vf.ini | 2 ++
doc/guides/nics/features/ixgbe_vf_vec.ini | 2 ++
6 files changed, 26 insertions(+)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index bfeae80..1170da8 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -900,6 +900,23 @@ Documentation describes performance values.
See ``dpdk.org/doc/perf/*``.
+.. _nic_features_inline_crypto_doc:
+
+Inline crypto
+-------------
+
+Supports inline crypto processing (eg. inline IPsec). See Security library for more details.
+
+* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
+* **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
+* **[implements] rte_security_ops**: ``session_create``, ``session_update``,
+ ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, ``capabilities_get``.
+* **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
+ ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
+* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
+ ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
+
+
.. _nic_features_other:
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index dc527dd..9ef6a2a 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -77,3 +77,4 @@ Usage doc =
Design doc =
Perf doc =
Mbuf fast free =
+Inline crypto =
diff --git a/doc/guides/nics/features/ixgbe.ini b/doc/guides/nics/features/ixgbe.ini
index 9ff5d8f..900840f 100644
--- a/doc/guides/nics/features/ixgbe.ini
+++ b/doc/guides/nics/features/ixgbe.ini
@@ -58,3 +58,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/features/ixgbe_vec.ini b/doc/guides/nics/features/ixgbe_vec.ini
index 4d56df4..5e32c08 100644
--- a/doc/guides/nics/features/ixgbe_vec.ini
+++ b/doc/guides/nics/features/ixgbe_vec.ini
@@ -47,3 +47,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/features/ixgbe_vf.ini b/doc/guides/nics/features/ixgbe_vf.ini
index b63e32c..f217b09 100644
--- a/doc/guides/nics/features/ixgbe_vf.ini
+++ b/doc/guides/nics/features/ixgbe_vf.ini
@@ -37,3 +37,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/features/ixgbe_vf_vec.ini b/doc/guides/nics/features/ixgbe_vf_vec.ini
index c994857..9549aab 100644
--- a/doc/guides/nics/features/ixgbe_vf_vec.ini
+++ b/doc/guides/nics/features/ixgbe_vf_vec.ini
@@ -29,3 +29,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
--
2.7.5
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: added inline crypto feature
2017-11-08 13:26 [dpdk-dev] [PATCH] doc: added inline crypto feature Radu Nicolau
@ 2017-11-08 14:22 ` Thomas Monjalon
2017-11-08 14:31 ` Radu Nicolau
2017-11-09 12:23 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
1 sibling, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2017-11-08 14:22 UTC (permalink / raw)
To: Radu Nicolau
Cc: dev, ferruh.yigit, wenzhuo.lu, konstantin.ananyev, pablo.de.lara.guarch
Hi,
08/11/2017 14:26, Radu Nicolau:
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -900,6 +900,23 @@ Documentation describes performance values.
> See ``dpdk.org/doc/perf/*``.
>
>
> +.. _nic_features_inline_crypto_doc:
This anchor seems useless.
> +
> +Inline crypto
> +-------------
> +
> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details.
As there are several types of inline crypto, don't you think it deserves
several separate features?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: added inline crypto feature
2017-11-08 14:22 ` Thomas Monjalon
@ 2017-11-08 14:31 ` Radu Nicolau
2017-11-08 15:13 ` Thomas Monjalon
0 siblings, 1 reply; 8+ messages in thread
From: Radu Nicolau @ 2017-11-08 14:31 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, ferruh.yigit, wenzhuo.lu, konstantin.ananyev, pablo.de.lara.guarch
On 11/8/2017 2:22 PM, Thomas Monjalon wrote:
> Hi,
>
> 08/11/2017 14:26, Radu Nicolau:
>> --- a/doc/guides/nics/features.rst
>> +++ b/doc/guides/nics/features.rst
>> @@ -900,6 +900,23 @@ Documentation describes performance values.
>> See ``dpdk.org/doc/perf/*``.
>>
>>
>> +.. _nic_features_inline_crypto_doc:
> This anchor seems useless.
It is, I will remove it.
>
>> +
>> +Inline crypto
>> +-------------
>> +
>> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details.
> As there are several types of inline crypto, don't you think it deserves
> several separate features?
We don't differentiate in the offload, net, mbuf APIs; it's all
"security offload".
rte_security is the one that deals with different kinds of inline
crypto, but in the NIC section it's all the same.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: added inline crypto feature
2017-11-08 14:31 ` Radu Nicolau
@ 2017-11-08 15:13 ` Thomas Monjalon
2017-11-08 15:40 ` Radu Nicolau
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2017-11-08 15:13 UTC (permalink / raw)
To: Radu Nicolau
Cc: dev, ferruh.yigit, wenzhuo.lu, konstantin.ananyev, pablo.de.lara.guarch
08/11/2017 15:31, Radu Nicolau:
> On 11/8/2017 2:22 PM, Thomas Monjalon wrote:
> > 08/11/2017 14:26, Radu Nicolau:
> >> +
> >> +Inline crypto
> >> +-------------
> >> +
> >> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details.
> >
> > As there are several types of inline crypto, don't you think it deserves
> > several separate features?
>
> We don't differentiate in the offload, net, mbuf APIs; it's all
> "security offload".
> rte_security is the one that deals with different kinds of inline
> crypto, but in the NIC section it's all the same.
OK
How can we document which kind of inline crypto is supported with which device?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: added inline crypto feature
2017-11-08 15:13 ` Thomas Monjalon
@ 2017-11-08 15:40 ` Radu Nicolau
0 siblings, 0 replies; 8+ messages in thread
From: Radu Nicolau @ 2017-11-08 15:40 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, ferruh.yigit, wenzhuo.lu, konstantin.ananyev, pablo.de.lara.guarch
On 11/8/2017 3:13 PM, Thomas Monjalon wrote:
> 08/11/2017 15:31, Radu Nicolau:
>> On 11/8/2017 2:22 PM, Thomas Monjalon wrote:
>>> 08/11/2017 14:26, Radu Nicolau:
>>>> +
>>>> +Inline crypto
>>>> +-------------
>>>> +
>>>> +Supports inline crypto processing (eg. inline IPsec). See Security library for more details.
>>> As there are several types of inline crypto, don't you think it deserves
>>> several separate features?
>> We don't differentiate in the offload, net, mbuf APIs; it's all
>> "security offload".
>> rte_security is the one that deals with different kinds of inline
>> crypto, but in the NIC section it's all the same.
> OK
> How can we document which kind of inline crypto is supported with which device?
I propose to change "See Security library for more details" to "See
Security library and PMD documentation for more details" and update
ixgbe.rst with an "inline crypto" section.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2] doc: added inline crypto feature
2017-11-08 13:26 [dpdk-dev] [PATCH] doc: added inline crypto feature Radu Nicolau
2017-11-08 14:22 ` Thomas Monjalon
@ 2017-11-09 12:23 ` Radu Nicolau
2017-11-09 12:29 ` [dpdk-dev] [PATCH v3] " Radu Nicolau
1 sibling, 1 reply; 8+ messages in thread
From: Radu Nicolau @ 2017-11-09 12:23 UTC (permalink / raw)
To: dev
Cc: thomas, ferruh.yigit, wenzhuo.lu, konstantin.ananyev,
pablo.de.lara.guarch, Radu Nicolau
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2: removed useless anchor and updated ixgbe doc
doc/guides/nics/features.rst | 15 +++++++++++++++
doc/guides/nics/features/default.ini | 1 +
doc/guides/nics/features/ixgbe.ini | 2 ++
doc/guides/nics/features/ixgbe_vec.ini | 2 ++
doc/guides/nics/features/ixgbe_vf.ini | 2 ++
doc/guides/nics/features/ixgbe_vf_vec.ini | 2 ++
doc/guides/nics/ixgbe.rst | 15 +++++++++++++++
7 files changed, 39 insertions(+)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index bfeae80..c1c3907 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -900,6 +900,21 @@ Documentation describes performance values.
See ``dpdk.org/doc/perf/*``.
+Inline crypto
+-------------
+
+Supports inline crypto processing (eg. inline IPsec). See Security library and PMD documentation for more details.
+
+* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
+* **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
+* **[implements] rte_security_ops**: ``session_create``, ``session_update``,
+ ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, ``capabilities_get``.
+* **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
+ ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
+* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
+ ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
+
+
.. _nic_features_other:
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index dc527dd..9ef6a2a 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -77,3 +77,4 @@ Usage doc =
Design doc =
Perf doc =
Mbuf fast free =
+Inline crypto =
diff --git a/doc/guides/nics/features/ixgbe.ini b/doc/guides/nics/features/ixgbe.ini
index 9ff5d8f..900840f 100644
--- a/doc/guides/nics/features/ixgbe.ini
+++ b/doc/guides/nics/features/ixgbe.ini
@@ -58,3 +58,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/features/ixgbe_vec.ini b/doc/guides/nics/features/ixgbe_vec.ini
index 4d56df4..5e32c08 100644
--- a/doc/guides/nics/features/ixgbe_vec.ini
+++ b/doc/guides/nics/features/ixgbe_vec.ini
@@ -47,3 +47,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/features/ixgbe_vf.ini b/doc/guides/nics/features/ixgbe_vf.ini
index b63e32c..f217b09 100644
--- a/doc/guides/nics/features/ixgbe_vf.ini
+++ b/doc/guides/nics/features/ixgbe_vf.ini
@@ -37,3 +37,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/features/ixgbe_vf_vec.ini b/doc/guides/nics/features/ixgbe_vf_vec.ini
index c994857..9549aab 100644
--- a/doc/guides/nics/features/ixgbe_vf_vec.ini
+++ b/doc/guides/nics/features/ixgbe_vf_vec.ini
@@ -29,3 +29,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst
index c687c63..19716c2 100644
--- a/doc/guides/nics/ixgbe.rst
+++ b/doc/guides/nics/ixgbe.rst
@@ -239,6 +239,21 @@ There is no RTE API to add a VF's MAC address from the PF. On ixgbe, the
as a workaround.
+Inline crypto processing support
+---------------------------
+
+Inline IPsec processing is supported for ``RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO``
+mode for ESP packets only:
+
+- ESP authentication only: AES-128-GMAC (128-bit key)
+- ESP encryption and authentication: AES-128-GCM (128-bit key)
+
+IPsec Security Gateway Sample Application supports inline IPsec processing for
+ixgbe PMD.
+For more details see the IPsec Security Gateway Sample Application and Security
+library documentation.
+
+
Supported Chipsets and NICs
---------------------------
--
2.7.5
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v3] doc: added inline crypto feature
2017-11-09 12:23 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
@ 2017-11-09 12:29 ` Radu Nicolau
2017-11-12 3:33 ` Thomas Monjalon
0 siblings, 1 reply; 8+ messages in thread
From: Radu Nicolau @ 2017-11-09 12:29 UTC (permalink / raw)
To: dev
Cc: thomas, ferruh.yigit, wenzhuo.lu, konstantin.ananyev,
pablo.de.lara.guarch, Radu Nicolau
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2: removed useless anchor and updated ixgbe doc
v3: removed trailing whitespaces and added line break
doc/guides/nics/features.rst | 15 +++++++++++++++
doc/guides/nics/features/default.ini | 1 +
doc/guides/nics/features/ixgbe.ini | 2 ++
doc/guides/nics/features/ixgbe_vec.ini | 2 ++
doc/guides/nics/features/ixgbe_vf.ini | 2 ++
doc/guides/nics/features/ixgbe_vf_vec.ini | 2 ++
doc/guides/nics/ixgbe.rst | 16 ++++++++++++++++
7 files changed, 40 insertions(+)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index bfeae80..c1c3907 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -900,6 +900,21 @@ Documentation describes performance values.
See ``dpdk.org/doc/perf/*``.
+Inline crypto
+-------------
+
+Supports inline crypto processing (eg. inline IPsec). See Security library and PMD documentation for more details.
+
+* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
+* **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
+* **[implements] rte_security_ops**: ``session_create``, ``session_update``,
+ ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, ``capabilities_get``.
+* **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
+ ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
+* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
+ ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
+
+
.. _nic_features_other:
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index dc527dd..9ef6a2a 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -77,3 +77,4 @@ Usage doc =
Design doc =
Perf doc =
Mbuf fast free =
+Inline crypto =
diff --git a/doc/guides/nics/features/ixgbe.ini b/doc/guides/nics/features/ixgbe.ini
index 9ff5d8f..900840f 100644
--- a/doc/guides/nics/features/ixgbe.ini
+++ b/doc/guides/nics/features/ixgbe.ini
@@ -58,3 +58,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/features/ixgbe_vec.ini b/doc/guides/nics/features/ixgbe_vec.ini
index 4d56df4..5e32c08 100644
--- a/doc/guides/nics/features/ixgbe_vec.ini
+++ b/doc/guides/nics/features/ixgbe_vec.ini
@@ -47,3 +47,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/features/ixgbe_vf.ini b/doc/guides/nics/features/ixgbe_vf.ini
index b63e32c..f217b09 100644
--- a/doc/guides/nics/features/ixgbe_vf.ini
+++ b/doc/guides/nics/features/ixgbe_vf.ini
@@ -37,3 +37,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/features/ixgbe_vf_vec.ini b/doc/guides/nics/features/ixgbe_vf_vec.ini
index c994857..9549aab 100644
--- a/doc/guides/nics/features/ixgbe_vf_vec.ini
+++ b/doc/guides/nics/features/ixgbe_vf_vec.ini
@@ -29,3 +29,5 @@ Linux VFIO = Y
ARMv8 = Y
x86-32 = Y
x86-64 = Y
+Inline crypto = Y
+
diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst
index c687c63..c0f88ba 100644
--- a/doc/guides/nics/ixgbe.rst
+++ b/doc/guides/nics/ixgbe.rst
@@ -239,6 +239,22 @@ There is no RTE API to add a VF's MAC address from the PF. On ixgbe, the
as a workaround.
+Inline crypto processing support
+---------------------------
+
+Inline IPsec processing is supported for ``RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO``
+mode for ESP packets only:
+
+- ESP authentication only: AES-128-GMAC (128-bit key)
+- ESP encryption and authentication: AES-128-GCM (128-bit key)
+
+IPsec Security Gateway Sample Application supports inline IPsec processing for
+ixgbe PMD.
+
+For more details see the IPsec Security Gateway Sample Application and Security
+library documentation.
+
+
Supported Chipsets and NICs
---------------------------
--
2.7.5
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: added inline crypto feature
2017-11-09 12:29 ` [dpdk-dev] [PATCH v3] " Radu Nicolau
@ 2017-11-12 3:33 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2017-11-12 3:33 UTC (permalink / raw)
To: Radu Nicolau
Cc: dev, ferruh.yigit, wenzhuo.lu, konstantin.ananyev, pablo.de.lara.guarch
09/11/2017 13:29, Radu Nicolau:
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
> v2: removed useless anchor and updated ixgbe doc
After a better look, re-added for consistency.
Sorry for the confusion.
> v3: removed trailing whitespaces and added line break
Applied with small changes, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-11-12 6:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-08 13:26 [dpdk-dev] [PATCH] doc: added inline crypto feature Radu Nicolau
2017-11-08 14:22 ` Thomas Monjalon
2017-11-08 14:31 ` Radu Nicolau
2017-11-08 15:13 ` Thomas Monjalon
2017-11-08 15:40 ` Radu Nicolau
2017-11-09 12:23 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2017-11-09 12:29 ` [dpdk-dev] [PATCH v3] " Radu Nicolau
2017-11-12 3:33 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).