From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 861D9A0A02; Wed, 13 Jan 2021 21:22:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31371140D25; Wed, 13 Jan 2021 21:22:58 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id A88CD140D22 for ; Wed, 13 Jan 2021 21:22:56 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E8C275C010A; Wed, 13 Jan 2021 15:22:55 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 13 Jan 2021 15:22:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= XAfCLA5dGcgWlvo0zLBw81j+IoourSMXgOnBLAKxk/0=; b=CAHm8XKDzKMqZQ5l 7Q8Ucjnpv845VldNMDGsQOKtPi6+Nhpt4pjIn14ebFSNnWuVOSgAmjAcGM6EmGNq bfywdG4GjCMYtG8DnKOj/GW9rVgGQrBMEZkN9FjihgIpzb/GBJyBKReTavwk6pid gx8ZV/jwpRHuO//ah7VxxmcB44XVHqnVpPcX8JXOvsxDgbR8VeWhfYGkDEQtGiUJ pdXhxwQ0SRmGNy93LWsYNjmDaq/5D5Nf6kKPZ4MXxjRMeXi7zyYSYHFgDrsDNx4j bmddM3N3jn9ZDuA4QB6uUlim9uXxy2M383HG2HmbvcDC2nm4mmo2rf/R/Z4DpOoM +1d76g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=XAfCLA5dGcgWlvo0zLBw81j+IoourSMXgOnBLAKxk /0=; b=oo6RsAB6CG2VPxrszBrUQdniK2x4//COWjuq/2Q2IxOIgMG6tR1UJZ9L3 jy8AKTyr7F+6HUhgMAkO5sTWq8Sq6FpW2FatfO+m3s/PQwVxtq9tSsM3oIXS5z7/ HQgpW8MTq8ngaTjMiiYvQ4TNFUbnHdjGlyGrqrhIX/y/nPnX06a1hb6+bJ2ArBf0 Sl7nFilLuJRhLN+DXnn0EOBVGQSu6gLronevQDlHjyzMeECqehZMxs7srNBBQfQd 3O5lcyShR7TAbBPhREsH8uW39xIUY2IjGEO59coVyePkZcEb23A2Ke6TAaVwywbP MZPBoXCbF5dZNFAPupx0QbuzL0JHQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedukedrtdefgddufeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 049DB24005D; Wed, 13 Jan 2021 15:22:53 -0500 (EST) From: Thomas Monjalon To: eugeny.parshutin@linux.intel.com Cc: dev@dpdk.org, kevin.laatz@intel.com, ilia.kurakin@intel.com, ciara.power@intel.com, Bruce Richardson Date: Wed, 13 Jan 2021 21:22:41 +0100 Message-ID: <2089948.Eyffe5CBD2@thomas> In-Reply-To: <20210113171119.GA639@bricha3-MOBL.ger.corp.intel.com> References: <20201202174806.10288-1-eugeny.parshutin@linux.intel.com> <20210113171119.GA639@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: add profile with vtune section to prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/01/2021 18:11, Bruce Richardson: > On Wed, Dec 02, 2020 at 08:48:06PM +0300, eugeny.parshutin@linux.intel.com wrote: > > From: Eugeny Parshutin > > > > Return back 'profiling with vtune' section to profiling programmers > > guide with updated instruction on how to enable vtune profiling > > with meson configuration option. > > > > Signed-off-by: Eugeny Parshutin > > --- > > +Profiling with VTune > > +~~~~~~~~~~~~~~~~~~~~ > > + > > +To allow VTune attaching to the DPDK application, reconfigure a DPDK build > > +folder by passing ``-Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1`` meson option > > +and recompile the DPDK: > > + > > +.. code-block:: console > > + > > + meson build > > + meson configure build -Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1 > > + ninja -C build > > + > Since the VTUNE parts seem to be protected by just "#ifdef" rather than a > check for a specific value, I think the "=1" can be omitted in the > instructions. That should also make the quoted unnecessary. > > With that change to simplify things, > > Acked-by: Bruce Richardson Fixes: 89c67ae2cba7 ("doc: remove references to make from prog guide") Cc: stable@dpdk.org Applied with above changes, thanks.