From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id B0D131396 for ; Fri, 12 Feb 2016 09:44:13 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id g62so52889190wme.0 for ; Fri, 12 Feb 2016 00:44:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=IuIQc9xfxh+QM+86oFkvGYveNiHJ5wIvYjXolylJgSI=; b=BM887apWt+jvhUPnt7Uld05XpsCTWAL6cxnKlEs6yFKoP2egPn+5FE3y29GARImNg9 2+0rB1IPjeM8mvvVy6b1NZ3CRkh+D7OYomdsdh6QwrslQuDbc18G29uGyqm7hO1uGBZp 0uPWx05pLHXDkaN6fAuspiDQF2HJmiaXXGboRQLNKnb5Ebzwlo0GVXAiyVFQOxm7on3Q UnpaGGh6RQuA5uLtiWec7L3VUR2vdnU6hNLq0lZldzkCn6KYKXeIvTyaQYv6sUG0fkF2 Y9kSxTd6nfBkKp31quPEKUpx8TA9YT1jDUYM6hN3XWIjwhtIbe78Uv8Zb9uOKsLAULjS YuDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=IuIQc9xfxh+QM+86oFkvGYveNiHJ5wIvYjXolylJgSI=; b=FEIJ7NEyAEAKnuGoBXhwms3TYvlE2A6rhco7ndKjDReT6IbR+WsXmgNpv2ut9xjgkQ 9PmAD9wS/AN8QN2lqwp9UDFVtRp5bpRkqxpcrw7PMr1g8EWGHX1/Qvsr1WwN+E7Hr5DL D0Hj7JxbCOt8D6ppzSMdT+1Uu6WEGBaWdgMrTuGgNNcTFB7h0ggKi4tK3inSTOQGmANL 0qXdEPZ3iGadBoi1OtJGHtuG5oCeUfqWh/iYaGRWswouOb98tecVSbbT7n5EPC9PoTQc 5e12vJB7mtZHL6NfxbmO/deHaX11+hNl9n3ZTdFf2BgUYNj8wXCMHPv+FxcE1xCsRa3E DlSQ== X-Gm-Message-State: AG10YOS+d0d55iS/YF8ukDymngwZ100Um5NZSlbptfOPZNn7bpGqPgBOCjxaAEEBRyD30nqv X-Received: by 10.28.195.87 with SMTP id t84mr3114791wmf.41.1455266653409; Fri, 12 Feb 2016 00:44:13 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ei9sm11020019wjd.40.2016.02.12.00.44.12 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 12 Feb 2016 00:44:12 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob Date: Fri, 12 Feb 2016 09:42:43 +0100 Message-ID: <2092360.XjJLNmQxlY@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160212064719.GA3772@localhost.localdomain> References: <1449242086-19051-1-git-send-email-jerin.jacob@caviumnetworks.com> <8996069.HySAWEmhf4@xps13> <20160212064719.GA3772@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, viktorin@rehivetech.com Subject: Re: [dpdk-dev] [PATCH v3 2/3] lpm: add support for NEON X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 08:44:13 -0000 2016-02-12 12:17, Jerin Jacob: > On Thu, Feb 11, 2016 at 12:46:33PM +0100, Thomas Monjalon wrote: > > 2016-01-29 09:40, Jerin Jacob: > > > --- a/lib/librte_lpm/Makefile > > > +++ b/lib/librte_lpm/Makefile > > > +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) > > > +SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_neon.h > > > +else > > > SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_sse.h > > > +endif > > [...] > > > --- a/lib/librte_lpm/rte_lpm.h > > > +++ b/lib/librte_lpm/rte_lpm.h > > > +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) > > > +#include "rte_lpm_neon.h" > > > +#else > > > #include "rte_lpm_sse.h" > > > +#endif > > > > Instead of defaulting to x86 SSE, it would be better to replace > > "else" by "elif X86/SSE". > > I suggest using RTE_ARCH_X86 or RTE_CPUFLAG_SSEx. > > Some architectures(tile)[1] are planning to emulate SSE instruction used > in LPM for LPM library support.So that way it makes sense to use SSE as default. Not sure it is a great idea to emulate instructions of another arch. > But if anyone has any objections then I can add the check else let > keep in existing way. If Tile wants to use x86 code, it's better to do it explicitly (X86 || TILE). > [1] > http://dpdk.org/ml/archives/dev/2016-January/031147.html