From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 09A41B3C3 for ; Wed, 13 Aug 2014 01:27:04 +0200 (CEST) Received: by mail-wg0-f51.google.com with SMTP id b13so10461755wgh.34 for ; Tue, 12 Aug 2014 16:30:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=xxMQjFsl1yYXYPObqE8a1VSbiTkNr/c3OknIJ4wVTzk=; b=Wb/b8T1bUaVTS1WjSGZG2YKlZFRCgLepvtznrhuk++1f/wX+GAw44frEFPiQxw/G4R pzPJsQbpfVlm+L4iBbQDPRzcuHpXHFX/B9gEgv9AD/m9J3+Tch/dZDCwl1QH0G/C5S97 HVEvkYm4cu5DNKUGeQR2C4bPZDVgq4amF/7JianGofSfXWzXQOqOiFtlSHgGBXpcQImi J8ksiPgkw+8rKC84AStvUL5+IUOqvH0dpwjquA5l2oAfM7gY0eon8SbCLGkwOf0myNLb cGMmVY23Jq17GapsFTboBBw08mAzIRcqfIpWDaHuA2H/tMUB6Z5ivBeZa00W/KV9F2hW 4Mjw== X-Gm-Message-State: ALoCoQnMImOfOUol46gb5VoEHsubE6cWCbXDJVL2tVL7ULfEhuAv51x2/oo99Fb2FV39rjfCmFjK X-Received: by 10.194.80.71 with SMTP id p7mr731642wjx.21.1407886201484; Tue, 12 Aug 2014 16:30:01 -0700 (PDT) Received: from xps13.localnet (APoitiers-651-1-236-237.w83-193.abo.wanadoo.fr. [83.193.123.237]) by mx.google.com with ESMTPSA id fp6sm61348594wic.11.2014.08.12.16.29.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Aug 2014 16:30:00 -0700 (PDT) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Date: Wed, 13 Aug 2014 01:29:39 +0200 Message-ID: <2092493.KHLGrS08OS@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: References: <1407233900-9734-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pcap: Fixed bug in eth_pcap_rx function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2014 23:27:04 -0000 > > Normally, bufs[i] stores the mbuf pointer, the index of buf[i] > > is the loop count i, but if header.len > buf_size, DPDK will > > free the mbuf, but the loop count i still increases, so some > > of the items in bufs[] might be NULL ponter, causing a potential > > DPDK core. Using num_rx as the index for bufs[] solves the problem. > > > > Signed-off-by: Pablo de Lara > > Tested-by: Jiajia SunX Acked-by: Thomas Monjalon Applied for version 1.7.1 Thanks -- Thomas