From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 057AF1B7BB for ; Tue, 15 May 2018 16:32:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 60EB321D50; Tue, 15 May 2018 10:32:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 15 May 2018 10:32:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=y0nO21jNSsqfLKcHzVWTZsG6o1 5sAPyFT7+l5dDCKd8=; b=TZszIGJPFewKJAlnUSt0f4OK4pCucigraqNkUJUF0I eDdOB5jqxyNDcyU4MZJ+bIbYnR4vHPAK7mzOPfsE9kpO6eEJZpd43GMAljQLf+ei Q701O9VhmDr0na/Ncfqc1ZH5jwTI0KH2Bbo9oPnLruh1qq8omHVhf/CoQNKSvpFu g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=y0nO21 jNSsqfLKcHzVWTZsG6o15sAPyFT7+l5dDCKd8=; b=JYzuqW7XomfzLT/MllcFds ZYeCiNSU4wK+EIGgN0BWO28Ad6ptQwlEB1cIhFPs3kmgFyh2ifQ945qyA03jxzXO d4rnsip4oDxlFcbuyLV696FeuXHiJIJ+v1st1FqCevJ2m27NaadMmg8C+GMiJD1U O+CSbTiHTrRqcztad1j8T9gqcoP4RIeaMiS7AFfjUPZhEoYhqkPZliTWQQroSFIl BXbqPmHTzHPGtz99bhHIcS32F8aB5q9qBAArP098c+Vc+oB7mtrOmIZTw1G4q1YD vJZtwHq81JQk/98LxmMrvU0JBJC2fDED4gXPaZL07TFlIc98zarzQk+hhwqdxePw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 661D1E50A2; Tue, 15 May 2018 10:32:12 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, Olivier Matz , konstantin.ananyev@intel.com, arybchenko@solarflare.com, shreyansh.jain@nxp.com Date: Tue, 15 May 2018 16:32:11 +0200 Message-ID: <2093442.vzybzRF3xW@xps> In-Reply-To: <20180515112817.2et5csjsktr7c6xu@glumotte.dev.6wind.com> References: <014e66f8e34cb87fa126b7494ad644ef9ac68978.1526313945.git.anatoly.burakov@intel.com> <8ef0570b-6459-e0fb-b1a7-eed2aa5dd624@intel.com> <20180515112817.2et5csjsktr7c6xu@glumotte.dev.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mempool: fix virt address mempool population X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 14:32:15 -0000 15/05/2018 13:28, Olivier Matz: > On Tue, May 15, 2018 at 08:58:06AM +0100, Burakov, Anatoly wrote: > > On 14-May-18 7:48 PM, Thomas Monjalon wrote: > > > 14/05/2018 18:06, Anatoly Burakov: > > > > Currently, populate_virt will check if mempool is already populated. > > > > This will cause inability to reserve multi-chunk mempools if > > > > contiguous memory is not a hard requirement, because if allocating > > > > all-contiguous memory fails, mempool will retry with virtual addresses > > > > and will call populate_virt. It seems that the original code never > > > > anticipated more than one non-physically contiguous area. > > > > > > > > Fix it by removing the check in populate virt. populate_anon() function > > > > calls populate_virt() also, and it can be reasonably inferred that it is > > > > expecting that virtual area is not already populated. Even though a > > > > similar check is already in place there, also add the check that was > > > > part of populate_virt() just in case. > > > > > > > > Fixes: aab4f62d6c1c ("mempool: support no hugepage mode") > > Acked-by: Olivier Matz > > > > If it is really the root cause, you need to add Cc: stable@dpdk.org. > > > > Yes. It's not as pressing for previous DPDK versions because this codepath > > wasn't triggered unless --no-huge was used, but it's still a bug. > > Agree we should queue it for stable, even if it's not that critical. Applied, thanks