* [dpdk-dev] Fw: dpdk-armv7 - Build # 342 - Failure! @ 2016-03-11 11:39 Jan Viktorin 2016-03-11 11:47 ` Sergio Gonzalez Monroy 0 siblings, 1 reply; 7+ messages in thread From: Jan Viktorin @ 2016-03-11 11:39 UTC (permalink / raw) To: Sergio Gonzalez Monroy; +Cc: dev Hello Sergio, I've detected a build regression for the ARMv7. It seems to me the source of the problem is the following commit: http://dpdk.org/browse/dpdk/commit/?id=d299106e8e31a622b3a1c1653f7795fa8a55860e The ipsec-secgw should be compiled only when LPM is enabled. See, eg. how the l3fwd-power example is done in examples/Makefile. See the attached log file for details. Regards Jan Viktorin -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] Fw: dpdk-armv7 - Build # 342 - Failure! 2016-03-11 11:39 [dpdk-dev] Fw: dpdk-armv7 - Build # 342 - Failure! Jan Viktorin @ 2016-03-11 11:47 ` Sergio Gonzalez Monroy 2016-03-11 13:33 ` Thomas Monjalon 0 siblings, 1 reply; 7+ messages in thread From: Sergio Gonzalez Monroy @ 2016-03-11 11:47 UTC (permalink / raw) To: Jan Viktorin; +Cc: dev Right! Actually the app has dependencies on a few libraries, so I'll fix that. Sergio On 11/03/2016 11:39, Jan Viktorin wrote: > Hello Sergio, > > I've detected a build regression for the ARMv7. It seems to me the > source of the problem is the following commit: > > http://dpdk.org/browse/dpdk/commit/?id=d299106e8e31a622b3a1c1653f7795fa8a55860e > > The ipsec-secgw should be compiled only when LPM is enabled. See, eg. > how the l3fwd-power example is done in examples/Makefile. > > See the attached log file for details. > > Regards > Jan Viktorin > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] Fw: dpdk-armv7 - Build # 342 - Failure! 2016-03-11 11:47 ` Sergio Gonzalez Monroy @ 2016-03-11 13:33 ` Thomas Monjalon 2016-03-11 14:53 ` Sergio Gonzalez Monroy 0 siblings, 1 reply; 7+ messages in thread From: Thomas Monjalon @ 2016-03-11 13:33 UTC (permalink / raw) To: Sergio Gonzalez Monroy; +Cc: dev, Jan Viktorin 2016-03-11 11:47, Sergio Gonzalez Monroy: > On 11/03/2016 11:39, Jan Viktorin wrote: > > Hello Sergio, > > > > I've detected a build regression for the ARMv7. It seems to me the > > source of the problem is the following commit: > > > > http://dpdk.org/browse/dpdk/commit/?id=d299106e8e31a622b3a1c1653f7795fa8a55860e > > > > The ipsec-secgw should be compiled only when LPM is enabled. See, eg. > > how the l3fwd-power example is done in examples/Makefile. > > Right! > > Actually the app has dependencies on a few libraries, so I'll fix that. Please take the opportunity to move the crypto examples in the alphabetical order in this Makefile. Thanks ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] Fw: dpdk-armv7 - Build # 342 - Failure! 2016-03-11 13:33 ` Thomas Monjalon @ 2016-03-11 14:53 ` Sergio Gonzalez Monroy 2016-03-11 15:04 ` Thomas Monjalon 0 siblings, 1 reply; 7+ messages in thread From: Sergio Gonzalez Monroy @ 2016-03-11 14:53 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, Jan Viktorin On 11/03/2016 13:33, Thomas Monjalon wrote: > 2016-03-11 11:47, Sergio Gonzalez Monroy: >> On 11/03/2016 11:39, Jan Viktorin wrote: >>> Hello Sergio, >>> >>> I've detected a build regression for the ARMv7. It seems to me the >>> source of the problem is the following commit: >>> >>> http://dpdk.org/browse/dpdk/commit/?id=d299106e8e31a622b3a1c1653f7795fa8a55860e >>> >>> The ipsec-secgw should be compiled only when LPM is enabled. See, eg. >>> how the l3fwd-power example is done in examples/Makefile. >> Right! >> >> Actually the app has dependencies on a few libraries, so I'll fix that. > Please take the opportunity to move the crypto examples in the > alphabetical order in this Makefile. Thanks > > So the fix is easy enough but I'm really not a fan of cluttering the examples/Makefile ifeq checks which would only avoid building ipsec-secgw if doing: $ make examples but would still fail to build if doing something like: $ make -C examples/ipsec-secgw I reckon that there are other CONFIG_XXX combinations that would results in failed builds. So before sending the patch, this would be what we are getting: examples/Makefile: +ifeq ($(CONFIG_RTE_LIBRTE_ACL),y) +ifeq ($(CONFIG_RTE_LIBRTE_HASH),y) +ifeq ($(CONFIG_RTE_LIBRTE_LPM),y) DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += ipsec-secgw +endif +endif +endif Another way to achive this and also avoid building the app with 'make -C ...' is something like this: examples/ipsec-secgw/Makefile: +all: +%: +ifeq ($(CONFIG_RTE_LIBRTE_ACL),y) +ifeq ($(CONFIG_RTE_LIBRTE_HASH),y) +ifeq ($(CONFIG_RTE_LIBRTE_LPM),y) +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) include $(RTE_SDK)/mk/rte.extapp.mk +endif +endif +endif +endif Anyway, none of those are the right fix, which I think should be something along the lines of Kconfig. Any preference? Sergio ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] Fw: dpdk-armv7 - Build # 342 - Failure! 2016-03-11 14:53 ` Sergio Gonzalez Monroy @ 2016-03-11 15:04 ` Thomas Monjalon 2016-03-11 15:11 ` Sergio Gonzalez Monroy 0 siblings, 1 reply; 7+ messages in thread From: Thomas Monjalon @ 2016-03-11 15:04 UTC (permalink / raw) To: Sergio Gonzalez Monroy; +Cc: dev, Jan Viktorin 2016-03-11 14:53, Sergio Gonzalez Monroy: > On 11/03/2016 13:33, Thomas Monjalon wrote: > > 2016-03-11 11:47, Sergio Gonzalez Monroy: > >> On 11/03/2016 11:39, Jan Viktorin wrote: > >>> Hello Sergio, > >>> > >>> I've detected a build regression for the ARMv7. It seems to me the > >>> source of the problem is the following commit: > >>> > >>> http://dpdk.org/browse/dpdk/commit/?id=d299106e8e31a622b3a1c1653f7795fa8a55860e > >>> > >>> The ipsec-secgw should be compiled only when LPM is enabled. See, eg. > >>> how the l3fwd-power example is done in examples/Makefile. > >> Right! > >> > >> Actually the app has dependencies on a few libraries, so I'll fix that. > > Please take the opportunity to move the crypto examples in the > > alphabetical order in this Makefile. Thanks > > > > > > So the fix is easy enough but I'm really not a fan of cluttering the > examples/Makefile ifeq checks > which would only avoid building ipsec-secgw if doing: > $ make examples > > but would still fail to build if doing something like: > $ make -C examples/ipsec-secgw If you explicitly want to build this example, it is normal to fail. > examples/Makefile: > +ifeq ($(CONFIG_RTE_LIBRTE_ACL),y) > +ifeq ($(CONFIG_RTE_LIBRTE_HASH),y) > +ifeq ($(CONFIG_RTE_LIBRTE_LPM),y) > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += ipsec-secgw > +endif > +endif > +endif You can do it in one line: ifeq ($(CONFIG_RTE_LIBRTE_ACL)$(CONFIG_RTE_LIBRTE_HASH)$(CONFIG_RTE_LIBRTE_LPM),yyy) > Another way to achive this and also avoid building the app with 'make -C > ...' is something like this: > > examples/ipsec-secgw/Makefile: > +all: > +%: > > +ifeq ($(CONFIG_RTE_LIBRTE_ACL),y) > +ifeq ($(CONFIG_RTE_LIBRTE_HASH),y) > +ifeq ($(CONFIG_RTE_LIBRTE_LPM),y) > +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) > include $(RTE_SDK)/mk/rte.extapp.mk > +endif > +endif > +endif > +endif No, as said above, you should not be smart here and let it fail. > Anyway, none of those are the right fix, which I think should be > something along the lines of Kconfig. Yes maybe one day... > Any preference? First one ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] Fw: dpdk-armv7 - Build # 342 - Failure! 2016-03-11 15:04 ` Thomas Monjalon @ 2016-03-11 15:11 ` Sergio Gonzalez Monroy 2016-03-11 15:18 ` Thomas Monjalon 0 siblings, 1 reply; 7+ messages in thread From: Sergio Gonzalez Monroy @ 2016-03-11 15:11 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, Jan Viktorin On 11/03/2016 15:04, Thomas Monjalon wrote: > 2016-03-11 14:53, Sergio Gonzalez Monroy: >> On 11/03/2016 13:33, Thomas Monjalon wrote: >>> 2016-03-11 11:47, Sergio Gonzalez Monroy: >>>> On 11/03/2016 11:39, Jan Viktorin wrote: >>>>> Hello Sergio, >>>>> >>>>> I've detected a build regression for the ARMv7. It seems to me the >>>>> source of the problem is the following commit: >>>>> >>>>> http://dpdk.org/browse/dpdk/commit/?id=d299106e8e31a622b3a1c1653f7795fa8a55860e >>>>> >>>>> The ipsec-secgw should be compiled only when LPM is enabled. See, eg. >>>>> how the l3fwd-power example is done in examples/Makefile. >>>> Right! >>>> >>>> Actually the app has dependencies on a few libraries, so I'll fix that. >>> Please take the opportunity to move the crypto examples in the >>> alphabetical order in this Makefile. Thanks >>> >>> >> So the fix is easy enough but I'm really not a fan of cluttering the >> examples/Makefile ifeq checks >> which would only avoid building ipsec-secgw if doing: >> $ make examples >> >> but would still fail to build if doing something like: >> $ make -C examples/ipsec-secgw > If you explicitly want to build this example, it is normal to fail. Fair enough. >> examples/Makefile: >> +ifeq ($(CONFIG_RTE_LIBRTE_ACL),y) >> +ifeq ($(CONFIG_RTE_LIBRTE_HASH),y) >> +ifeq ($(CONFIG_RTE_LIBRTE_LPM),y) >> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += ipsec-secgw >> +endif >> +endif >> +endif > You can do it in one line: > ifeq ($(CONFIG_RTE_LIBRTE_ACL)$(CONFIG_RTE_LIBRTE_HASH)$(CONFIG_RTE_LIBRTE_LPM),yyy) The line above goes to 85 chars, are you ok with that? or do I split it in two lines? Sergio ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] Fw: dpdk-armv7 - Build # 342 - Failure! 2016-03-11 15:11 ` Sergio Gonzalez Monroy @ 2016-03-11 15:18 ` Thomas Monjalon 0 siblings, 0 replies; 7+ messages in thread From: Thomas Monjalon @ 2016-03-11 15:18 UTC (permalink / raw) To: Sergio Gonzalez Monroy; +Cc: dev, Jan Viktorin 2016-03-11 15:11, Sergio Gonzalez Monroy: > On 11/03/2016 15:04, Thomas Monjalon wrote: > > 2016-03-11 14:53, Sergio Gonzalez Monroy: > >> examples/Makefile: > >> +ifeq ($(CONFIG_RTE_LIBRTE_ACL),y) > >> +ifeq ($(CONFIG_RTE_LIBRTE_HASH),y) > >> +ifeq ($(CONFIG_RTE_LIBRTE_LPM),y) > >> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += ipsec-secgw > >> +endif > >> +endif > >> +endif > > You can do it in one line: > > ifeq ($(CONFIG_RTE_LIBRTE_ACL)$(CONFIG_RTE_LIBRTE_HASH)$(CONFIG_RTE_LIBRTE_LPM),yyy) > > The line above goes to 85 chars, are you ok with that? or do I split it > in two lines? OK in one line ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-03-11 15:19 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-03-11 11:39 [dpdk-dev] Fw: dpdk-armv7 - Build # 342 - Failure! Jan Viktorin 2016-03-11 11:47 ` Sergio Gonzalez Monroy 2016-03-11 13:33 ` Thomas Monjalon 2016-03-11 14:53 ` Sergio Gonzalez Monroy 2016-03-11 15:04 ` Thomas Monjalon 2016-03-11 15:11 ` Sergio Gonzalez Monroy 2016-03-11 15:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).