From: Ferruh Yigit <ferruh.yigit@intel.com> To: Ori Kam <orika@mellanox.com>, Jerin Jacob <jerinjacobk@gmail.com>, Andrey Vesnovaty <andrey.vesnovaty@gmail.com> Cc: Andrey Vesnovaty <andreyv@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko <arybchenko@solarflare.com>, dpdk-dev <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH] add flow shared action API Date: Tue, 7 Jul 2020 18:52:16 +0100 Message-ID: <20b57e45-bf2d-5d6f-e6e9-300ae865e5c9@intel.com> (raw) In-Reply-To: <AM6PR05MB517682B2453DA3B6F4E0614CDB660@AM6PR05MB5176.eurprd05.prod.outlook.com> On 7/7/2020 6:24 PM, Ori Kam wrote: > Hi Ferruh, > >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yigit@intel.com> >> >> On 7/7/2020 7:21 AM, Ori Kam wrote: >>> Hi Jerin, >>> Thanks you for your quick reply. >>> >>>> -----Original Message----- >>>> From: Jerin Jacob <jerinjacobk@gmail.com> >>>> Subject: Re: [dpdk-dev] [PATCH] add flow shared action API >>>> >>>> On Mon, Jul 6, 2020 at 7:02 PM Andrey Vesnovaty >>>> <andrey.vesnovaty@gmail.com> wrote: >>>>> >>>>> Hi, Jerin. >>>> >>>> Hi Ori and Andrey, >>>> >>>> >>>>> >>>>> Please see below Ori's suggestion below to implement your >>>> rte_flow_action_update() idea >>>>> with some API changes of rte_flow_shared_action_xxx API changes. >>>>> >>>>> On Mon, Jul 6, 2020 at 3:28 PM Ori Kam <orika@mellanox.com> wrote: >>>>>> >>>>>> Hi Jerin, >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Jerin Jacob <jerinjacobk@gmail.com> >>>>>>> Sent: Monday, July 6, 2020 12:00 PM >>>>>>> Subject: Re: [dpdk-dev] [PATCH] add flow shared action API >>>>>>> >>>>>>> On Sun, Jul 5, 2020 at 3:56 PM Ori Kam <orika@mellanox.com> wrote: >>>>>>>> >>>>>>>> Hi Jerin, >>>>>>>> PSB, >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Ori >>>>>>>> >>>>>>>>> -----Original Message----- >>>>>>>>> From: Jerin Jacob <jerinjacobk@gmail.com> >>>>>>>>> Sent: Saturday, July 4, 2020 3:33 PM >>>>>>>>> dpdk-dev <dev@dpdk.org> >>>>>>>>> Subject: Re: [dpdk-dev] [PATCH] add flow shared action API >>>>>>>>> >>>>>>>>> On Sat, Jul 4, 2020 at 3:40 PM Andrey Vesnovaty >>>>>>>>> <andrey.vesnovaty@gmail.com> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> >>>>>>>>>> Andrey Vesnovaty >>>>>>>>>> (+972)526775512 | Skype: andrey775512 >>>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> [..Nip ..] >>>>>>>> >>>>>>>>>> I need to mention the locking issue once again. >>>>>>>>>> If there is a need to maintain "shared session" in the generic >>>> rte_flow >>>>>>> layer >>>>>>>>> all >>>>>>>>>> calls to flow_create() with shared action & all delete need to take >>>>>>>>> sharedsession >>>>>>>>>> management locks at least for verification. Lock partitioning is also >>>> bit >>>>>>>>> problematic >>>>>>>>>> since one flow may have more than one shared action. >>>>>>>>> >>>>>>>>> Then, I think better approach would be to introduce >>>>>>>>> rte_flow_action_update() public >>>>>>>>> API which can either take "const struct rte_flow_action []" OR shared >>>>>>>>> context ID, to cater to >>>>>>>>> both cases or something on similar lines. This would allow HW's >>>>>>>>> without have the shared context ID >>>>>>>>> to use the action update. >>>>>>>> >>>>>>>> Can you please explain your idea? >>>>>>> >>>>>>> I see two types of HW schemes supporting action updates without going >>>>>>> through call `rte_flow_destroy()` and call `rte_flow_create()` >>>>>>> - The shared HW action context feature >>>>>>> - The HW has "pattern" and "action" mapped to different HW objects >> and >>>>>>> action can be updated any time. >>>>>>> Other than above-mentioned RSS use case, another use case would be to >>>>>>> a) create rte_flow and set the action as DROP (Kind of reserving the HW >>>> object) >>>>>>> b) Update the action only when the rest of the requirements ready. >>>>>>> >>>>>>> Any API schematic that supports both notions of HW is fine with me. >>>>>>> >>>>>> I have an idea if the API will be changed to something like this, >>>>>> Rte_flow_shared_action_update(uint16_port port, rte_shared_ctx *ctx, >>>> rte_flow_action *action, error) >>>>>> This will enable the application to send a different action than the original >>>> one to be switched. >>>>>> Assuming the PMD supports this. >>>>>> Does it answer your concerns? >>>>> >>>>> >>>>> This allows both: >>>>> 1. Update action configuration >>>>> 2. Replace action by some other action >>>>> For 2 pure software implementation may carate shred action (that can be >>>> shared >>>>> with one flow only, depends on PMD) and later on >>>> rte_flow_shared_action_update may replace this >>>>> action with some other action by handle returned from >>>> rte_flow_shared_action_create >>>>> Doesign between 1 and 2 is per PMD. >>>> >>>> struct rte_flow * object holds the driver representation of the >>>> pattern + action. >>>> So in order to update the action, we would need struct rte_flow * in API. >>>> >>> Why is that? The idea is to change the action, the action itself is connected to >> flows. >>> The PMD can save in the shared_ctx all flows that are connected to this >> action. >>> >>>> I think, simple API change would be to accommodate "rte_shared_ctx >>>> *ctx, rte_flow_action *action" modes >>>> without introducing the emulation for one or other mode, will be. >>>> >>>> enum rte_flow_action_update_type { >>>> RTE_FLOW_ACTION_UPDATE_TYPE_SHARED_ACTION, >>>> RTE_FLOW_ACTION_UPDATE_TYPE_ACTION, >>>> }; >>>> >>>> struct rte_flow_action_update_type_param { >>>> enum rte_flow_action_update_type type; >>>> union { >>>> struct rte_flow_action_update_type_shared_action_param { >>>> rte_shared_ctx *ctx; >>>> } shared_action; >>>> struct rte_flow_action_update_type_shared_action_param { >>>> rte_flow *flow, >>>> rte_flow_action *action; >>>> } action; >>>> } >>>> } >>>> >>> Thank you for the idea but I fall to see how your suggested API is simpler than >> the one suggested by me? >>> In my suggestion the PMD simply needs to check if the new action and >> change the >>> context and to that action, or just change parameters in the action, if it is the >> same action. >>> >>> Let's go with the original patch API modified to support like you requested >> also changing the action, >>> based on my comments. >>> >>>> rte_flow_action_update(uint16_port port, struct >>>> rte_flow_action_update_type_param *param, error) >>>> >>>>> >>>>>> >>>>>>> >>>>>>>> As I can see if we use the flow_action array it may result in bugs. >>>>>>>> For example, the application created two flows with the same RSS (not >>>> using >>>>>>> the context) >>>>>>>> Then he wants to change one flow to use different RSS, but the result >> will >>>> that >>>>>>> both flows >>>>>>>> will be changed. >>>>>>> >>>>>>> Sorry. I don't quite follow this. >>>>>>> >>>>>> I was trying to show that there must be some context. But I don’t think this >> is >>>> relevant to >>>>>> your current ideas. >>>>>> >>>>>>>> Also this will enforce the PMD to keep track on all flows which will have >>>>>>> memory penalty for >>>>>>>> some PMDs. >> >> Hi Ori, Andrey, >> >> This is a set of new APIs and we are very close to the -rc1, so we have only a >> few days to close the feature to merge them for this release. >> >> Also accompanying PMD and testpmd implementation with the proposed API >> changes >> looks missing. >> >> We can either postpone the patchset to next release to give time for more >> PMD >> owners to participate, which can give better API for long term. >> Or try to to squeeze into this release taking into account that the APIs will be >> experimental. >> >> What do you think, what is you schedule for the feature, do you have room to >> postpone it? > Not so much it is an important API for Mellanox. Got it. > >> If not, first existing discussions needs to resolved, and it is good to have the >> PMD and testpmd implementations, do you think can this be done for next few >> days? >> > I think that this is the correct API to implement, I fully agree that this API is experimental > just like any other new API, and might change based on comments and use cases. > I know that Mellanox is committed to this feature and that Andrey is working around the clock > to complete the missing parts, and should have a version by tomorrow (July 8th ) evening. OK > (with update to flow filtering sample app, testpmd will not be ready by RC1, but it will be for RC2) > We would like very much to push it in this version. OK, please conclude the existing discussion before finalizing.
next prev parent reply other threads:[~2020-07-07 17:52 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-02 12:05 Andrey Vesnovaty 2020-07-03 15:02 ` Jerin Jacob 2020-07-03 15:21 ` Thomas Monjalon 2020-07-04 9:54 ` Andrey Vesnovaty 2020-07-04 10:10 ` Andrey Vesnovaty 2020-07-04 12:33 ` Jerin Jacob 2020-07-05 10:26 ` Ori Kam 2020-07-06 9:00 ` Jerin Jacob 2020-07-06 12:28 ` Ori Kam 2020-07-06 13:32 ` Andrey Vesnovaty 2020-07-07 2:30 ` Jerin Jacob 2020-07-07 6:21 ` Ori Kam 2020-07-07 15:21 ` Ferruh Yigit 2020-07-07 17:24 ` Ori Kam 2020-07-07 17:52 ` Ferruh Yigit [this message] 2020-07-07 19:38 ` Jerin Jacob 2020-07-07 21:03 ` Ori Kam 2020-07-08 9:25 ` Jerin Jacob 2020-07-08 9:47 ` Ori Kam 2020-07-08 11:00 ` Jerin Jacob 2020-07-08 11:50 ` Thomas Monjalon 2020-07-08 12:18 ` Ori Kam [not found] ` <20200708204015.24429-2-andreyv@mellanox.com> 2020-07-13 8:04 ` [dpdk-dev] [PATCH v2 1/6] ethdev: " Kinsella, Ray 2020-07-13 10:16 ` Andrew Rybchenko 2020-07-15 8:54 ` Andrew Rybchenko 2020-07-15 9:00 ` Andrew Rybchenko 2020-09-15 11:30 ` Andrey Vesnovaty [not found] ` <20200708204015.24429-3-andreyv@mellanox.com> 2020-07-13 8:06 ` [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX Kinsella, Ray 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API Andrey Vesnovaty 2020-09-12 2:18 ` Ajit Khaparde 2020-09-15 11:50 ` Andrey Vesnovaty 2020-09-15 15:49 ` Ajit Khaparde 2020-09-16 15:52 ` Andrey Vesnovaty 2020-09-16 19:20 ` Ajit Khaparde 2020-09-17 15:33 ` Andrew Rybchenko 2020-09-17 16:02 ` Ori Kam 2020-09-24 19:25 ` Ajit Khaparde 2020-09-26 11:09 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 00/10] RTE flow shared action Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 01/10] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-04 11:10 ` Ori Kam 2020-10-06 10:22 ` Andrey Vesnovaty 2020-10-04 17:00 ` Stephen Hemminger 2020-10-04 17:01 ` Stephen Hemminger 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 02/10] ethdev: add conf arg to shared action icreate API Andrey Vesnovaty 2020-10-04 11:11 ` Ori Kam 2020-10-06 10:28 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 03/10] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 04/10] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 05/10] net/mlx5: shared action PMD Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 06/10] net/mlx5: shared action PMD create conf arg Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 07/10] net/mlx5: driver support for shared action Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 08/10] net/mlx5: shared action create conf drv support Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 09/10] examples/flow_filtering: utilize shared RSS action Andrey Vesnovaty 2020-10-04 11:21 ` Ori Kam 2020-10-06 10:34 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 10/10] app/testpmd: support shared action Andrey Vesnovaty 2020-10-04 11:28 ` Ori Kam 2020-10-04 12:04 ` Ori Kam 2020-10-06 10:36 ` Andrey Vesnovaty 2020-10-04 11:14 ` [dpdk-dev] [PATCH v3 00/10] RTE flow " Ori Kam 2020-10-06 10:28 ` Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 3/6] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 4/6] net/mlx5: shared action PMD Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 5/6] net/mlx5: driver support for shared action Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action Andrey Vesnovaty 2020-07-09 4:44 ` Jerin Jacob 2020-07-09 6:08 ` Ori Kam 2020-07-09 12:25 ` Andrey Vesnovaty 2020-07-09 12:39 ` Thomas Monjalon 2020-07-09 4:39 ` [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD Jerin Jacob 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 0/2] RTE flow shared action Andrey Vesnovaty 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 6:27 ` Ori Kam 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 6:30 ` Ori Kam 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 0/2] RTE flow " Andrey Vesnovaty 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 13:01 ` Ori Kam 2020-10-07 21:23 ` Ajit Khaparde 2020-10-08 7:28 ` Andrey Vesnovaty 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 0/2] RTE flow " Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 20:01 ` Ajit Khaparde 2020-10-08 10:58 ` Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 0/2] RTE flow " Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-08 22:30 ` Ajit Khaparde 2020-10-14 11:47 ` Andrey Vesnovaty 2020-10-12 14:19 ` Andrew Rybchenko 2020-10-13 20:06 ` Andrey Vesnovaty 2020-10-14 6:49 ` Andrew Rybchenko 2020-10-14 7:22 ` Thomas Monjalon 2020-10-14 11:43 ` Andrey Vesnovaty 2020-10-14 11:42 ` Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-08 23:54 ` Ajit Khaparde 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 0/2] RTE flow " Andrey Vesnovaty 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 1/2] ethdev: add shared actions to flow API Andrey Vesnovaty 2020-10-14 11:44 ` Andrew Rybchenko 2020-10-14 16:17 ` Ferruh Yigit 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: support shared action Andrey Vesnovaty
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20b57e45-bf2d-5d6f-e6e9-300ae865e5c9@intel.com \ --to=ferruh.yigit@intel.com \ --cc=andrey.vesnovaty@gmail.com \ --cc=andreyv@mellanox.com \ --cc=arybchenko@solarflare.com \ --cc=dev@dpdk.org \ --cc=jerinjacobk@gmail.com \ --cc=orika@mellanox.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git