From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AC24C374F for ; Fri, 9 Dec 2016 19:00:03 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 09 Dec 2016 10:00:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="16013464" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga002.jf.intel.com with ESMTP; 09 Dec 2016 10:00:01 -0800 To: Bernard Iremonger , thomas.monjalon@6wind.com, dev@dpdk.org References: <1481282878-26176-1-git-send-email-bernard.iremonger@intel.com> <1481304361-16032-9-git-send-email-bernard.iremonger@intel.com> From: Ferruh Yigit Message-ID: <20e50d1e-4d59-c35c-26ab-a753d84a2450@intel.com> Date: Fri, 9 Dec 2016 18:00:00 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481304361-16032-9-git-send-email-bernard.iremonger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 8/9] librte_ether: remove the set VF API's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 18:00:04 -0000 On 12/9/2016 5:26 PM, Bernard Iremonger wrote: > remove the following API's: > > rte_eth_dev_set_vf_rxmode > rte_eth_dev_set_vf_rx > rte_eth_dev_set_vf_tx > rte_eth_dev_set_vf_vlan_filter > rte_eth_dev_set_vf_rate_limit This patch should also remove above function definitions from rte_ethdev.h and rte_ether_version.map too. And it may be good to squash next patch (remove deprecation notice) to this one to show what caused to notice removal. Also need to increase LIBABIVER, and update release notes for ABI breakage, somewhere in this patchset, I would do in this patch but not quite sure. > > Signed-off-by: Bernard Iremonger > --- > lib/librte_ether/rte_ethdev.c | 129 ------------------------------------------ > lib/librte_ether/rte_ethdev.h | 33 ----------- > 2 files changed, 162 deletions(-) > <...>