From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F0B0A0524; Thu, 4 Feb 2021 17:41:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29DC52406C5; Thu, 4 Feb 2021 17:41:02 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 444B024069D; Thu, 4 Feb 2021 17:41:00 +0100 (CET) IronPort-SDR: twzOq/Wl8ctFUuPodS4odWjqo2aIrhXqJBAIEKLj3A9vcgOa+Uda8INMA1emEECDhi8tVl50lT Xf1cnqAVz+Cw== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="181346039" X-IronPort-AV: E=Sophos;i="5.79,401,1602572400"; d="scan'208";a="181346039" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 08:40:56 -0800 IronPort-SDR: gZTrl9//Bp5X7wzYjgUKziV2r8r66oYFROYQ1giL1Q/MWYMstL/yDfeGLKD7nv6qgfvm+S/HaR 2cefWFbH+Hhg== X-IronPort-AV: E=Sophos;i="5.79,401,1602572400"; d="scan'208";a="393266693" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.211.210]) ([10.213.211.210]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 08:40:56 -0800 To: "Ferriter, Cian" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20210203173025.2786063-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <20ebc1f8-5624-647c-85bb-72443b8521fd@intel.com> Date: Thu, 4 Feb 2021 16:40:52 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/pcap: fix byte stats for drop Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/4/2021 3:47 PM, Ferriter, Cian wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Wednesday 3 February 2021 17:30 >> To: Ferriter, Cian >> Cc: Yigit, Ferruh ; dev@dpdk.org; stable@dpdk.org >> Subject: [PATCH] net/pcap: fix byte stats for drop Tx >> >> Drop Tx path in pcap is Tx that just drops the packets, which is used >> for the case only Rx from a pcap file is requested/matters. >> >> The byte stats was calculated using first mbuf segment, which gives >> wrong values for multi segmented mbufs, updated to use packet length >> instead. >> >> Bugzilla ID: 597 >> Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file") >> Cc: stable@dpdk.org >> >> Reported-by: Cian Ferriter >> Signed-off-by: Ferruh Yigit >> --- > > Acked-by: Cian Ferriter > > Tested this with 2 large PCAPs and it works as expected: Applied to dpdk-next-net/main, thanks.