From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5F978201 for ; Wed, 1 Mar 2017 10:55:18 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2017 01:55:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,224,1484035200"; d="scan'208";a="829666745" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.69]) ([10.237.221.69]) by FMSMGA003.fm.intel.com with ESMTP; 01 Mar 2017 01:55:16 -0800 To: Bruce Richardson References: <1485163480-156507-2-git-send-email-david.hunt@intel.com> <1487647073-129064-1-git-send-email-david.hunt@intel.com> <1487647073-129064-2-git-send-email-david.hunt@intel.com> <20170224140350.GB106392@bricha3-MOBL3.ger.corp.intel.com> Cc: dev@dpdk.org From: "Hunt, David" Message-ID: <20ec8155-1fa2-c1ad-4b85-e14b688ddb0e@intel.com> Date: Wed, 1 Mar 2017 09:55:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170224140350.GB106392@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 01/17] lib: rename legacy distributor lib files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 09:55:18 -0000 On 24/2/2017 2:03 PM, Bruce Richardson wrote: > On Tue, Feb 21, 2017 at 03:17:37AM +0000, David Hunt wrote: >> Move files out of the way so that we can replace with new >> versions of the distributor libtrary. Files are named in >> such a way as to match the symbol versioning that we will >> apply for backward ABI compatibility. >> >> Signed-off-by: David Hunt >> --- >> app/test/test_distributor.c | 2 +- >> app/test/test_distributor_perf.c | 2 +- >> examples/distributor/main.c | 2 +- >> lib/librte_distributor/Makefile | 4 +- >> lib/librte_distributor/rte_distributor.c | 487 --------------------------- >> lib/librte_distributor/rte_distributor.h | 247 -------------- >> lib/librte_distributor/rte_distributor_v20.c | 487 +++++++++++++++++++++++++++ >> lib/librte_distributor/rte_distributor_v20.h | 247 ++++++++++++++ > Rather than changing the unit tests and example applications, I think > this patch would be better with a new rte_distributor.h file which > simply does "#include ". Alternatively, I > recently upstreamed a patch, which went into 17.02, to allow symlinks in > the folder so you could create a symlink to the renamed file. > > /Bruce Thanks for the review, Bruce. I've just finished reworking the patchset on your review comments (including later emails) and will post soon. Regards, Dave.