From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0EB843AFA; Sun, 18 Feb 2024 04:41:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E3BC402BB; Sun, 18 Feb 2024 04:41:34 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id AA78440262 for ; Sun, 18 Feb 2024 04:41:32 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Tcryf4NN4z1Q8nL; Sun, 18 Feb 2024 11:39:54 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id AD09E14011B; Sun, 18 Feb 2024 11:41:29 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 18 Feb 2024 11:41:29 +0800 Subject: Re: [PATCH v3 0/7] fix race-condition of proactive error handling mode From: fengchengwen To: , , , CC: , , , References: <20230301030610.49468-1-fengchengwen@huawei.com> <20231106131128.33499-1-fengchengwen@huawei.com> <4e8a1d78-74a5-2118-de34-97e7f5ce63e0@huawei.com> <9b6b9dd8-17f4-56ed-862a-36e14e2359fc@huawei.com> <243d728e-a127-2292-e79c-64d996b3da2e@huawei.com> Message-ID: <20f63760-16c7-610f-ac88-64b4db8f50e7@huawei.com> Date: Sun, 18 Feb 2024 11:41:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <243d728e-a127-2292-e79c-64d996b3da2e@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh, This patchset will modify lib/ethdev/, Could you help review it before RC1? Thanks On 2024/1/29 9:16, fengchengwen wrote: > Hi Ferruh, > > Kindly ping for review. > > Thanks > > On 2024/1/15 9:44, fengchengwen wrote: >> Kindly ping. >> >> On 2023/12/5 10:30, fengchengwen wrote: >>> Hi Ferruh, >>> >>> I notice this patchset was delegated to you, so could you take a view? >>> >>> Thanks. >>> >>> On 2023/11/6 21:11, Chengwen Feng wrote: >>>> This patch fixes race-condition of proactive error handling mode, the >>>> discussion thread [1]. >>>> >>>> [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kaladi@intel.com/ >>>> >>>> Chengwen Feng (7): >>>> ethdev: fix race-condition of proactive error handling mode >>>> net/hns3: replace fp ops config function >>>> net/bnxt: fix race-condition when report error recovery >>>> net/bnxt: use fp ops setup function >>>> app/testpmd: add error recovery usage demo >>>> app/testpmd: extract event handling to event.c >>>> doc: testpmd support event handling section >>>> >>>> --- >>>> v3: >>>> - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit. >>>> - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li. >>>> v2: >>>> - extract event handling to event.c and document it, which address >>>> Ferruh's comment. >>>> - add ack-by from Konstantin Ananyev and Dongdong Liu. >>>> >>>> app/test-pmd/event.c | 390 +++++++++++++++++++ >>>> app/test-pmd/meson.build | 1 + >>>> app/test-pmd/parameters.c | 36 +- >>>> app/test-pmd/testpmd.c | 247 +----------- >>>> app/test-pmd/testpmd.h | 10 +- >>>> doc/guides/prog_guide/poll_mode_drv.rst | 20 +- >>>> doc/guides/testpmd_app_ug/event_handling.rst | 81 ++++ >>>> doc/guides/testpmd_app_ug/index.rst | 1 + >>>> drivers/net/bnxt/bnxt_cpr.c | 18 +- >>>> drivers/net/bnxt/bnxt_ethdev.c | 9 +- >>>> drivers/net/hns3/hns3_rxtx.c | 21 +- >>>> lib/ethdev/ethdev_driver.c | 8 + >>>> lib/ethdev/ethdev_driver.h | 10 + >>>> lib/ethdev/rte_ethdev.h | 32 +- >>>> lib/ethdev/version.map | 1 + >>>> 15 files changed, 552 insertions(+), 333 deletions(-) >>>> create mode 100644 app/test-pmd/event.c >>>> create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst >>>> >>> . >>> >> . >> > . >