From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id AE6B02C45 for ; Fri, 11 Mar 2016 16:06:06 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id l68so21291776wml.1 for ; Fri, 11 Mar 2016 07:06:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=N+ys5qHIVIQuC9DeVSlDyalC2Ekidxemp7UOrIho2SQ=; b=oxVh5kjmWFzSH5ze4Mtz+2M8axWadj473CJ1H8KqEStlAOPBHtj8kuc9YLfXx98ZNG +a31K1PIY6NA919TNFnh1IKTZLuNGdvroDNFfniOtQcusDjs7fePZT1OdHWPUP8743Hf kKAPtetSlhlFcZCGGjmGtGAoh3ZFKBpPQQBuaYhgaWYVFh+pCDk0le1HGJLIaicemI81 UmkOxIPDMBGLF3sNmFEG7q4AafbmJX2vfXsRrXd1vkZBWp388sEHGn93EKNcH6U8Cxgj wLK0YgOUe3iLGiUvMq4unrjGSwPVcQT99S1vUYRFj5bl/v21H27ZjINO92KDnbdPebzg 2u7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=N+ys5qHIVIQuC9DeVSlDyalC2Ekidxemp7UOrIho2SQ=; b=LL0Z9PYmFN4lRX5I8PuinAJoyZOFaIhVdkGGSpeSvM6/t0RrQfQ7OUBMbfAk7lTes4 GSsz5Y+nte170+Ft0O0SNgU7Gn/mGDBVHztmtcJpuYX3YUA3U/+jPaVO3KZzlfg3EqSK ywC5rynrQG2t11cReHkLTuK4aZSFZ6QjcSMuR8nng7zgvTIgh4ncv0K1bIVBYCFcasic AkqIdbuMXKsTxRr0d8SJ8J3OiQzYU31iMruUuEZlpOYNN70SCLoazWRA7WZoRFeRdRaR ZTOVm2G9j66tG8f+g9TIB7ucKGYrJAS5dawy2NdMKpoJec+PcfaHCTCMgN44m45Dg50Q mEWA== X-Gm-Message-State: AD7BkJKbuXBSCoEu6b6bjuAne7+kUE8Jfw9uS3rDbwKcS0Nm7uKyU5cXiywqYU7DjGF+YJRQ X-Received: by 10.28.195.9 with SMTP id t9mr3663806wmf.0.1457708766513; Fri, 11 Mar 2016 07:06:06 -0800 (PST) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id ks5sm8890104wjb.13.2016.03.11.07.06.05 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 Mar 2016 07:06:05 -0800 (PST) From: Thomas Monjalon To: Sergio Gonzalez Monroy Date: Fri, 11 Mar 2016 16:04:22 +0100 Message-ID: <2101263.CINWvX51Cb@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56E2DBE3.4030309@intel.com> References: <20160311123910.779f9c2e@jvn> <2098276.9k93xeoVuW@xps13> <56E2DBE3.4030309@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Jan Viktorin Subject: Re: [dpdk-dev] Fw: dpdk-armv7 - Build # 342 - Failure! X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 15:06:06 -0000 2016-03-11 14:53, Sergio Gonzalez Monroy: > On 11/03/2016 13:33, Thomas Monjalon wrote: > > 2016-03-11 11:47, Sergio Gonzalez Monroy: > >> On 11/03/2016 11:39, Jan Viktorin wrote: > >>> Hello Sergio, > >>> > >>> I've detected a build regression for the ARMv7. It seems to me the > >>> source of the problem is the following commit: > >>> > >>> http://dpdk.org/browse/dpdk/commit/?id=d299106e8e31a622b3a1c1653f7795fa8a55860e > >>> > >>> The ipsec-secgw should be compiled only when LPM is enabled. See, eg. > >>> how the l3fwd-power example is done in examples/Makefile. > >> Right! > >> > >> Actually the app has dependencies on a few libraries, so I'll fix that. > > Please take the opportunity to move the crypto examples in the > > alphabetical order in this Makefile. Thanks > > > > > > So the fix is easy enough but I'm really not a fan of cluttering the > examples/Makefile ifeq checks > which would only avoid building ipsec-secgw if doing: > $ make examples > > but would still fail to build if doing something like: > $ make -C examples/ipsec-secgw If you explicitly want to build this example, it is normal to fail. > examples/Makefile: > +ifeq ($(CONFIG_RTE_LIBRTE_ACL),y) > +ifeq ($(CONFIG_RTE_LIBRTE_HASH),y) > +ifeq ($(CONFIG_RTE_LIBRTE_LPM),y) > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += ipsec-secgw > +endif > +endif > +endif You can do it in one line: ifeq ($(CONFIG_RTE_LIBRTE_ACL)$(CONFIG_RTE_LIBRTE_HASH)$(CONFIG_RTE_LIBRTE_LPM),yyy) > Another way to achive this and also avoid building the app with 'make -C > ...' is something like this: > > examples/ipsec-secgw/Makefile: > +all: > +%: > > +ifeq ($(CONFIG_RTE_LIBRTE_ACL),y) > +ifeq ($(CONFIG_RTE_LIBRTE_HASH),y) > +ifeq ($(CONFIG_RTE_LIBRTE_LPM),y) > +ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) > include $(RTE_SDK)/mk/rte.extapp.mk > +endif > +endif > +endif > +endif No, as said above, you should not be smart here and let it fail. > Anyway, none of those are the right fix, which I think should be > something along the lines of Kconfig. Yes maybe one day... > Any preference? First one